Skip to contentSkip to conversation

arch/arc: fix atmoics selection

PATCH New Yann E. MORIN 2 participants 3 messages Sep 11, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/arc: fix atmoics selection

Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by be conditionally re-defined in one or more if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other archtectures, except that in the arc case, the default value is conditional.

[yann.morin.1998 at free.fr: indepently re-done a patch similar to the one
Thomas made on his own]

Cc Thomas Petazzoni <[email protected]>
---
 arch/Config.in.arc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/Config.in.arc +3 -1
index 8a7f290..fcb5d7d 100644
@@ -1,7 +1,9 @@
 # Choise of atomic instructions presence
 config BR2_ARC_ATOMIC_EXT
 	bool "Atomic extension (LLOCK/SCOND instructions)"
-	select BR2_ARCH_HAS_ATOMICS
+
+config BR2_ARCH_HAS_ATOMICS
+	default y if BR2_ARC_ATOMIC_EXT
 
 config BR2_ARCH
 	default "arc"	if BR2_arcle
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arch/arc: fix atmoics selection

Dear Yann E. MORIN,

Minor typo in title: atmoics -> atomics.

Quoted 2 lines · Yann E. MORIN

Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by be conditionally re-defined in one or more

"by be" ?

Quoted 4 lines

if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other archtectures, except that in the arc

architectures

Quoted 7 lines

case, the default value is conditional.

[yann.morin.1998 at free.fr: indepently re-done a patch similar to the one
Thomas made on his own]

Cc Thomas Petazzoni <[email protected]>

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 arch/arc: fix atmoics selection

Thomas, All,

On 2014-09-11 22:34 +0200, Thomas Petazzoni spake thusly:

Quoted 1 line

Minor typo in title: atmoics -> atomics.

Eh...

Quoted 5 lines · Yann E. MORIN
Quoted 2 lines

Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by be conditionally re-defined in one or more

"by be" ?

by being...

Quoted 6 lines
Quoted 4 lines

if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other archtectures, except that in the arc

architectures

OK. Will re-spin. Thans!

Regards,
Yann E. MORIN.

Quoted 15 lines
Quoted 7 lines

case, the default value is conditional.

[yann.morin.1998 at free.fr: indepently re-done a patch similar to the one
Thomas made on his own]

Cc Thomas Petazzoni <[email protected]>

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'