Adds ipmitool, a command-line interface to IPMI-enabled devices.
PATCH 1/1 Adds ipmitool, a command-line interface to IPMI-enabled devices.
---
v2:
- ipmitool needs MMU (David Bachelart)
- moved package from "networking applications" to "hardware handling" (used "networking applications" originally, because ipmitool can be used to send commands to the BMC of a remote server, e.g. telling it to reboot the system.
However another use of ipmitool is to configure the local BMC and "hardware handling" might be a better match for both.)
--- package/Config.in | 1 + package/ipmitool/Config.in | 17 +++++++++++++++++ package/ipmitool/ipmitool.mk | 25 +++++++++++++++++++++++++ 3 files changed, 43 insertions(+) create mode 100644 package/ipmitool/Config.in create mode 100644 package/ipmitool/ipmitool.mk
package/Config.in +1 -0
@@ -321,6 +321,7 @@ endif source "package/input-tools/Config.in" source "package/intel-microcode/Config.in" source "package/iostat/Config.in" + source "package/ipmitool/Config.in" source "package/irda-utils/Config.in" source "package/iucode-tool/Config.in" source "package/kbd/Config.in"
package/ipmitool/Config.in new file +17 -0
@@ -0,0 +1,17 @@ +config BR2_PACKAGE_IPMITOOL + bool "ipmitool" + depends on BR2_USE_MMU # fork() + select BR2_PACKAGE_OPENSSL + help + IPMItool provides a simple command-line interface to IPMI-enabled devices. + + http://sourceforge.net/projects/ipmitool/ + +if BR2_PACKAGE_IPMITOOL + +config BR2_PACKAGE_IPMITOOL_IPMIEVD + bool "ipmievd" + help + IPMI event daemon for sending events to syslog + +endif
package/ipmitool/ipmitool.mk new file +25 -0
@@ -0,0 +1,25 @@ +################################################################################ +# +# ipmitool +# +################################################################################ + +IPMITOOL_VERSION = 1.8.14 +IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2 +IPMITOOL_SITE = http://downloads.sourceforge.net/project/ipmitool/ipmitool/$(IPMITOOL_VERSION) +IPMITOOL_LICENSE = BSD-3c +IPMITOOL_LICENSE_FILES = COPYING +IPMITOOL_DEPENDENCIES = openssl + +ifeq ($(BR2_PACKAGE_READLINE),y) +IPMITOOL_DEPENDENCIES += readline +endif + +ifneq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),y) +define IPMITOOL_REMOVE_IPMIEVD + $(RM) -f $(TARGET_DIR)/usr/sbin/ipmievd +endef +IPMITOOL_POST_INSTALL_TARGET_HOOKS += IPMITOOL_REMOVE_IPMIEVD +endif + +$(eval $(autotools-package))
Signature · 1 line
1.8.3.2
PATCH 1/1 Adds ipmitool, a command-line interface to IPMI-enabled devices.
Dear Floris Bos,
The title of the commit should be:
ipmitool: new package
package/ipmitool/Config.in line 4
Quoted 10 lines · Floris Bos
package/ipmitool/Config.in new file +4
-0@@ -0,0 +1,17 @@ +config BR2_PACKAGE_IPMITOOL + bool "ipmitool" + depends on BR2_USE_MMU # fork() + select BR2_PACKAGE_OPENSSL
This looks wrong: I was able to build the ipmitool package without openssl. So openssl seems like an optional dependency, not a mandatory one. The fact that David Bachelart was also able to build ipmitool without openssl seems to confirm this.
Quoted 21 lines
package/ipmitool/Config.in new file +13
-0+ help + IPMItool provides a simple command-line interface to IPMI-enabled devices. + + http://sourceforge.net/projects/ipmitool/ + +if BR2_PACKAGE_IPMITOOL + +config BR2_PACKAGE_IPMITOOL_IPMIEVD + bool "ipmievd" + help + IPMI event daemon for sending events to syslog + +endifpackage/ipmitool/ipmitool.mk new file +2
-0@@ -0,0 +1,25 @@ +################################################################################ +#
package/ipmitool/ipmitool.mk line 12
Quoted 10 lines
package/ipmitool/ipmitool.mk new file +10
-0+# ipmitool +# +################################################################################ + +IPMITOOL_VERSION = 1.8.14 +IPMITOOL_SOURCE = ipmitool-$(IPMITOOL_VERSION).tar.bz2 +IPMITOOL_SITE = http://downloads.sourceforge.net/project/ipmitool/ipmitool/$(IPMITOOL_VERSION) +IPMITOOL_LICENSE = BSD-3c +IPMITOOL_LICENSE_FILES = COPYING +IPMITOOL_DEPENDENCIES = openssl
So this should be handled like readline, as an optional dependency.
package/ipmitool/ipmitool.mk line 18
Quoted 6 lines
package/ipmitool/ipmitool.mk new file +6
-0+ +ifeq ($(BR2_PACKAGE_READLINE),y) +IPMITOOL_DEPENDENCIES += readline +endif + +ifneq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),y)
Or, better, use positive logic:
ifeq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),)
package/ipmitool/ipmitool.mk line 25
Quoted 7 lines
package/ipmitool/ipmitool.mk new file +7
-0+define IPMITOOL_REMOVE_IPMIEVD + $(RM) -f $(TARGET_DIR)/usr/sbin/ipmievd +endef +IPMITOOL_POST_INSTALL_TARGET_HOOKS += IPMITOOL_REMOVE_IPMIEVD +endif + +$(eval $(autotools-package))
Other than that, looks good to me. Care to fix those issues and resend?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 Adds ipmitool, a command-line interface to IPMI-enabled devices.
Hi Thomas,
Quoted 5 lines · Thomas Petazzoni
Dear Floris Bos,
The title of the commit should be:
ipmitool: new package
Sorry, forgot that line in v2.
Quoted 16 lines · Floris Bos
package/ipmitool/Config.in line 4
Quoted 11 lines
package/ipmitool/Config.in new file +4
-0@@ -0,0 +1,17 @@ +config BR2_PACKAGE_IPMITOOL + bool "ipmitool" + depends on BR2_USE_MMU # fork() + select BR2_PACKAGE_OPENSSLThis looks wrong: I was able to build the ipmitool package without openssl. So openssl seems like an optional dependency, not a mandatory one. The fact that David Bachelart was also able to build ipmitool without openssl seems to confirm this.
Ah, you are right.
You do can build without OpenSSL if you only want to use ipmitool to talk to the local BMC using the openipmi kernel driver. This is typically used to configure it, e.g. to set an IP/netmask/gateway address, so the BMC can be remotely accessed.
My own usage does not involve initial configuration of a local BMC, but is about sending commands to the BMC of OTHER servers over the network. This does require it.
Quoted 2 lines
package/ipmitool/Config.in line 5
Quoted 1 line
package/ipmitool/Config.in new file +1
-0+IPMITOOL_DEPENDENCIES = opensslSo this should be handled like readline, as an optional dependency.
Ok, then I'll make an option for "lanplus interface support" in the configuration, that adds OpenSSL when selected.
Quoted 9 lines
package/ipmitool/Config.in line 11
Quoted 6 lines
package/ipmitool/Config.in new file +6
-0+ +ifeq ($(BR2_PACKAGE_READLINE),y) +IPMITOOL_DEPENDENCIES += readline +endif + +ifneq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),y)Or, better, use positive logic:
ifeq ($(BR2_PACKAGE_IPMITOOL_IPMIEVD),)
Ok
Yours sincerely,
Floris Bos