qt: make QtDeclarative depend on QtSql
PATCH 1/1 qt: make QtDeclarative depend on QtSql
As indicated by QtDeclarative.pc, QtDeclarative needs QtSql. It builds fine without it, but then you get a run-time error. So add QtSql to the QtDeclarative depends-on list.
--- package/qt/Config.in | 1 + 1 file changed, 1 insertion(+)
package/qt/Config.in +1 -0
@@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE bool "Declarative module" depends on BR2_PACKAGE_QT_SCRIPT depends on BR2_PACKAGE_QT_GUI_MODULE + depends on BR2_PACKAGE_QT_SQL_MODULE help Build the Qt Declarative Module for qml support if unsure, say n.
Signature · 1 line
1.7.9.5
PATCH 1/1 qt: make QtDeclarative depend on QtSql
Dear Danomi Manchego,
Quoted 14 lines · Danomi Manchego
As indicated by QtDeclarative.pc, QtDeclarative needs QtSql. It builds fine without it, but then you get a run-time error. So add QtSql to the QtDeclarative depends-on list.
Signed-off-by Danomi Manchego <[email protected]>--- package/qt/Config.in | 1 + 1 file changed, 1 insertion(+)package/qt/Config.in +0
-0
package/qt/Config.in config BR2_PACKAGE_QT_DECLARATIVE · line 425
Quoted 7 lines
package/qt/Config.in +1
-0@@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE bool "Declarative module" depends on BR2_PACKAGE_QT_SCRIPT depends on BR2_PACKAGE_QT_GUI_MODULE + depends on BR2_PACKAGE_QT_SQL_MODULE help Build the Qt Declarative Module for qml support if unsure, say n.
Not really related to your patch, but why do we use "depends on" instead of "select" here? How am I supposed to know that I need to enable Sql stuff to be able to build the Declarative module?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 qt: make QtDeclarative depend on QtSql
Thomas,
Quoted 12 lines · Thomas Petazzoni
Dear Danomi Manchego,
Quoted 9 lines · Danomi Manchego
As indicated by QtDeclarative.pc, QtDeclarative needs QtSql. It builds fine without it, but then you get a run-time error. So add QtSql to the QtDeclarative depends-on list.
Signed-off-by Danomi Manchego <[email protected]>--- package/qt/Config.in | 1 + 1 file changed, 1 insertion(+)
Quoted 16 lines
package/qt/Config.in config BR2_PACKAGE_QT_DECLARATIVE · line 425
Quoted 12 lines
package/qt/Config.in +1
-0@@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE bool "Declarative module" depends on BR2_PACKAGE_QT_SCRIPT depends on BR2_PACKAGE_QT_GUI_MODULE + depends on BR2_PACKAGE_QT_SQL_MODULE help Build the Qt Declarative Module for qml support if unsure, say n.Not really related to your patch, but why do we use "depends on" instead of "select" here? How am I supposed to know that I need to enable Sql stuff to be able to build the Declarative module?
I don't know why its that way (depends-on, no comment to indicated why it's hidden).
Looking back at the history, most of the additions like this were "depends on". Most of the mods that added "select" were to select non-Qt switches. The commits logs that I scanned don't comment on one versus the other, except for these two exceptions.
4059a814bb133d4dc306a366cdeba186cb7b8b89 - depends-on gstreamer used due to complicated gstreamer dependencies. d018125508c1d13f69b71702384c00c7095986a1 - qt-dbus: replace dependency on dbus by select
For this particular case, I would have used a "select" if there were not already pre-existing similar conditions. (Similar in the sense that they were also qt-config-related.)
The reason why I stumbled on to this is that I was attempting to reduce my total ubifs file size be deselecting stuff. Then my qml app failed to load due to lack of QtSql. So I figured that I'd patch, to save my future self and others from the same fate.
Danomi -
Quoted 5 lines
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
PATCH 1/1 qt: make QtDeclarative depend on QtSql
In reply to Danomi ManchegoQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Danomi" == Danomi Manchego <[email protected]> writes:
Hi,
Quoted 5 lines
As indicated by QtDeclarative.pc, QtDeclarative needs QtSql. It builds fine without it, but then you get a run-time error. So add QtSql to the QtDeclarative depends-on list.
Signed-off-by Danomi Manchego <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard