Skip to contentSkip to conversation

drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

PATCH Superseded [email protected] 5 participants 12 messages Sep 11, 2014 – May 20, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 10 ++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 16 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +8 -2
index 965eb3c..ca729e5 100644
@@ -5244,9 +5244,15 @@ retry:
 static void hsw_compute_ips_config(struct intel_crtc *crtc,
 				   struct intel_crtc_config *pipe_config)
 {
+	struct drm_device *dev = crtc->base.dev;
+	struct drm_i915_private *dev_priv = dev->dev_private;
+
 	pipe_config->ips_enabled = i915.enable_ips &&
-				   hsw_crtc_supports_ips(crtc) &&
-				   pipe_config->pipe_bpp <= 24;
+		hsw_crtc_supports_ips(crtc) &&
+		pipe_config->pipe_bpp <= 24 &&
+		(IS_HASWELL(dev) ||
+		 ilk_pipe_pixel_rate(pipe_config) <=
+		 95 * intel_ddi_get_cdclk_freq(dev_priv) / 100);
 }
 
 static int intel_crtc_compute_config(struct intel_crtc *crtc,
drivers/gpu/drm/i915/intel_drv.h +1 -0
index a505bf3..a75c123 100644
@@ -1093,6 +1093,7 @@ void intel_runtime_pm_put(struct drm_i915_private *dev_priv);
 void intel_init_runtime_pm(struct drm_i915_private *dev_priv);
 void intel_fini_runtime_pm(struct drm_i915_private *dev_priv);
 void ilk_wm_get_hw_state(struct drm_device *dev);
+uint32_t ilk_pipe_pixel_rate(const struct intel_crtc_config *pipe_config);
 
 
 /* intel_sdvo.c */
drivers/gpu/drm/i915/intel_pm.c +7 -9
index 45f71e6..b0cbfd2 100644
@@ -1836,23 +1836,21 @@ static void i845_update_wm(struct drm_crtc *unused_crtc)
 	I915_WRITE(FW_BLC, fwater_lo);
 }
 
-static uint32_t ilk_pipe_pixel_rate(struct drm_device *dev,
-				    struct drm_crtc *crtc)
+uint32_t ilk_pipe_pixel_rate(const struct intel_crtc_config *pipe_config)
 {
-	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 	uint32_t pixel_rate;
 
-	pixel_rate = intel_crtc->config.adjusted_mode.crtc_clock;
+	pixel_rate = pipe_config->adjusted_mode.crtc_clock;
 
 	/* We only use IF-ID interlacing. If we ever use PF-ID we'll need to
 	 * adjust the pixel_rate here. */
 
-	if (intel_crtc->config.pch_pfit.enabled) {
+	if (pipe_config->pch_pfit.enabled) {
 		uint64_t pipe_w, pipe_h, pfit_w, pfit_h;
-		uint32_t pfit_size = intel_crtc->config.pch_pfit.size;
+		uint32_t pfit_size = pipe_config->pch_pfit.size;
 
-		pipe_w = intel_crtc->config.pipe_src_w;
-		pipe_h = intel_crtc->config.pipe_src_h;
+		pipe_w = pipe_config->pipe_src_w;
+		pipe_h = pipe_config->pipe_src_h;
 		pfit_w = (pfit_size >> 16) & 0xFFFF;
 		pfit_h = pfit_size & 0xFFFF;
 		if (pipe_w < pfit_w)
@@ -2371,7 +2369,7 @@ static void ilk_compute_wm_parameters(struct drm_crtc *crtc,
 
 	p->active = true;
 	p->pipe_htotal = intel_crtc->config.adjusted_mode.crtc_htotal;
-	p->pixel_rate = ilk_pipe_pixel_rate(dev, crtc);
+	p->pixel_rate = ilk_pipe_pixel_rate(&intel_crtc->config);
 	p->pri.bytes_per_pixel = crtc->primary->fb->bits_per_pixel / 8;
 	p->cur.bytes_per_pixel = 4;
 	p->pri.horiz_pixels = intel_crtc->config.pipe_src_w;
Signature · 6 lines
1.8.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 27 lines · On Thu, Sep 11, 2014 at 01:54:44PM +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 10 ++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 16 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -0
index 965eb3c..ca729e5 100644
@@ -5244,9 +5244,15 @@ retry:
 static void hsw_compute_ips_config(struct intel_crtc *crtc,
 				   struct intel_crtc_config *pipe_config)
 {
+	struct drm_device *dev = crtc->base.dev;

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +7 -2
+	struct drm_i915_private *dev_priv = dev->dev_private;
+
 	pipe_config->ips_enabled = i915.enable_ips &&
-				   hsw_crtc_supports_ips(crtc) &&
-				   pipe_config->pipe_bpp <= 24;
+		hsw_crtc_supports_ips(crtc) &&
+		pipe_config->pipe_bpp <= 24 &&
+		(IS_HASWELL(dev) ||
+		 ilk_pipe_pixel_rate(pipe_config) <=
+		 95 * intel_ddi_get_cdclk_freq(dev_priv) / 100);

Could you wrap this up neatly with
pipe_config_supports_ips(dev_priv, pipe_config) ?
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw

PATCH v2 1/1 drm/i915: Don't enable IPS when pixel rate exceeds 95% of cdclk

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +19 -2
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
 	return setup_ok ? 0 : -EINVAL;
 }
 
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+				     struct intel_crtc_config *pipe_config)
+{
+	if (pipe_config->pipe_bpp > 24)
+		return false;
+
+	/* HSW can handle pixel rate up to cdclk? */
+	if (IS_HASWELL(dev_priv->dev))
+		return true;
+
+	return ilk_pipe_pixel_rate(pipe_config) <=
+		intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
+}
+
 static void hsw_compute_ips_config(struct intel_crtc *crtc,
 				   struct intel_crtc_config *pipe_config)
 {
+	struct drm_device *dev = crtc->base.dev;
+	struct drm_i915_private *dev_priv = dev->dev_private;
+
 	pipe_config->ips_enabled = i915.enable_ips &&
-				   hsw_crtc_supports_ips(crtc) &&
-				   pipe_config->pipe_bpp <= 24;
+		hsw_crtc_supports_ips(crtc) &&
+		pipe_config_supports_ips(dev_priv, pipe_config);
 }
 
 static int intel_crtc_compute_config(struct intel_crtc *crtc,
drivers/gpu/drm/i915/intel_drv.h +1 -0
index a505bf3..a75c123 100644
@@ -1093,6 +1093,7 @@ void intel_runtime_pm_put(struct drm_i915_private *dev_priv);
 void intel_init_runtime_pm(struct drm_i915_private *dev_priv);
 void intel_fini_runtime_pm(struct drm_i915_private *dev_priv);
 void ilk_wm_get_hw_state(struct drm_device *dev);
+uint32_t ilk_pipe_pixel_rate(const struct intel_crtc_config *pipe_config);
 
 
 /* intel_sdvo.c */
drivers/gpu/drm/i915/intel_pm.c +7 -9
index 45f71e6..b0cbfd2 100644
@@ -1836,23 +1836,21 @@ static void i845_update_wm(struct drm_crtc *unused_crtc)
 	I915_WRITE(FW_BLC, fwater_lo);
 }
 
-static uint32_t ilk_pipe_pixel_rate(struct drm_device *dev,
-				    struct drm_crtc *crtc)
+uint32_t ilk_pipe_pixel_rate(const struct intel_crtc_config *pipe_config)
 {
-	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 	uint32_t pixel_rate;
 
-	pixel_rate = intel_crtc->config.adjusted_mode.crtc_clock;
+	pixel_rate = pipe_config->adjusted_mode.crtc_clock;
 
 	/* We only use IF-ID interlacing. If we ever use PF-ID we'll need to
 	 * adjust the pixel_rate here. */
 
-	if (intel_crtc->config.pch_pfit.enabled) {
+	if (pipe_config->pch_pfit.enabled) {
 		uint64_t pipe_w, pipe_h, pfit_w, pfit_h;
-		uint32_t pfit_size = intel_crtc->config.pch_pfit.size;
+		uint32_t pfit_size = pipe_config->pch_pfit.size;
 
-		pipe_w = intel_crtc->config.pipe_src_w;
-		pipe_h = intel_crtc->config.pipe_src_h;
+		pipe_w = pipe_config->pipe_src_w;
+		pipe_h = pipe_config->pipe_src_h;
 		pfit_w = (pfit_size >> 16) & 0xFFFF;
 		pfit_h = pfit_size & 0xFFFF;
 		if (pipe_w < pfit_w)
@@ -2371,7 +2369,7 @@ static void ilk_compute_wm_parameters(struct drm_crtc *crtc,
 
 	p->active = true;
 	p->pipe_htotal = intel_crtc->config.adjusted_mode.crtc_htotal;
-	p->pixel_rate = ilk_pipe_pixel_rate(dev, crtc);
+	p->pixel_rate = ilk_pipe_pixel_rate(&intel_crtc->config);
 	p->pri.bytes_per_pixel = crtc->primary->fb->bits_per_pixel / 8;
 	p->cur.bytes_per_pixel = 4;
 	p->pri.horiz_pixels = intel_crtc->config.pipe_src_w;
Signature · 6 lines
1.8.5.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v2 1/1
#3 lore raw
Quoted 26 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
 	return setup_ok ? 0 : -EINVAL;

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
 }
 
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+				     struct intel_crtc_config *pipe_config)
+{
+	if (pipe_config->pipe_bpp > 24)
+		return false;
+
+	/* HSW can handle pixel rate up to cdclk? */
+	if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 4 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+		return true;
+
+	return ilk_pipe_pixel_rate(pipe_config) <=
+		intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;

Otherwise

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#4 lore raw
Quoted 29 lines · Chris Wilson
Quoted 28 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
 	return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+				     struct intel_crtc_config *pipe_config)
+{
+	if (pipe_config->pipe_bpp > 24)
+		return false;
+
+	/* HSW can handle pixel rate up to cdclk? */
+	if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

old habits...

Quoted 12 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+		return true;
+
+	return ilk_pipe_pixel_rate(pipe_config) <=
+		intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;

Otherwise

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Signature · 2 lines
Ville Syrjälä
Intel OTC
maintainer
#5 lore raw
Quoted 41 lines · Ville Syrjälä
Quoted 29 lines · Chris Wilson
Quoted 28 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
 	return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+				     struct intel_crtc_config *pipe_config)
+{
+	if (pipe_config->pipe_bpp > 24)
+		return false;
+
+	/* HSW can handle pixel rate up to cdclk? */
+	if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

BR,
Jani.

Quoted 21 lines
Quoted 13 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+		return true;
+
+	return ilk_pipe_pixel_rate(pipe_config) <=
+		intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;

Otherwise

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 42 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 39 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 26 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
 }
 
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 5 lines
Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 33 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

2014-09-17 11:05 GMT-03:00 Paulo Zanoni <[email protected]>:

Quoted 48 lines

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 47 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 29 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 28 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

And another detail: even if the register read worked, we'd have printed a bad value since the cdclock is disabled at the moment we run the function, so we'd return the FCLK frequency. So maybe we need to cache the value of the "cdclk under normal display operation" and reuse it here.

Quoted 178 lines

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 27 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw
Quoted 50 lines · Paulo Zanoni

2014-09-17 11:05 GMT-03:00 Paulo Zanoni <[email protected]>:

Quoted 48 lines

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 47 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 29 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 28 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

Quoted 5 lines

And another detail: even if the register read worked, we'd have printed a bad value since the cdclock is disabled at the moment we run the function, so we'd return the FCLK frequency. So maybe we need to cache the value of the "cdclk under normal display operation" and reuse it here.

Yeah. We already do that on VLV/CHV to some extent. We should just do it for all platforms. Although for this case what we'd need to do is precalculate the optimal cdclk during compute_config phase and use that value for these checks, and then during global_resources we actually change the cdclk to match the precomputed value.

Also if someone takes this on they could also unify the ddi cdclk code to look more like the other platforms, and perhaps even implement support for changing the cdclk frequency on HSW/BDW ;)

Quoted 184 lines
Quoted 179 lines

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 27 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Signature · 1 line
Paulo Zanoni
Signature · 2 lines
Ville Syrjälä
Intel OTC
maintainer
#9 lore raw
Quoted 63 lines · Ville Syrjälä
Quoted 50 lines · Paulo Zanoni

2014-09-17 11:05 GMT-03:00 Paulo Zanoni <[email protected]>:

Quoted 48 lines

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 47 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 29 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 28 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

Quoted 5 lines

And another detail: even if the register read worked, we'd have printed a bad value since the cdclock is disabled at the moment we run the function, so we'd return the FCLK frequency. So maybe we need to cache the value of the "cdclk under normal display operation" and reuse it here.

Yeah. We already do that on VLV/CHV to some extent. We should just do it for all platforms. Although for this case what we'd need to do is precalculate the optimal cdclk during compute_config phase and use that value for these checks, and then during global_resources we actually change the cdclk to match the precomputed value.

Quoted 3 lines

Also if someone takes this on they could also unify the ddi cdclk code to look more like the other platforms, and perhaps even implement support for changing the cdclk frequency on HSW/BDW ;)

I've dropped the commit from drm-intel-fixes and reopened the bug. We need someone(tm) to look at this now.

BR,
Jani.

Quoted 189 lines
Quoted 185 lines
Quoted 180 lines

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 27 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Signature · 1 line
Paulo Zanoni
Signature · 2 lines
Ville Syrjälä
Intel OTC
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by
#10 lore raw

I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied....

So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug would still be open...

Anyway,

Quoted 272 lines · Jani Nikula
Quoted 63 lines · Ville Syrjälä
Quoted 50 lines · Paulo Zanoni

2014-09-17 11:05 GMT-03:00 Paulo Zanoni <[email protected]>:

Quoted 48 lines

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 47 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 29 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 28 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

Quoted 5 lines

And another detail: even if the register read worked, we'd have printed a bad value since the cdclock is disabled at the moment we run the function, so we'd return the FCLK frequency. So maybe we need to cache the value of the "cdclk under normal display operation" and reuse it here.

Yeah. We already do that on VLV/CHV to some extent. We should just do it for all platforms. Although for this case what we'd need to do is precalculate the optimal cdclk during compute_config phase and use that value for these checks, and then during global_resources we actually change the cdclk to match the precomputed value.

Quoted 3 lines

Also if someone takes this on they could also unify the ddi cdclk code to look more like the other platforms, and perhaps even implement support for changing the cdclk frequency on HSW/BDW ;)

I've dropped the commit from drm-intel-fixes and reopened the bug. We need someone(tm) to look at this now.

BR,
Jani.

Quoted 183 lines
Quoted 183 lines
Quoted 180 lines

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 27 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Quoted 6 lines
Quoted 2 lines

--
Paulo Zanoni

--
Ville Syrjälä
Intel OTC

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw

2015-05-20 17:40 GMT-03:00 Rodrigo Vivi <[email protected]>:

Quoted 8 lines

I'm convinced Unclaimed regs Paulo saw came from somewhere else since I just got it with pm_rpm rte with no patch applied....

So I'd suggest to merge this patch... Although it also doesn't fix the flicker I see here so the bug would still be open...

Anyway,

Nope. The unclaimed register error you see is a recent regression. It didn't happen back in 2014 when I tested the IPS patch. When I report regressions like this to the mailing list I always test the revert, so at that time, with that state on drm-intel-nightly, that patch was certainly introducing the regression. Maybe something changed now? Did you retest?

Also, which frequency value are you currently reading? The FCLK one? If it's the FCLK frequency, it's not really what you want.

Quoted 281 lines
Quoted 266 lines · Jani Nikula
Quoted 63 lines · Ville Syrjälä
Quoted 50 lines · Paulo Zanoni

2014-09-17 11:05 GMT-03:00 Paulo Zanoni <[email protected]>:

Quoted 48 lines

2014-09-15 4:22 GMT-03:00 Jani Nikula <[email protected]>:

Quoted 47 lines · Ville Syrjälä
Quoted 41 lines · Chris Wilson
Quoted 29 lines · On Fri, Sep 12, 2014 at 05:01:57PM +0300, [email protected] wrote:
Quoted 28 lines

From: Ville Syrjälä <[email protected]>

Bspec says we shouldn't enable IPS on BDW when the pipe pixel rate exceeds 95% of the core display clock. Apparently this can cause underruns.

There's no similar restriction listed for HSW, so leave that one alone for now.

v2: Add pipe_config_supports_ips() (Chris)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83497

---
 drivers/gpu/drm/i915/intel_display.c | 21 +++++++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h     |  1 +
 drivers/gpu/drm/i915/intel_pm.c      | 16 +++++++---------
 3 files changed, 27 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 965eb3c..7809177 100644
@@ -5241,12 +5241,29 @@ retry:
   return setup_ok ? 0 : -EINVAL;
 }
 
Quoted 10 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5251

Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +8 -0
+static bool pipe_config_supports_ips(struct drm_i915_private *dev_priv,
+                               struct intel_crtc_config *pipe_config)
+{
+  if (pipe_config->pipe_bpp > 24)
+          return false;
+
+  /* HSW can handle pixel rate up to cdclk? */
+  if (IS_HASWELL(dev_priv->dev))

This only needs IS_HASWELL(dev_priv)

Quoted 1 line

old habits...

Thanks to your old habits I didn't have to make any changes when pushing this to drm-intel-fixes which is still old habit land. Thanks for the patch and review.

Quoted 5 lines

And another detail: even if the register read worked, we'd have printed a bad value since the cdclock is disabled at the moment we run the function, so we'd return the FCLK frequency. So maybe we need to cache the value of the "cdclk under normal display operation" and reuse it here.

Yeah. We already do that on VLV/CHV to some extent. We should just do it for all platforms. Although for this case what we'd need to do is precalculate the optimal cdclk during compute_config phase and use that value for these checks, and then during global_resources we actually change the cdclk to match the precomputed value.

Quoted 3 lines

Also if someone takes this on they could also unify the ddi cdclk code to look more like the other platforms, and perhaps even implement support for changing the cdclk frequency on HSW/BDW ;)

I've dropped the commit from drm-intel-fixes and reopened the bug. We need someone(tm) to look at this now.

BR,
Jani.

Quoted 183 lines
Quoted 183 lines
Quoted 180 lines

This patches causes a regression on igt/pm_rpm/rte:

[   44.871662] [drm:intel_dp_compute_config] DP link bw required
650358 available 1728000
[   44.871666] ------------[ cut here ]------------
[   44.871691] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:47
assert_device_not_suspended.isra.8+0x43/0x50 [i915]()
[   44.871692] Device suspended
[   44.871694] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.871726] CPU: 0 PID: 1745 Comm: pm_rpm Not tainted
3.17.0-rc5.1409171019pz+ #1120
[   44.871728] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.871730]  0000000000000009 ffff8800aa763a90 ffffffff816ec803
ffff8800aa763ad8
[   44.871735]  ffff8800aa763ac8 ffffffff8107a0c8 ffff88023ec20068
0000000000130040
[   44.871739]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b28
[   44.871743] Call Trace:
[   44.871749]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.871754]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.871758]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.871783]  [<ffffffffa015a1f4>] ?
intel_dp_compute_config+0x274/0x600 [i915]
[   44.871803]  [<ffffffffa0122cf3>]
assert_device_not_suspended.isra.8+0x43/0x50 [i915]
[   44.871822]  [<ffffffffa0125a20>] gen6_read32+0x30/0x150 [i915]
[   44.871844]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.871865]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.871886]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.871906]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.871923]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.871938]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.871948]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.871954]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.871957]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.871962]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.871966]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.871969]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.871972] ---[ end trace 91bf8920a2c6b824 ]---
[   44.871975] ------------[ cut here ]------------
[   44.871994] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.871996] Unclaimed register detected before reading register 0x130040
[   44.871997] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872025] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872026] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872028]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872032]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872035]  ffff88023f12b3d8 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872039] Call Trace:
[   44.872042]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872046]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872049]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872068]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872087]  [<ffffffffa0125a41>] gen6_read32+0x51/0x150 [i915]
[   44.872109]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872129]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872149]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872168]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872182]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872196]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872205]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872210]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872213]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872218]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872221]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872224]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872226] ---[ end trace 91bf8920a2c6b825 ]---
[   44.872228] ------------[ cut here ]------------
[   44.872246] WARNING: CPU: 0 PID: 1745 at
drivers/gpu/drm/i915/intel_uncore.c:528
hsw_unclaimed_reg_debug+0x6d/0x80 [i915]()
[   44.872248] Unclaimed register detected after reading register 0x130040
[   44.872249] Modules linked in: hid_multitouch hid_sensor_hub

snd_hda_codec_hdmi intel_rapl x86_pkg_temp_thermal intel_powerclamp efivars snd_hda_intel btusb snd_hda_controller snd_hda_codec snd_hwdep iwlmvm snd_pcm_oss snd_mixer_oss iwlwifi mei_me mei snd_pcm snd_timer int3403_thermal i2c_designware_platform i2c_designware_core acpi_pad fuse nls_utf8 nls_cp437 vfat fat i915 sdhci_pci drm_kms_helper e1000e drm sdhci_acpi sdhci

[   44.872276] CPU: 0 PID: 1745 Comm: pm_rpm Tainted: G        W
3.17.0-rc5.1409171019pz+ #1120
[   44.872277] Hardware name: Intel Corporation Broadwell Client
platform/Wilson Beach SDS, BIOS BDW-E2R1.86C.0072.R03.1405072127
05/07/2014
[   44.872279]  0000000000000009 ffff8800aa763a88 ffffffff816ec803
ffff8800aa763ad0
[   44.872282]  ffff8800aa763ac0 ffffffff8107a0c8 ffff88023ec20000
0000000000130040
[   44.872286]  00000000ffffffff 0000000000130040 ffff88023ec20000
ffff8800aa763b20
[   44.872289] Call Trace:
[   44.872293]  [<ffffffff816ec803>] dump_stack+0x4d/0x66
[   44.872296]  [<ffffffff8107a0c8>] warn_slowpath_common+0x78/0xa0
[   44.872299]  [<ffffffff8107a137>] warn_slowpath_fmt+0x47/0x50
[   44.872318]  [<ffffffffa0122bbd>] hsw_unclaimed_reg_debug+0x6d/0x80 [i915]
[   44.872335]  [<ffffffffa0125a7e>] gen6_read32+0x8e/0x150 [i915]
[   44.872356]  [<ffffffffa0154636>] intel_ddi_get_cdclk_freq+0xd6/0x140 [i915]
[   44.872376]  [<ffffffffa0139a92>] __intel_set_mode+0x1672/0x1750 [i915]
[   44.872396]  [<ffffffffa01418e1>] intel_set_mode+0x11/0x30 [i915]
[   44.872416]  [<ffffffffa01429ed>] intel_crtc_set_config+0xa9d/0xeb0 [i915]
[   44.872429]  [<ffffffffa0026283>]
drm_mode_set_config_internal+0x63/0x100 [drm]
[   44.872443]  [<ffffffffa002a7e3>] drm_mode_setcrtc+0x283/0x580 [drm]
[   44.872453]  [<ffffffffa001c81f>] drm_ioctl+0x1df/0x6a0 [drm]
[   44.872458]  [<ffffffff811e07b0>] do_vfs_ioctl+0x2e0/0x4e0
[   44.872461]  [<ffffffff816f6af7>] ? sysret_check+0x1b/0x56
[   44.872465]  [<ffffffff810bfb0d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   44.872468]  [<ffffffff811e0a31>] SyS_ioctl+0x81/0xa0
[   44.872471]  [<ffffffff816f6ad2>] system_call_fastpath+0x16/0x1b
[   44.872473] ---[ end trace 91bf8920a2c6b826 ]---
[   44.872512] [drm:intel_modeset_pipe_config] plane bpp: 24, pipe

bpp: 18, dithering: 1

Quoted 27 lines

BR,
Jani.

Quoted 14 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_display.c retry: · line 5255

Quoted 6 lines
drivers/gpu/drm/i915/intel_display.c +4 -0
+          return true;
+
+  return ilk_pipe_pixel_rate(pipe_config) <=
+          intel_ddi_get_cdclk_freq(dev_priv) * 95 / 100;
Quoted 6 lines

Otherwise

-Chris

--
Chris Wilson, Intel Open Source Technology Centre

Quoted 7 lines

--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Paulo Zanoni

Quoted 6 lines
Quoted 2 lines

--
Paulo Zanoni

--
Ville Syrjälä
Intel OTC

Quoted 6 lines

--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx