utils: nft_fprintf: prevent an empty buffer from being printed
PATCH 1/1 utils: nft_fprintf: prevent an empty buffer from being printed
If the snprintf_cb() printed 0 characters, no \0 exists in the buffer. Also, in that case fprintf() is meant to print nothing, so we can just exit.
This patch addresses new cases of textual output by libnftnl with trash.
Signed-off-by Arturo Borrero Gonzalez <[email protected]>
--- src/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
src/utils.c +2 -2
@@ -190,7 +190,7 @@ int nft_fprintf(FILE *fp, void *obj, uint32_t type, uint32_t flags,int ret; ret =snprintf_cb (buf, bufsiz, obj, type, flags); -if (ret <0 ) +if (ret <=0 ) goto out;if (ret >=NFT_SNPRINTF_BUFSIZ ) {
@@ -201,7 +201,7 @@ int nft_fprintf(FILE *fp, void *obj, uint32_t type, uint32_t flags,return -1 ; ret =snprintf_cb (buf, bufsiz, obj, type, flags); -if (ret <0 ) +if (ret <=0 ) goto out; }
Pablo Neira Ayuso
maintainerQuoted 4 lines · Arturo Borrero Gonzalez
If the
snprintf_cb()printed 0 characters, no \0 exists in the buffer. Also, in that casefprintf()is meant to print nothing, so we can just exit.This patch addresses new cases of textual output by libnftnl with trash.
Also applied, thanks.