Skip to contentSkip to conversation

Fix some build issues

Buildroot New Jérôme Pouiller 3 participants 28 messages Sep 12, 2014 – Sep 14, 2014

lore
Share & tools
lore
#1 lore raw

PATCH 1/12 xdriver_xf86-video-vmware: only avaiblable on x86

... since BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA is only available on x86.

Fix warnings like:
warning: (BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE) selects BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA which has unmet direct dependencies (BR2_PACKAGE_MESA3D && (BR2_i386 || BR2_x86_64))

---
 package/x11r7/xdriver_xf86-video-vmware/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/x11r7/xdriver_xf86-video-vmware/Config.in +1 -0
index 2e6b24d..a3382d7 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE
 	bool "xf86-video-vmware"
 	depends on BR2_PACKAGE_MESA3D
+	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
 	select BR2_PACKAGE_XPROTO_FONTSPROTO
 	select BR2_PACKAGE_XPROTO_RANDRPROTO
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/12 xdriver_xf86-video-vmware: only avaiblable on x86

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

... since BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA is only available on x86. Fix warnings like:
warning: (BR2_PACKAGE_XDRIVER_XF86_VIDEO_VMWARE) selects BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA which has unmet direct dependencies (BR2_PACKAGE_MESA3D && (BR2_i386 || BR2_x86_64))

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/12 xapp_xkbevd: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/a9ec03bd:

xkbevd.o: In function `_main':
xkbevd.c:(.text+0x3ca): undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xkbevd/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/x11r7/xapp_xkbevd/Config.in +1 -0
index cf31565..0cbb9e4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XKBEVD
 	bool "xkbevd"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXKBFILE
 	help
 	  XKB event daemon
Signature · 1 line
2.1.0
#5 lore raw

PATCH 3/12 xapp_xinit: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/8b5af679:

xinit.o: In function `_main':
xinit.c:(.text+0x65e): undefined reference to _fork' xinit.c:(.text+0x7d4): undefined reference to _fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xinit/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/x11r7/xapp_xinit/Config.in +2 -1
index aede5d9..6537d89 100644
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XAPP_XINIT
 	bool "xinit"
+	depends on BR2_USE_MMU # fork()
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
-	# Runtime dependency; mcookie is also in util-linux
+	#Runtime dependency; mcookie is also in util-linux
 	select BR2_PACKAGE_MCOOKIE if !BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_XAPP_XAUTH
 	select BR2_PACKAGE_XLIB_LIBX11
Signature · 1 line
2.1.0
#6 lore raw

PATCH 3/12 xapp_xinit: depends on MMU

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/8b5af679:
xinit.o: In function `_main':
xinit.c:(.text+0x65e): undefined reference to _fork' xinit.c:(.text+0x7d4): undefined reference to _fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xinit/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/x11r7/xapp_xinit/Config.in +0 -0
index aede5d9..6537d89 100644

package/x11r7/xapp_xinit/Config.in line 6

Quoted 7 lines
package/x11r7/xapp_xinit/Config.in +2 -1
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_XAPP_XINIT
 	bool "xinit"
+	depends on BR2_USE_MMU # fork()
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
-	# Runtime dependency; mcookie is also in util-linux
+	#Runtime dependency; mcookie is also in util-linux

I'm not sure why you want to change this. Committed without this line, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 3/12 xapp_xinit: depends on MMU

Quoted 1 line · On Friday 12 September 2014 23:19:06 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

[...]

Quoted 8 lines

package/x11r7/xapp_xinit/Config.in line 6

Quoted 5 lines
package/x11r7/xapp_xinit/Config.in +1 -1
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
 
-	# Runtime dependency; mcookie is also in util-linux
+	#Runtime dependency; mcookie is also in util-linux

I'm not sure why you want to change this. Committed without this line, thanks.

I don't known either why... It is a mishandling.

Signature · 3 lines
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr
#8 lore raw

PATCH 4/12 xapp_xsm: depends on MMU

In reply to Jérôme Pouiller

remote.o: In function `_remote_start':
remote.c:(.text+0x74): undefined reference to _fork' restart.o: In function _Clone':
restart.c:(.text+0x5a8): undefined reference to _fork' restart.o: In function _Restart':
restart.c:(.text+0xa44): undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xsm/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/x11r7/xapp_xsm/Config.in +1 -0
index d06dc6c..88f20cf 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XSM
 	bool "xsm"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXAW
 	help
 	  X Session Manager
Signature · 1 line
2.1.0
#9 lore raw

PATCH 4/12 xapp_xsm: depends on MMU

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes: http://sysmic.org/~jezz/results/455f2788:
remote.o: In function `_remote_start':
remote.c:(.text+0x74): undefined reference to _fork' restart.o: In function _Clone':
restart.c:(.text+0x5a8): undefined reference to _fork' restart.o: In function _Restart':
restart.c:(.text+0xa44): undefined reference to `_fork'
collect2: ld returned 1 exit status

Quoted 1 line

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 5/12 xapp_xmh: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/1a0bc183:

command.o: In function `__DoCommandToFileOrPipe':
command.c:(.text+0x35e): undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xmh/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/x11r7/xapp_xmh/Config.in +1 -0
index 1ef65c7..4e86d0f 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XMH
 	bool "xmh"
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBXAW
 	select BR2_PACKAGE_XDATA_XBITMAPS
 	help
Signature · 1 line
2.1.0
#11 lore raw

PATCH 5/12 xapp_xmh: depends on MMU

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/1a0bc183:
command.o: In function `__DoCommandToFileOrPipe':
command.c:(.text+0x35e): undefined reference to `_fork'
collect2: ld returned 1 exit status

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#12 lore raw

PATCH 6/12 xapp_xdm: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/e891eb7e:

dm.o: In function `_StartDisplay':
dm.c:(.text+0xd6e): undefined reference to _fork' server.o: In function _StartServerOnce':
server.c:(.text+0x266): undefined reference to _fork' session.o: In function _runAndWait':
session.c:(.text+0x67a): undefined reference to _fork' session.o: In function _ManageSession':
session.c:(.text+0xa2a): undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/x11r7/xapp_xdm/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/x11r7/xapp_xdm/Config.in +1 -0
index 477cd77..6982970 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XAPP_XDM
 	bool "xdm"
+	depends on BR2_USE_MMU # fork()
 	# Runtime dependency: can't start an X server unless there is one
 	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
 	select BR2_PACKAGE_XAPP_SESSREG
Signature · 1 line
2.1.0
#13 lore raw

PATCH 6/12 xapp_xdm: depends on MMU

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/e891eb7e:
dm.o: In function `_StartDisplay':
dm.c:(.text+0xd6e): undefined reference to _fork' server.o: In function _StartServerOnce':
server.c:(.text+0x266): undefined reference to _fork' session.o: In function _runAndWait':
session.c:(.text+0x67a): undefined reference to _fork' session.o: In function _ManageSession':
session.c:(.text+0xa2a): undefined reference to `_fork'
collect2: ld returned 1 exit status

Quoted 1 line

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#14 lore raw

PATCH 7/12 xterm: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/53a729c3:

button.o: In function `_executeCommand':
./button.c:(.text+0x21be): undefined reference to _fork' main.o: In function _get_pty':
./main.c:(.text+0xab0): undefined reference to _getpt' main.o: In function _spawnXTerm':
./main.c:(.text+0x1030): undefined reference to _fork' misc.o: In function _creat_as':
./misc.c:(.text+0x3a56): undefined reference to _fork' print.o: In function _charToPrinter':
./print.c:(.text+0x1ee): undefined reference to `_fork'

---
 package/xterm/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/xterm/Config.in +1 -0
index 33adf25..e17d2c6 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_XTERM
 	select BR2_PACKAGE_NCURSES
 	select BR2_PACKAGE_XLIB_LIBXAW
 	depends on BR2_PACKAGE_XORG7
+	depends on BR2_USE_MMU # fork()
 	help
 	  xterm terminal emulator
 
Signature · 1 line
2.1.0
#15 lore raw

PATCH 7/12 xterm: depends on MMU

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/53a729c3:
button.o: In function `_executeCommand':
./button.c:(.text+0x21be): undefined reference to _fork' main.o: In function _get_pty':
./main.c:(.text+0xab0): undefined reference to _getpt' main.o: In function _spawnXTerm':
./main.c:(.text+0x1030): undefined reference to _fork' misc.o: In function _creat_as':
./misc.c:(.text+0x3a56): undefined reference to _fork' print.o: In function _charToPrinter':
./print.c:(.text+0x1ee): undefined reference to `_fork'

Quoted 1 line

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#16 lore raw

PATCH 8/12 xfsprogs: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/17f32103:

xfs_fsr.o: In function `fsrallfs':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork'
collect2: ld returned 1 exit status

madvise.o: In function `madvise_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to _madvise' mincore.o: In function mincore_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore'
collect2: ld returned 1 exit status

---
 package/xfsprogs/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/xfsprogs/Config.in +3 -2
index 3a31dd2..bb7634c 100644
@@ -2,11 +2,12 @@
 comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled"
 	depends on BR2_PACKAGE_XFSPROGS
 
-comment "xfsprogs needs a toolchain w/ largefile, wchar"
-	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
+comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU"
+	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU)
 
 config BR2_PACKAGE_XFSPROGS
 	bool "xfsprogs"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_WCHAR # util-linux
 	select BR2_PACKAGE_UTIL_LINUX
Signature · 1 line
2.1.0
#17 lore raw

PATCH 8/12 xfsprogs: depends on MMU

Quoted 23 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/17f32103:
xfs_fsr.o: In function `fsrallfs':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork'
collect2: ld returned 1 exit status

madvise.o: In function `madvise_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to _madvise' mincore.o: In function mincore_f':
/home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore'
collect2: ld returned 1 exit status

---
 package/xfsprogs/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/xfsprogs/Config.in +0 -0
index 3a31dd2..bb7634c 100644

package/xfsprogs/Config.in line 6

Quoted 7 lines
package/xfsprogs/Config.in +2 -2
@@ -2,11 +2,12 @@
 comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled"
 	depends on BR2_PACKAGE_XFSPROGS
 
-comment "xfsprogs needs a toolchain w/ largefile, wchar"
-	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
+comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU"
+	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU)

The user typically cannot do anything about the MMU dependency, so we don't add it to the comment line (but do make the comment depend on MMU so it's only shown for people who can use it).

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#18 lore raw

PATCH 9/12 ltp-testsuite: depends on MMU

In reply to Jérôme Pouiller

Fixes http://sysmic.org/~jezz/results/dfc51d2b:

.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_child] Error 1
make[3]: *** Waiting for unfinished jobs....
/tmp/ccF9CQQa.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent] Error 1
/tmp/ccwCGpYd.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent_exits] Error 1
/tmp/cc8TiB6d.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_process_state.c:43: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_process_state] Error 1
/tmp/ccrf7Gjb.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/ltp-testsuite/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/ltp-testsuite/Config.in +3 -2
index 0e71677..76fa1a1 100644
@@ -4,6 +4,7 @@ comment "ltp-testsuite needs specific uClibc options, see help"
 
 config BR2_PACKAGE_LTP_TESTSUITE
 	bool "ltp-testsuite"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_LARGEFILE
@@ -22,7 +23,7 @@ config BR2_PACKAGE_LTP_TESTSUITE
 
 	  http://ltp.sourceforge.net/
 
-comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads"
+comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads, MMU"
 	depends on !BR2_nios2
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6 || \
-		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC || !BR2_USE_MMU
Signature · 1 line
2.1.0
#19 lore raw

PATCH 9/12 ltp-testsuite: depends on MMU

Quoted 41 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

Fixes http://sysmic.org/~jezz/results/dfc51d2b:
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_child] Error 1
make[3]: *** Waiting for unfinished jobs....
/tmp/ccF9CQQa.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent] Error 1
/tmp/ccwCGpYd.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_parent_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_checkpoint_parent_exits] Error 1
/tmp/cc8TiB6d.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_process_state.c:43: undefined reference to `_fork'
collect2: ld returned 1 exit status
make[3]: *** [tst_process_state] Error 1
/tmp/ccrf7Gjb.o: In function `main':
.../ltp-testsuite-20140115/lib/tests/tst_checkpoint_child_exits.c:40: undefined reference to `_fork'
collect2: ld returned 1 exit status

---
 package/ltp-testsuite/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/ltp-testsuite/Config.in +1 -0
index 0e71677..76fa1a1 100644
@@ -4,6 +4,7 @@ comment "ltp-testsuite needs specific uClibc options, see help"
 
 config BR2_PACKAGE_LTP_TESTSUITE
 	bool "ltp-testsuite"
+	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_LARGEFILE

package/ltp-testsuite/Config.in config BR2_PACKAGE_LTP_TESTSUITE · line 29

Quoted 9 lines
package/ltp-testsuite/Config.in +2 -2
@@ -22,7 +23,7 @@ config BR2_PACKAGE_LTP_TESTSUITE
 
 	  http://ltp.sourceforge.net/
 
-comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads"
+comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads, MMU"
 	depends on !BR2_nios2
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6 || \
-		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+		!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC || !BR2_USE_MMU

Same comment as for xfsprogs. Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#20 lore raw

PATCH 10/12 sdl: remove dga support in no MMU

In reply to Jérôme Pouiller

DGA support use fork. This prevent executables to link with libSDL.so.

Fixes:
http://sysmic.org/~jezz/results/5e50c243 (package sdl_mixer)
http://sysmic.org/~jezz/results/734afef8 (package sdl_net)
http://sysmic.org/~jezz/results/e2310eb9 (package sdl_image)
http://sysmic.org/~jezz/results/e2cdcc9a (package sdl_sound)

---
 package/sdl/sdl.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/sdl/sdl.mk +4 -0
index 8d0e5bd..77fbdd9 100644
@@ -53,6 +53,10 @@ else
 SDL_CONF_OPT += --enable-video-x11=no
 endif
 
+ifneq ($(BR2_USE_MMU),y)
+SDL_CONF_OPT += --enable-dga=no
+endif
+
 ifeq ($(BR2_PACKAGE_TSLIB),y)
 SDL_DEPENDENCIES += tslib
 endif
Signature · 1 line
2.1.0
#21 lore raw

PATCH 10/12 sdl: remove dga support in no MMU

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

DGA support use fork. This prevent executables to link with libSDL.so. Fixes:
http://sysmic.org/~jezz/results/5e50c243 (package sdl_mixer)
http://sysmic.org/~jezz/results/734afef8 (package sdl_net)
http://sysmic.org/~jezz/results/e2310eb9 (package sdl_image)
http://sysmic.org/~jezz/results/e2cdcc9a (package sdl_sound)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#22 lore raw

PATCH 11/12 directfb: allow SVG support

In reply to Jérôme Pouiller

DirectFB SVG support rely on Cairo and Cairo depends on DirectFB.

Since Cairo DirectFB backend is marked as experimental, this patch choose to disable this backend when DirectFB SVG support is enable.

In add, this patch may solve some tricky situations between DirectFB and Cairo (see http://sysmic.org/~jezz/results/c2f11fc0) and improve build reproducibility.

---
 package/cairo/cairo.mk       | 5 ++++-
 package/directfb/Config.in   | 5 +++++
 package/directfb/directfb.mk | 7 +++++++
 3 files changed, 16 insertions(+), 1 deletion(-)
package/cairo/cairo.mk +4 -1
index a4c71b6..bcc0c26 100644
@@ -48,7 +48,10 @@ CAIRO_CONF_OPT = \
 
 CAIRO_DEPENDENCIES = host-pkgconf fontconfig pixman
 
-ifeq ($(BR2_PACKAGE_DIRECTFB),y)
+# DirectFB svg support rely on Cairo and Cairo DirectFB support depends on
+# DirectFB. Break circular dependency by disabling DirectFB support in Cairo
+# (which is experimental)
+ifeq ($(BR2_PACKAGE_DIRECTFB)x$(BR2_PACKAGE_DIRECTFB_SVG),yx)
 	CAIRO_CONF_OPT += --enable-directfb
 	CAIRO_DEPENDENCIES += directfb
 else
package/directfb/Config.in +5 -0
index e3c93a1..dc01228 100644
@@ -125,6 +125,11 @@ config BR2_PACKAGE_DIRECTFB_PNG
 	default y
 	select BR2_PACKAGE_LIBPNG
 
+config BR2_PACKAGE_DIRECTFB_SVG
+	bool "enable SVG support"
+	default y
+	select BR2_PACKAGE_CAIRO
+
 config BR2_PACKAGE_DIRECTFB_DITHER_RGB16
 	bool "enable advanced dithering of RGB16 surfaces"
 	help
package/directfb/directfb.mk +7 -0
index 3ae7f3e..dd2ca99 100644
@@ -116,6 +116,13 @@ else
 DIRECTFB_CONF_OPT += --disable-jpeg
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_SVG),y)
+DIRECTFB_CONF_OPT += --enable-svg
+DIRECTFB_DEPENDENCIES += cairo
+else
+DIRECTFB_CONF_OPT += --disable-svg
+endif
+
 ifeq ($(BR2_PACKAGE_DIRECTFB_IMLIB2),y)
 DIRECTFB_CONF_OPT += --enable-imlib2
 DIRECTFB_DEPENDENCIES += imlib2
Signature · 1 line
2.1.0
#23 lore raw

PATCH 11/12 directfb: allow SVG support

Quoted 37 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

DirectFB SVG support rely on Cairo and Cairo depends on DirectFB. Since Cairo DirectFB backend is marked as experimental, this patch choose to disable this backend when DirectFB SVG support is enable.

In add, this patch may solve some tricky situations between DirectFB and Cairo (see http://sysmic.org/~jezz/results/c2f11fc0) and improve build reproducibility.

---
 package/cairo/cairo.mk       | 5 ++++-
 package/directfb/Config.in   | 5 +++++
 package/directfb/directfb.mk | 7 +++++++
 3 files changed, 16 insertions(+), 1 deletion(-)
package/cairo/cairo.mk +4 -1
index a4c71b6..bcc0c26 100644
@@ -48,7 +48,10 @@ CAIRO_CONF_OPT = \
 
 CAIRO_DEPENDENCIES = host-pkgconf fontconfig pixman
 
-ifeq ($(BR2_PACKAGE_DIRECTFB),y)
+# DirectFB svg support rely on Cairo and Cairo DirectFB support depends on
+# DirectFB. Break circular dependency by disabling DirectFB support in Cairo
+# (which is experimental)
+ifeq ($(BR2_PACKAGE_DIRECTFB)x$(BR2_PACKAGE_DIRECTFB_SVG),yx)
 	CAIRO_CONF_OPT += --enable-directfb
 	CAIRO_DEPENDENCIES += directfb
 else
package/directfb/Config.in +0 -0
index e3c93a1..dc01228 100644

package/directfb/Config.in config BR2_PACKAGE_DIRECTFB_PNG · line 131

Quoted 7 lines
package/directfb/Config.in +4 -0
@@ -125,6 +125,11 @@ config BR2_PACKAGE_DIRECTFB_PNG
 	default y
 	select BR2_PACKAGE_LIBPNG
 
+config BR2_PACKAGE_DIRECTFB_SVG
+	bool "enable SVG support"
+	default y
+	select BR2_PACKAGE_CAIRO

cairo depends on BR2_ARCH_HAS_ATOMICS, so this should also do so.

I suspect this also needs the SVG backend of cairo. From config.log:

configure:19926: checking for libsvg-cairo >= 0.1.6 configure:19936: result: not found
configure:19939: WARNING:
*** SVG-Cairo at least 0.1.6 not found -- SVG image provider will not be built.

So it actually needs libsvg-cairo (which pulls in cairo and the svg backend of cairo).

It also needs some help to find the cairo includes:

make[5]: Entering directory '/home/peko/source/buildroot/output/build/directfb-1.6.3/interfaces/IDirectFBImageProvider'

  CC       idirectfbimageprovider_dfiff.lo
  CC       idirectfbimageprovider_bmp.lo
  CC       idirectfbimageprovider_pnm.lo
  CC       idirectfbimageprovider_svg.lo
  CC       idirectfbimageprovider_mpeg2.lo

idirectfbimageprovider_svg.c:46:19: fatal error: cairo.h: No such file or directory compilation terminated.
Makefile:817: recipe for target 'idirectfbimageprovider_svg.lo' failed make[5]: *** [idirectfbimageprovider_svg.lo] Error 1
make[5]: *** Waiting for unfinished jobs....

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#24 lore raw

PATCH 12/12 libffi and python: need threads support

In reply to Jérôme Pouiller

libffi depends on pthreads.

Python depends on libffi (it can provide a builtin libffi, but also depends on pthreads). Thus this patch also disable Python support if toolchain is compiled w/o treads support.

Fixes http://sysmic.org/~jezz/results/204099dd:

../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

---
 package/libffi/Config.in | 4 ++++
 package/python/Config.in | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
package/libffi/Config.in +4 -0
index 7211f8f..6edf570 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This
@@ -7,3 +8,6 @@ config BR2_PACKAGE_LIBFFI
 	  interface description at run-time.
 
 	  http://sourceware.org/libffi/
+
+comment "libffi needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/python/Config.in +3 -1
index a0c78c6..85438a4 100644
@@ -3,15 +3,17 @@ config BR2_PACKAGE_PYTHON
 	depends on BR2_USE_WCHAR
 	# uses fork()
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libffi
 	select BR2_PACKAGE_LIBFFI
 	help
 	  The python language interpreter.
 
 	  http://www.python.org/
 
-comment "python needs a toolchain w/ wchar"
+comment "python needs a toolchain w/ wchar and threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 if BR2_PACKAGE_PYTHON
 
Signature · 1 line
2.1.0
#25 lore raw

PATCH 12/12 libffi and python: need threads support

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"J?r?me" == J?r?me Pouiller <[email protected]> writes:

libffi depends on pthreads.
Python depends on libffi (it can provide a builtin libffi, but also depends on pthreads). Thus this patch also disable Python support if toolchain is compiled w/o treads support.

Quoted 8 lines

Fixes http://sysmic.org/~jezz/results/204099dd:

../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

---
 package/libffi/Config.in | 4 ++++
 package/python/Config.in | 4 +++-

python is not the only user of libffi. From a quick look, they all depends on threads except for python3, so I've made the same change to python3.

Quoted 30 lines
 2 files changed, 7 insertions(+), 1 deletion(-)
package/libffi/Config.in +4 -0
index 7211f8f..6edf570 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This
@@ -7,3 +8,6 @@ config BR2_PACKAGE_LIBFFI
 	  interface description at run-time.
 
 	  http://sourceware.org/libffi/
+
+comment "libffi needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/python/Config.in +1 -0
index a0c78c6..85438a4 100644
@@ -3,15 +3,17 @@ config BR2_PACKAGE_PYTHON
 	depends on BR2_USE_WCHAR
 	# uses fork()
 	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libffi
 	select BR2_PACKAGE_LIBFFI

package/python/Config.in config BR2_PACKAGE_PYTHON · line 16

Quoted 10 lines
package/python/Config.in +2 -1
 	help
 	  The python language interpreter.
 
 	  http://www.python.org/
 
-comment "python needs a toolchain w/ wchar"
+comment "python needs a toolchain w/ wchar and threads"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR
+	depends on !BR2_TOOLCHAIN_HAS_THREADS

That's wrong. Seperate 'depends on' gets ANDed together, E.G. they all have to be true, whereas we want to display the line whenever mmu and either !wchar OR !threads, so it should be

depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS.

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#26 lore raw

PATCH 12/12 libffi and python: need threads support

In reply to Jérôme Pouiller

Dear J?r?me Pouiller,

Quoted 9 lines · J?r?me Pouiller

libffi depends on pthreads.

Python depends on libffi (it can provide a builtin libffi, but also depends on pthreads). Thus this patch also disable Python support if toolchain is compiled w/o treads support.

Fixes http://sysmic.org/~jezz/results/204099dd:

../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

This seems weird. We have a no threads toolchain in our autobuilders and it was never detected, even though I'm pretty sure libffi was built a number of times. Do you have the configuration that exhibits the problem?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#27 lore raw

PATCH 12/12 libffi and python: need threads support

Quoted 11 lines · On Saturday 13 September 2014 09:57:12 Thomas Petazzoni wrote:

Dear J?r?me Pouiller,

Quoted 8 lines · J?r?me Pouiller

libffi depends on pthreads.

Python depends on libffi (it can provide a builtin libffi, but also depends on pthreads). Thus this patch also disable Python support if toolchain is compiled w/o treads support.

Fixes http://sysmic.org/~jezz/results/204099dd:

Quoted 7 lines
Quoted 2 lines

../src/closures.c:119:21: fatal error: pthread.h: No such file or directory

This seems weird. We have a no threads toolchain in our autobuilders and it was never detected, even though I'm pretty sure libffi was built a number of times. Do you have the configuration that exhibits the problem?

I can reproduce problem using:

BR2_powerpc=y
BR2_powerpc_440=y
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_TOOLCHAIN_BUILDROOT_INET_RPC=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_PTHREADS_NONE=y
BR2_BINUTILS_VERSION_2_24=y
BR2_GCC_VERSION_4_9_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_LIBFFI=y

In add, I found this patch :
http://lists.busybox.net/pipermail/buildroot/2012-November/061976.html

It is seems is had never been applied and it should solve this issue.

Signature · 3 lines
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr