pkg-infra: put optional step_user def and assignment in one block
PATCH 1/2 pkg-infra: put optional step_user def and assignment in one block
---
Like the manual says in 'The .mk file' section ...
--- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-generic.mk +1 -1
@@ -56,11 +56,11 @@ endef GLOBAL_INSTRUMENTATION_HOOKS += step_time # User-supplied script +ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),) define step_user @$(foreach user_hook, $(BR2_INSTRUMENTATION_SCRIPTS), \ $(EXTRA_ENV) $(user_hook) "$(1)" "$(2)" "$(3)"$(sep)) endef -ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),) GLOBAL_INSTRUMENTATION_HOOKS += step_user endif
Signature · 1 line
1.9.1
PATCH 2/2 pkg-infra: make timing of steps optional
Commit 17d4eb1e0261793a9f89e4a2253602c7ab926d2e added a hook to log timing of steps to a build-time.log file, which provides data for the "graph-build" target for examining build time stats. If one uses buildroot on a daily basis as part of a build system, then its conceivable that there might be long periods of time between "make clean" ops. So the log file continues to grow. This patch makes the accumulation of the timing data optional, to avoid having a silent endlessly growing log in the build directory.
--- Config.in | 6 ++++++ package/pkg-generic.mk | 2 ++ 2 files changed, 8 insertions(+)
Config.in +6 -0
@@ -574,6 +574,12 @@ config BR2_GLOBAL_PATCH_DIR Otherwise, if the directory <global-patch-dir>/<packagename> exists, then all *.patch files in the directory will be applied. +config BR2_GATHER_BUILD_TIME_STATS + bool "Gather build time statistics" + help + Record the start and end time of each step in the build process, so + that buildroot can generate graphs of the build times. + endmenu source "toolchain/Config.in"
package/pkg-generic.mk +2 -0
@@ -48,12 +48,14 @@ endef # Actual steps hooks # Time steps +ifneq ($(BR2_GATHER_BUILD_TIME_STATS),) define step_time printf "%s:%-5.5s:%-20.20s: %s\n" \ "$$(date +%s)" "$(1)" "$(2)" "$(3)" \ >>"$(BUILD_DIR)/build-time.log" endef GLOBAL_INSTRUMENTATION_HOOKS += step_time +endif # User-supplied script ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
Signature · 1 line
1.9.1
PATCH 2/2 pkg-infra: make timing of steps optional
Danomi, All,
On 2014-09-12 23:14 -0400, Danomi Manchego spake thusly:
Quoted 7 lines
Commit
17d4eb1e0261793a9f89e4a2253602c7ab926d2eadded a hook to log timing of steps to a build-time.log file, which provides data for the "graph-build" target for examining build time stats. If one uses buildroot on a daily basis as part of a build system, then its conceivable that there might be long periods of time between "make clean" ops. So the log file continues to grow. This patch makes the accumulation of the timing data optional, to avoid having a silent endlessly growing log in the build directory.
Well, it is ever growing, indeed, but its size is not that much, when compared to the other generated artifacts:
$ du -hs output
1.7G .
$ ls -lh output/build/build-time.log
-rw-rw-r-- 1 ymorin ymorin 33K Sep 14 23:55 output/build/build-time.logBut OK on principle. See a comment below...
[--SNIP--]
package/pkg-generic.mk endef · line 51
Quoted 9 lines
package/pkg-generic.mk +1
-0@@ -48,12 +48,14 @@ endef # Actual steps hooks # Time steps +ifneq ($(BR2_GATHER_BUILD_TIME_STATS),)
Please use positive logic:
ifeq ($(BR2_GATHER_BUILD_TIME_STATS),y)
Regards,
Yann E. MORIN.
Quoted 17 lines
package/pkg-generic.mk +1
-0define step_time printf "%s:%-5.5s:%-20.20s: %s\n" \ "$$(date +%s)" "$(1)" "$(2)" "$(3)" \ >>"$(BUILD_DIR)/build-time.log" endef GLOBAL_INSTRUMENTATION_HOOKS += step_time +endif # User-supplied script ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)Signature · 6 lines
1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 pkg-infra: put optional step_user def and assignment in one block
In reply to Danomi ManchegoDanomi, All,
On 2014-09-12 23:14 -0400, Danomi Manchego spake thusly:
Quoted 1 line
Signed-off-by Danomi Manchego <[email protected]>
Regards,
Yann E. MORIN.
Quoted 33 lines
---
Like the manual says in 'The .mk file' section ...
Signed-off-by Danomi Manchego <[email protected]>--- package/pkg-generic.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/pkg-generic.mk +1
-1@@ -56,11 +56,11 @@ endef GLOBAL_INSTRUMENTATION_HOOKS += step_time # User-supplied script +ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),) define step_user @$(foreach user_hook, $(BR2_INSTRUMENTATION_SCRIPTS), \ $(EXTRA_ENV) $(user_hook) "$(1)" "$(2)" "$(3)"$(sep)) endef -ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),) GLOBAL_INSTRUMENTATION_HOOKS += step_user endifSignature · 6 lines
1.9.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'