Skip to contentSkip to conversation

edac: Fix build error caused by wrong member access

PATCH Applied Pranith Kumar 3 participants 4 messages Aug 19, 2014 – Sep 15, 2014 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 edac: Fix build error caused by wrong member access

Fix the following error

drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something not a structure or union

by changing member access to pointer dereference

---
 drivers/edac/ppc4xx_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/ppc4xx_edac.c +1 -1
index ef6b7e0..0f04d5e 100644
@@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1)
 		 * page size (PAGE_SIZE) or the memory width (2 or 4).
 		 */
 		for (j = 0; j < csi->nr_channels; j++) {
-			struct dimm_info *dimm = csi->channels[j].dimm;
+			struct dimm_info *dimm = csi->channels[j]->dimm;
 
 			dimm->nr_pages  = nr_pages / csi->nr_channels;
 			dimm->grain	= 1;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 10 lines · On Tue, 19 Aug 2014 17:10:46 -0400 Pranith Kumar <[email protected]> wrote:

Fix the following error

drivers/edac/ppc4xx_edac.c:977:45: error: request for member 'dimm' in something not a structure or union

by changing member access to pointer dereference

drivers/edac/ppc4xx_edac.c static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1) · line 980

Quoted 8 lines
drivers/edac/ppc4xx_edac.c +1 -1
@@ -974,7 +974,7 @@ static int ppc4xx_edac_init_csrows(struct mem_ctl_info *mci, u32 mcopt1)
 		 * page size (PAGE_SIZE) or the memory width (2 or 4).
 		 */
 		for (j = 0; j < csi->nr_channels; j++) {
-			struct dimm_info *dimm = csi->channels[j].dimm;
+			struct dimm_info *dimm = csi->channels[j]->dimm;
 
 			dimm->nr_pages  = nr_pages / csi->nr_channels;
 			dimm->grain	= 1;

This driver seems pretty unhealthy and I suspect it has been broken for quite a while.

drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function '__mfdcri' drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function '__mtdcri' drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function returning void drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible pointer type drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something not a structure or union drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' discards qualifiers from pointer target type

#2 lore raw
Quoted 4 lines · Andrew Morton

This driver seems pretty unhealthy and I suspect it has been broken for quite a while.

Quoted 12 lines

drivers/edac/ppc4xx_edac.c: In function 'mfsdram':
drivers/edac/ppc4xx_edac.c:249: error: implicit declaration of function '__mfdcri' drivers/edac/ppc4xx_edac.c: In function 'mtsdram':
drivers/edac/ppc4xx_edac.c:266: error: implicit declaration of function '__mtdcri' drivers/edac/ppc4xx_edac.c:269: warning: 'return' with a value, in function returning void drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_init_csrows':
drivers/edac/ppc4xx_edac.c:924: warning: initialization from incompatible pointer type drivers/edac/ppc4xx_edac.c:977: error: request for member 'dimm' in something not a structure or union drivers/edac/ppc4xx_edac.c: In function 'ppc4xx_edac_map_dcrs':
drivers/edac/ppc4xx_edac.c:1209: warning: passing argument 1 of 'dcr_map_mmio' discards qualifiers from pointer target type

Yes, not sure if anyone is actually using it.

Anways, I will send in a patch to fix the errors which you point out here.

Signature · 1 line
Pranith