Skip to contentSkip to conversation

seccomp,x86,arm,mips,s390: Remove nr parameter from secure_computing

tip:x86/seccomp Ingo Molnar 2 participants 2 messages Sep 16, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · tip-bot for Andy Lutomirski
Commit-ID:  a4412fc9486ec85686c6c7929e7e829f62ae377e
Gitweb:     http://git.kernel.org/tip/a4412fc9486ec85686c6c7929e7e829f62ae377e
Author:     Andy Lutomirski <[email protected]>
AuthorDate: Mon, 21 Jul 2014 18:49:14 -0700
Committer:  Kees Cook <[email protected]>
CommitDate: Wed, 3 Sep 2014 14:58:17 -0700

seccomp,x86,arm,mips,s390: Remove nr parameter from secure_computing

So, this commit in -tip, combined with Linus's latest (v3.17-rc5), produces this build failure or arch/parisc defconfig:

/home/mingo/tip/arch/parisc/kernel/ptrace.c: In function 'do_syscall_trace_enter':
/home/mingo/tip/arch/parisc/kernel/ptrace.c:274: error: implicit declaration of function 'secure_computing' make[2]: *** [arch/parisc/kernel/ptrace.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [arch/parisc/kernel] Error 2

My guess is that the interaction was caused by:

c90f06943e05 parisc: Wire up seccomp, getrandom and memfd_create syscalls

Thanks,

Ingo

#2 lore raw
Quoted 22 lines · Ingo Molnar
Quoted 8 lines · tip-bot for Andy Lutomirski
Commit-ID:  a4412fc9486ec85686c6c7929e7e829f62ae377e
Gitweb:     http://git.kernel.org/tip/a4412fc9486ec85686c6c7929e7e829f62ae377e
Author:     Andy Lutomirski <[email protected]>
AuthorDate: Mon, 21 Jul 2014 18:49:14 -0700
Committer:  Kees Cook <[email protected]>
CommitDate: Wed, 3 Sep 2014 14:58:17 -0700

seccomp,x86,arm,mips,s390: Remove nr parameter from secure_computing

So, this commit in -tip, combined with Linus's latest (v3.17-rc5), produces this build failure or arch/parisc defconfig:

/home/mingo/tip/arch/parisc/kernel/ptrace.c: In function 'do_syscall_trace_enter':
/home/mingo/tip/arch/parisc/kernel/ptrace.c:274: error: implicit declaration of function 'secure_computing' make[2]: *** [arch/parisc/kernel/ptrace.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [arch/parisc/kernel] Error 2

Quoted 3 lines

My guess is that the interaction was caused by:

c90f06943e05 parisc: Wire up seccomp, getrandom and memfd_create syscalls

I guess this something like this was unavoidable. Here's a fix:

http://lkml.kernel.org/g/db9b257536558b5f068e97717bb0f25bcc603ae4.1410883257.git.luto@amacapital.net

--Andy