Skip to contentSkip to conversation

omniorb: limit to glibc toolchains

PATCH New Matt Weber 2 participants 5 messages Sep 15, 2014 – Sep 16, 2014

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 omniorb: limit to glibc toolchains

Resolves autobuilder failure where the omniorb package doesn't correctly detect the OS because the configure script doesn't have an option for uclinux support. This results in a pthread create assertion when it attempts to figure-out the correct C library posix calls.

http://autobuild.buildroot.net/results/fbe6c722b92fe4ddf7ac36a8fe1be3a3891c11fd/

---
 package/omniorb/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/omniorb/Config.in +3 -2
index b8c4e0a..703cb64 100644
@@ -1,9 +1,10 @@
 
-comment "omniORB needs a toolchain w/ C++, threads"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+comment "omniORB needs a glibc toolchain w/ C++, threads"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_OMNIORB
 	bool "omniorb"
+	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 omniorb: limit to glibc toolchains

Dear Matt Weber,

Quoted 9 lines · Matt Weber

Resolves autobuilder failure where the omniorb package doesn't correctly detect the OS because the configure script doesn't have an option for uclinux support. This results in a pthread create assertion when it attempts to figure-out the correct C library posix calls.

http://autobuild.buildroot.net/results/fbe6c722b92fe4ddf7ac36a8fe1be3a3891c11fd/

Wait, wait, wait, no.

uclinux != uclibc.

uclinux is the part of the host tuple used only on noMMU platforms that don't support shared libraries.

If you use uClibc on ARM, it's not a uClinux system.

So, clearly, disabling entirely the package for uClibc doesn't make sense here.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 omniorb: limit to glibc toolchains

Thomas,

Quoted 18 lines · Thomas Petazzoni

Dear Matt Weber,

Quoted 7 lines · Matt Weber

Resolves autobuilder failure where the omniorb package doesn't correctly detect the OS because the configure script doesn't have an option for uclinux support. This results in a pthread create assertion when it attempts to figure-out the correct C library posix calls.

http://autobuild.buildroot.net/results/fbe6c722b92fe4ddf7ac36a8fe1be3a3891c11fd/

Quoted 2 lines

Wait, wait, wait, no.

uclinux != uclibc.

Quoted 8 lines

uclinux is the part of the host tuple used only on noMMU platforms that don't support shared libraries.

If you use uClibc on ARM, it's not a uClinux system.

So, clearly, disabling entirely the package for uClibc doesn't make sense here.

Thank you for that clarification, that makes a bit more sense on why this issue didn't come up as often in the autobuilds. I would assume that updating this path to a needs MMU instead is the correct approach.

Quoted 7 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 11 lines
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted Third
Party Intellectual Property (TPIP) content must be encrypted and sent to
matthew.weber at corp.rockwellcollins.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140915/b7aea58f/attachment.html>
#3 lore raw

PATCH 1/1 omniorb: limit to glibc toolchains

Dear Thomas,

Quoted 28 lines · Matthew Weber

Thomas,

Quoted 23 lines · Thomas Petazzoni

Dear Matt Weber,

Quoted 7 lines · Matt Weber

Resolves autobuilder failure where the omniorb package doesn't correctly detect the OS because the configure script doesn't have an option for uclinux support. This results in a pthread create assertion when it attempts to figure-out the correct C library posix calls.

http://autobuild.buildroot.net/results/fbe6c722b92fe4ddf7ac36a8fe1be3a3891c11fd/

Quoted 2 lines

Wait, wait, wait, no.

uclinux != uclibc.

uclinux is the part of the host tuple used only on noMMU platforms that don't support shared libraries.

If you use uClibc on ARM, it's not a uClinux system.

Quoted 8 lines
Quoted 3 lines

So, clearly, disabling entirely the package for uClibc doesn't make sense here.

Thank you for that clarification, that makes a bit more sense on why this issue didn't come up as often in the autobuilds. I would assume that updating this path to a needs MMU instead is the correct approach.

I retested with a "depends on BR2_USE_MMU", which excluded that package from the bfin build.

I had another question. Over the last couple weeks, I've created a couple patches that can be discarded. How do those get removed from patchworks?

Quoted 23 lines
Quoted 10 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.

Signature · 11 lines
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted Third
Party Intellectual Property (TPIP) content must be encrypted and sent to
matthew.weber at corp.rockwellcollins.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140915/fb661ef4/attachment.html>
#4 lore raw

PATCH 1/1 omniorb: limit to glibc toolchains

Dear Matthew Weber,

Quoted 6 lines · Matthew Weber
Quoted 3 lines

Thank you for that clarification, that makes a bit more sense on why this issue didn't come up as often in the autobuilds. I would assume that updating this path to a needs MMU instead is the correct approach.

I retested with a "depends on BR2_USE_MMU", which excluded that package from the bfin build.

Did you test whether the package builds with Blackfin FDPIC ?

Looking at the build error, it doesn't seem to be MMU or noMMU related.

Quoted 2 lines

I had another question. Over the last couple weeks, I've created a couple patches that can be discarded. How do those get removed from patchworks?

Either the patch submitter does it (everyone can create an account on patchwork and then manage his own patches), or some patchwork administrator does it (I think Peter, Yann, Thomas DS, me, and maybe a few other core developers are patchwork admins).

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com