Skip to contentSkip to conversation

portmap: fix static linking

PATCH New ANDY KENNEDY 2 participants 3 messages Sep 8, 2014 – Sep 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 portmap: fix static linking

Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap.

---

package/portmap/portmap.mk +1 -2
diff -Naur a/package/portmap/portmap.mk b/package/portmap/portmap.mk
@@ -15,8 +15,7 @@
 endif
 
 define PORTMAP_BUILD_CMDS
-	CFLAGS="$(TARGET_CFLAGS)" \
-	$(MAKE) CC="$(TARGET_CC)" -C $(@D) $(PORTMAP_FLAGS)
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) $(PORTMAP_FLAGS)
 endef
 
#1 lore raw

PATCH 1/1 portmap: fix static linking

Dear ANDY KENNEDY,

Quoted 7 lines · ANDY KENNEDY

Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap.

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 portmap: fix static linking

In reply to ANDY KENNEDY

Dear ANDY KENNEDY,

Quoted 7 lines · ANDY KENNEDY

Portmap builds and links, however, does not get built correctly when BR2_PREFER_STATIC_LIB is selected. There are no dynamic libraries in rootfs.tar, however, portmap gets linked dynamically without regards to the PREFER_STATIC_LIB tags. LDFLAGS was not being passed into the build of portmap.

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com