Skip to contentSkip to conversation

nsd: new package

PATCH New Eric Le Bihan 3 participants 6 messages Sep 15, 2014 – Sep 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nsd: new package

This package provides NSD, an authoritative only, high performance, simple and open source name server.

---
 package/Config.in       |  1 +
 package/nsd/Config.in   | 15 ++++++++++++++
 package/nsd/S80nsd      | 54 +++++++++++++++++++++++++++++++++++++++++++++++++
 package/nsd/nsd.mk      | 50 +++++++++++++++++++++++++++++++++++++++++++++
 package/nsd/nsd.service | 13 ++++++++++++
 5 files changed, 133 insertions(+)
 create mode 100644 package/nsd/Config.in
 create mode 100644 package/nsd/S80nsd
 create mode 100644 package/nsd/nsd.mk
 create mode 100644 package/nsd/nsd.service
package/Config.in +1 -0
index 73ba86a..c655ee0 100644
@@ -1030,6 +1030,7 @@ endif
 	source "package/ngrep/Config.in"
 	source "package/nmap/Config.in"
 	source "package/noip/Config.in"
+	source "package/nsd/Config.in"
 	source "package/ntp/Config.in"
 	source "package/nuttcp/Config.in"
 	source "package/odhcploc/Config.in"
package/nsd/Config.in new file +15 -0
new file mode 100644
index 0000000..de9d213
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_NSD
+	bool "nsd"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_LIBEVENT
+	select BR2_PACKAGE_OPENSSL
+	help
+	  NSD is an authoritative only, high performance, simple and open
+	  source name server.
+
+	  http://www.nlnetlabs.nl/projects/nsd/
+
+comment "nsd needs a toolchain w/ threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/nsd/S80nsd new file +54 -0

54 lines not on this page · raw message

package/nsd/nsd.mk new file +50 -0

50 lines not on this page · raw message

package/nsd/nsd.service new file +13 -0
new file mode 100644
index 0000000..5089e85
@@ -0,0 +1,13 @@
+[Unit]
+Description=NSD Name Server Daemon
+After=network.target
+
+[Service]
+PIDFile=/run/nsd/nsd.pid
+ExecStart=/usr/sbin/nsd -d -c /etc/nsd/nsd.conf
+ExecReload=/bin/kill -HUP $MAINPID
+ExecStop=/bin/kill -TERM $MAINPID
+Restart=always
+
+[Install]
+WantedBy=multi-user.target
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 unbound: new package

This package provides Unbound, a validating, recursive, and caching DNS resolver.

---
 package/Config.in               |  1 +
 package/unbound/Config.in       | 17 +++++++++++++
 package/unbound/S80unbound      | 54 +++++++++++++++++++++++++++++++++++++++++
 package/unbound/unbound.mk      | 43 ++++++++++++++++++++++++++++++++
 package/unbound/unbound.service | 12 +++++++++
 5 files changed, 127 insertions(+)
 create mode 100644 package/unbound/Config.in
 create mode 100644 package/unbound/S80unbound
 create mode 100644 package/unbound/unbound.mk
 create mode 100644 package/unbound/unbound.service
package/Config.in +1 -0
index c655ee0..9506b6e 100644
@@ -1084,6 +1084,7 @@ endif
 	source "package/tvheadend/Config.in"
 	source "package/udpcast/Config.in"
 	source "package/ulogd/Config.in"
+	source "package/unbound/Config.in"
 	source "package/ushare/Config.in"
 	source "package/ussp-push/Config.in"
 	source "package/vde2/Config.in"
package/unbound/Config.in new file +17 -0
new file mode 100644
index 0000000..57bc09f
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_UNBOUND
+	bool "unbound"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB # dlopen()
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBEVENT
+	select BR2_PACKAGE_OPENSSL
+	help
+	  Unbound is a validating, recursive, and caching DNS resolver.
+
+	  http://unbound.net/
+
+comment "unbound needs a toolchain w/ threads, dynamic library"
+	depends on BR2_USE_MMU
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PREFER_STATIC_LIB
package/unbound/S80unbound new file +54 -0

54 lines not on this page · raw message

package/unbound/unbound.mk new file +43 -0

43 lines not on this page · raw message

package/unbound/unbound.service new file +12 -0
new file mode 100644
index 0000000..8e59e5a
@@ -0,0 +1,12 @@
+[Unit]
+Description=Unbound DNS Resolver
+After=network.target
+
+[Service]
+PIDFile=/run/unbound.pid
+ExecStart=/usr/sbin/unbound -d
+ExecReload=/bin/kill -HUP $MAINPID
+Restart=always
+
+[Install]
+WantedBy=multi-user.target
Signature · 1 line
1.9.3
#2 lore raw

PATCH 1/1 unbound: new package

Hi,

Quoted 2 lines · Eric Le Bihan

This package provides Unbound, a validating, recursive, and caching DNS resolver.

Nice addition.
We're an unbound user as well, but never got around to submitting our local package, and I know unbound has some odd issues.

Some points:

- Unbound (at least when using your package with sysv) currently creates a pid file in /etc/unbound/unbound.pid
Suggest that to be changed to /var/run/unbound.pid, so it also works on read-only file systems.

- Unbound is currently broken when IPv6 is disabled in the buildroot configuration.

Listens on both 127.0.0.1 and ::1 by default, and errors out on the ::1

==
unbound[118:0] error: node ::1:53 getaddrinfo: ai_family not supported
[13] unbound[118:0] fatal error: could not open ports
FAIL
==

You do can override the default by specifying "interface: 127.0.0.1" in unbound.conf but then it errors out on:

==
"error: cannot parse access control: ::0/0 refuse" ==

Don't no how to override that internal ACL rule.
Might need to let the package depend on IPv6

- Unbound is typically used as local resolving nameserver. I was wondering if the startup script shouldn't put "nameserver 127.0.0.1" in /etc/resolv.conf
Possibly with an option to turn that off by a setting in /etc/default/unbound

- Unbound expects /etc/unbound to be owned by user unbound Or if you do enable DNSSEC by uncommenting the "auto-trust-anchor-file" line in /etc/unbound/unbound.conf, you get errors that it is unable to create files:

==
error: could not open autotrust file for writing, /root.key.306-0:
Permission denied
==

- I also wonder if there shouldn't be an option to let the startup script run unbound-anchor prior to starting the unbound daemon. This updates the DNSSEC trust anchor files.
(Enabling DNSSEC validation has some caveats though, in particular it requires the system to have correct date/time settings, so should be left disabled by default)

Quoted 1 line

+NAME=nsd

nsd -> unbound

Quoted 1 line

+UNBOUND_DEPENDENCIES = expat libevent openssl

libevent is an optional dependency. (don't have it in my local package)

Quoted 1 line

+++ b/package/unbound/S80unbound

- Wondering if S80unbound shouldn't be a lower number like S41 for systems that intend to use it as local resolver.
So that other services like S49ntp can use it to resolve pool.ntp.org.

Yours sincerely,

Floris Bos

#3 lore raw

PATCH 1/1 unbound: new package

Hi!

Quoted 11 lines · Floris Bos

Hi,

Quoted 2 lines · Eric Le Bihan

This package provides Unbound, a validating, recursive, and caching DNS resolver.

Nice addition.
We're an unbound user as well, but never got around to submitting our local package, and I know unbound has some odd issues.

Quoted 6 lines

Some points:

- Unbound (at least when using your package with sysv) currently creates a pid file in /etc/unbound/unbound.pid
Suggest that to be changed to /var/run/unbound.pid, so it also works on read-only file systems.

I did it in the case where systemd is chosen as init system, but not when chosing SysV/Busybox. Good catch.

Quoted 14 lines

- Unbound is currently broken when IPv6 is disabled in the buildroot configuration.

Listens on both 127.0.0.1 and ::1 by default, and errors out on the ::1

==
unbound[118:0] error: node ::1:53 getaddrinfo: ai_family not supported
[13] unbound[118:0] fatal error: could not open ports
FAIL
==

You do can override the default by specifying "interface: 127.0.0.1" in unbound.conf but then it errors out on:

Quoted 6 lines

==
"error: cannot parse access control: ::0/0 refuse" ==

Don't no how to override that internal ACL rule.
Might need to let the package depend on IPv6

I'll test this.

Quoted 17 lines

- Unbound is typically used as local resolving nameserver.
I was wondering if the startup script shouldn't put "nameserver 127.0.0.1" in /etc/resolv.conf
Possibly with an option to turn that off by a setting in /etc/default/unbound

- Unbound expects /etc/unbound to be owned by user unbound
Or if you do enable DNSSEC by uncommenting the "auto-trust-anchor-file" line in /etc/unbound/unbound.conf, you get errors that it is unable to create files:

==
error: could not open autotrust file for writing, /root.key.306-0:
Permission denied
==

Quoted 6 lines

- I also wonder if there shouldn't be an option to let the startup script run unbound-anchor prior to starting the unbound daemon.
This updates the DNSSEC trust anchor files.
(Enabling DNSSEC validation has some caveats though, in particular it requires the system to have correct date/time settings, so should be left disabled by default)

I am not (yet) familiar with DNSSEC, nor with the chroot case. Maybe this should be left for the user to customize? I'll provide a minimal default configuration file, so the service starts without error, anyway.

Quoted 3 lines
Quoted 1 line

+NAME=nsd

nsd -> unbound

Of course!

Quoted 4 lines
Quoted 2 lines

+UNBOUND_DEPENDENCIES = expat libevent openssl

libevent is an optional dependency. (don't have it in my local package)

I will take this into account.

Quoted 5 lines
Quoted 1 line

+++ b/package/unbound/S80unbound

- Wondering if S80unbound shouldn't be a lower number like S41 for systems that intend to use it as local resolver.
So that other services like S49ntp can use it to resolve pool.ntp.org.

If this is a specific user case, I think changing the priority of the service should be left to the user.

Thanks for the review!

Best regards,
ELB

#4 lore raw

PATCH 1/1 nsd: new package

In reply to Eric Le Bihan

Dear Eric Le Bihan,

Quoted 4 lines · Eric Le Bihan

This package provides NSD, an authoritative only, high performance, simple and open source name server.

This looks good. Just a few questions below, not really critical.

Quoted 1 line

+NSD_VERSION = 4.0.3

There is a new version that has been released 4.1.0. Though I don't mind seeing the 4.0.3 being packaged in Buildroot for now, and then later if you have the time, a bump to 4.1.0.

package/nsd/nsd.mk line 16

Quoted 9 lines
package/nsd/nsd.mk new file +9 -0
+NSD_SITE = http://www.nlnetlabs.nl/downloads/nsd/
+NSD_LICENSE = BSD-3c
+NSD_LICENSE_FILES = LICENSE
+
+NSD_DEPENDENCIES = libevent openssl
+
+NSD_CONF_OPT = \
+	--prefix=/ \
+	--datarootdir=/usr/share

This is fairly unusual, especially the --prefix=/, so having a comment above would be useful.

package/nsd/nsd.mk line 20

Quoted 3 lines
package/nsd/nsd.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+NSD_CONF_OPT += --with-pidfile=/run/nsd/nsd.pid
+endif

Ok, so for systemd the pidfile location is defined at compile time, but for sysv/busybox init, it's passed through the init script.

package/nsd/nsd.mk line 48

Quoted 5 lines
package/nsd/nsd.mk new file +5 -0
+define NSD_REMOVE_SAMPLE_CONF
+	$(RM) $(TARGET_DIR)/etc/nsd/nsd.conf.sample
+endef
+
+NSD_POST_INSTALL_TARGET_HOOKS += NSD_REMOVE_SAMPLE_CONF

Is there a non sample file installed?

Also, when build testing, I faced an issue:

checking for libevent... configure: error: Cannot find the libevent library. You can restart ./configure --with-libevent=no to use a builtin alternative.
make: *** [/home/thomas/projets/buildroot/output/build/nsd-4.0.3/.stamp_configured] Erreur 1

Configuration used is:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2014.08.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_16=y
BR2_TOOLCHAIN_EXTERNAL_LARGEFILE=y
BR2_TOOLCHAIN_EXTERNAL_INET_IPV6=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_PACKAGE_NSD=y

I see libevent being built. The config.log of nsd contains:

configure:5427: checking for libevent
configure:5453: error: Cannot find the libevent library.
You can restart ./configure --with-libevent=no to use a builtin alternative.

The same happens with OpenSSL:

checking for SSL... configure: error: Cannot find the SSL libraries in /usr/local/ssl /usr/lib/ssl /usr/ssl /usr/pkg /usr/sfw /usr/local /usr

You probably need to pass --with-{libevent,ssl}=/some/path, but I haven't figured out which path (I haven't looked too much, only tested $(STAGING_DIR) and $(STAGING_DIR)/usr/lib).

Also, your package makes openssl and libevent mandatory dependencies of nsd, which is not the case: you can pass --with-libevent=no and --with-ssl=no and you can build without those dependencies. This is something we should support to allow building a more lightweight version of nsd.

Then, at boot time, I get:

Starting Name Server Daemon: Could not open /etc/nsd/nsd.conf: No such file or directory [1410900412] nsd[525]: error: could not read config: /etc/nsd/nsd.conf

We generally like to have a default configuration file installed, so that the service works in a minimal way "out of the box".

Could you have a look at those issues?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 nsd: new package

Hi!

Quoted 8 lines · Thomas Petazzoni

Dear Eric Le Bihan,

Quoted 4 lines · Eric Le Bihan

This package provides NSD, an authoritative only, high performance, simple and open source name server.

Quoted 7 lines

This looks good. Just a few questions below, not really critical.

Quoted 1 line

+NSD_VERSION = 4.0.3

There is a new version that has been released 4.1.0. Though I don't mind seeing the 4.0.3 being packaged in Buildroot for now, and then later if you have the time, a bump to 4.1.0.

I'll go for 4.1.0!

Quoted 13 lines

package/nsd/nsd.mk line 16

Quoted 10 lines
package/nsd/nsd.mk new file +9 -0
+NSD_SITE = http://www.nlnetlabs.nl/downloads/nsd/
+NSD_LICENSE = BSD-3c
+NSD_LICENSE_FILES = LICENSE
+
+NSD_DEPENDENCIES = libevent openssl
+
+NSD_CONF_OPT = \
+	--prefix=/ \
+	--datarootdir=/usr/share

This is fairly unusual, especially the --prefix=/, so having a comment above would be useful.

If --prefix was set to /usr, the program was looking for stuff in /usr/var/db. But this can be removed if using --with-dbfile and --datarootdir.

Quoted 6 lines

package/nsd/nsd.mk line 20

Quoted 3 lines
package/nsd/nsd.mk new file +3 -0
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+NSD_CONF_OPT += --with-pidfile=/run/nsd/nsd.pid
+endif

Ok, so for systemd the pidfile location is defined at compile time, but for sysv/busybox init, it's passed through the init script.

For SysV/Busybox, I'll use --with-pidfile=/var/run/nsd.pid and adapt the script.

Quoted 7 lines

package/nsd/nsd.mk line 48

Quoted 5 lines
package/nsd/nsd.mk new file +5 -0
+define NSD_REMOVE_SAMPLE_CONF
+	$(RM) $(TARGET_DIR)/etc/nsd/nsd.conf.sample
+endef
+
+NSD_POST_INSTALL_TARGET_HOOKS += NSD_REMOVE_SAMPLE_CONF

Is there a non sample file installed?

No, but I'll provide a minimal default configuration file.

Quoted 28 lines

Also, when build testing, I faced an issue:

checking for libevent... configure: error: Cannot find the libevent library. You can restart ./configure --with-libevent=no to use a builtin alternative.
make: *** [/home/thomas/projets/buildroot/output/build/nsd-4.0.3/.stamp_configured] Erreur 1

Configuration used is:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2014.08.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_16=y
BR2_TOOLCHAIN_EXTERNAL_LARGEFILE=y
BR2_TOOLCHAIN_EXTERNAL_INET_IPV6=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_PACKAGE_NSD=y

I see libevent being built. The config.log of nsd contains:

configure:5427: checking for libevent
configure:5453: error: Cannot find the libevent library.
You can restart ./configure --with-libevent=no to use a builtin alternative.

Quoted 7 lines

The same happens with OpenSSL:

checking for SSL... configure: error: Cannot find the SSL libraries in /usr/local/ssl /usr/lib/ssl /usr/ssl /usr/pkg /usr/sfw /usr/local /usr

You probably need to pass --with-{libevent,ssl}=/some/path, but I haven't figured out which path (I haven't looked too much, only tested $(STAGING_DIR) and $(STAGING_DIR)/usr/lib).

And the correct answer is... --with-libevent=$(STAGING_DIR)/usr!

Quoted 5 lines

Also, your package makes openssl and libevent mandatory dependencies of nsd, which is not the case: you can pass --with-libevent=no and --with-ssl=no and you can build without those dependencies. This is something we should support to allow building a more lightweight version of nsd.

I make libevent and openssl optional dependencies.

Thanks for the review!

Best regards,
ELB