Skip to contentSkip to conversation

Fix a few printf argument verification warnings

PATCH In review Vasili Galka 2 participants 2 messages Aug 26, 2014 – Sep 17, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix a few printf argument verification warnings

The parameters of size_t type shall be formatted using "%zu" and not using "%d".

Precision argument for the "%.*s" parameters shall be of int type.

---
 common/bouncebuf.c    |    2 +-
 common/cmd_mtdparts.c |    4 ++--
 common/spl/spl.c      |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
common/bouncebuf.c +1 -1
index 9eece6d..054d9e0 100644
@@ -23,7 +23,7 @@ static int addr_aligned(struct bounce_buffer *state)
 
 	/* Check if length is aligned */
 	if (state->len != state->len_aligned) {
-		debug("Unaligned buffer length %d\n", state->len);
+		debug("Unaligned buffer length %zu\n", state->len);
 		return 0;
 	}
 
common/cmd_mtdparts.c +2 -2
index 40b6333..d793f74 100644
@@ -861,7 +861,7 @@ static int device_parse(const char *const mtd_dev, const char **ret, struct mtd_
 	debug("dev type = %d (%s), dev num = %d, mtd-id = %s\n",
 			id->type, MTD_DEV_TYPE(id->type),
 			id->num, id->mtd_id);
-	debug("parsing partitions %.*s\n", (pend ? pend - p : strlen(p)), p);
+	debug("parsing partitions %.*s\n", (int)(pend ? pend - p : strlen(p)), p);
 
 
 	/* parse partitions */
@@ -1006,7 +1006,7 @@ static struct mtdids* id_find_by_mtd_id(const char *mtd_id, unsigned int mtd_id_
 	list_for_each(entry, &mtdids) {
 		id = list_entry(entry, struct mtdids, link);
 
-		debug("entry: '%s' (len = %d)\n",
+		debug("entry: '%s' (len = %zu)\n",
 				id->mtd_id, strlen(id->mtd_id));
 
 		if (mtd_id_len != strlen(id->mtd_id))
common/spl/spl.c +1 -1
index 774fdad..b16664f 100644
@@ -86,7 +86,7 @@ void spl_parse_image_header(const struct image_header *header)
 		spl_image.os = image_get_os(header);
 		spl_image.name = image_get_name(header);
 		debug("spl: payload image: %.*s load addr: 0x%x size: %d\n",
-			sizeof(spl_image.name), spl_image.name,
+			(int)sizeof(spl_image.name), spl_image.name,
 			spl_image.load_addr, spl_image.size);
 	} else {
 		/* Signature not found - assume u-boot.bin */
Signature · 1 line
1.7.9
#1 lore raw
Quoted 6 lines · Vasili Galka

The parameters of size_t type shall be formatted using "%zu" and not using "%d".

Precision argument for the "%.*s" parameters shall be of int type.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140916/71879223/attachment.pgp>