Skip to contentSkip to conversation

net: dns: fix for DNS queries sent to the wrong MAC address

PATCH New Gerhard Sittig 2 participants 2 messages Sep 12, 2014 – Sep 17, 2014 Networking

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: dns: fix for DNS queries sent to the wrong MAC address

When a DNS query is sent out, the ethernet packet can get directed to the MAC address of a server that was communicated to before. This is wrong when the previously stored MAC address corresponds to a different server's IP address, i.e. when the IP address of the previous and the current communication are different.

The error can get reproduced by running a sequence of e.g. a TFTP download and a DNS query, where the TFTP and DNS servers reside on individual machines.

The fix is to clear the server's MAC address that might be left from a previous operation, and to fetch the peer's MAC address in a new ARP lookup, before the DNS query is sent. This is the approach taken in other network services, like 8e52533d1095 ("net: tftpsrv: Get correct client MAC address").

---

This patch suffers from a checkpatch warning about CamelCase, which cannot get resolved, as it is a consequence of established identifier names in the network part of the code base.

changes in v2:
- adjust the recipients lists to include the network custodian
- drop an obvious/redundant comment as recommended by Joe Hershberger

---
 net/dns.c |    3 +++
 1 file changed, 3 insertions(+)
net/dns.c +3 -0
index ff9ddffc9d0a..dd4532015045 100644
@@ -202,5 +202,8 @@ DnsStart(void)
 	NetSetTimeout(DNS_TIMEOUT, DnsTimeout);
 	net_set_udp_handler(DnsHandler);
 
+	/* Clear a previous MAC address, the server IP might have changed. */
+	memset(NetServerEther, 0, sizeof(NetServerEther));
+
 	DnsSend();
 }
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 net: dns: fix for DNS queries sent to the wrong MAC address

Quoted 10 lines · Gerhard Sittig

When a DNS query is sent out, the ethernet packet can get directed to the MAC address of a server that was communicated to before. This is wrong when the previously stored MAC address corresponds to a different server's IP address, i.e. when the IP address of the previous and the current communication are different.

The error can get reproduced by running a sequence of e.g. a TFTP download and a DNS query, where the TFTP and DNS servers reside on individual machines.

Quoted 8 lines

The fix is to clear the server's MAC address that might be left from a previous operation, and to fetch the peer's MAC address in a new ARP lookup, before the DNS query is sent. This is the approach taken in other network services, like 8e52533d1095 ("net: tftpsrv: Get correct client MAC address").

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140916/5ba1696f/attachment.pgp>