net: sched: cls_u32: rcu can not be last node
Subsystems (3)
PATCH v2 1/1 net: sched: cls_u32: rcu can not be last node
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the structure and pads the structure with tc_u32_key fields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
--- net/sched/cls_u32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/sched/cls_u32.c +2 -1
@@ -64,8 +64,9 @@ struct tc_u_knode {u32 __percpu *pcpu_success;#endif struct tcf_proto *tp; -struct tc_u32_sel sel;struct rcu_head rcu; +struct tc_u32_sel sel; +/* tc_u32_keys allocated at end of structure */ };struct tc_u_hnode {
Quoted 16 lines · John Fastabend
tc_u32_sel'sel' intc_u_knodeexpects to be the last element in the structure and pads the structure withtc_u32_keyfields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)CC Eric Dumazet <[email protected]>Signed-off-by John Fastabend <[email protected]>--- net/sched/cls_u32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/sched/cls_u32.c +0
-0
net/sched/cls_u32.c struct tc_u_knode { · line 72
Quoted 10 lines
net/sched/cls_u32.c +2
-1@@ -64,8 +64,9 @@ struct tc_u_knode {u32 __percpu *pcpu_success;#endif struct tcf_proto *tp; -struct tc_u32_sel sel;struct rcu_head rcu; +struct tc_u32_sel sel; +/* tc_u32_keys allocated at end of structure */ };struct tc_u_hnode {
Sorry to be picky, but comment should be before 'sel' or at same line.
It should mention that 'sel' MUST be last field.
Thanks !
Quoted 26 lines · Eric Dumazet
Quoted 25 lines · John Fastabend
tc_u32_sel'sel' intc_u_knodeexpects to be the last element in the structure and pads the structure withtc_u32_keyfields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)CC Eric Dumazet <[email protected]>Signed-off-by John Fastabend <[email protected]>--- net/sched/cls_u32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)net/sched/cls_u32.c +2
-1@@ -64,8 +64,9 @@ struct tc_u_knode {u32 __percpu *pcpu_success;#endif struct tcf_proto *tp; -struct tc_u32_sel sel;struct rcu_head rcu; +struct tc_u32_sel sel; +/* tc_u32_keys allocated at end of structure */ };
Quoted 3 lines
net/sched/cls_u32.c struct tc_u_knode { · line 72
Quoted 1 line
net/sched/cls_u32.c +0
-0struct tc_u_hnode {Sorry to be picky, but comment should be before 'sel' or at same line.
no problem lets get it right, I'll post a v3 now and write a better comment.
Quoted 5 lines
It should mention that 'sel' MUST be last field.
Thanks !
Signature · 1 line
John Fastabend Intel Corporation