usb: gadget: fastboot: improve download progress bar
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
When download is ongoing, if the actual size of one transfer is not the same as BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.
So, improve the method to show the progress bar (print dot).
---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/usb/gadget/f_fastboot.c +5 -2
@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f)static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = { .bLength =USB_DT_ENDPOINT_SIZE ,
@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;
@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct usb_request *req)strsep (&cmd,":" ); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ; + num_of_dot =0 ;printf ("Starting download of %d bytes\n" , download_size);
Signature · 1 line
2.1.0.24.g4109c28
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
On Wednesday, September 17, 2014 at 09:43:56 AM, Bo Shen wrote:
+CC Lukasz, this is his turf.
Quoted 39 lines
When download is ongoing, if the actual size of one transfer is not the same as
BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.So, improve the method to show the progress bar (print dot).
Signed-off-by Bo Shen <[email protected]>---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/usb/gadget/f_fastboot.cindex 7a1acb9..2f13bf0 100644drivers/usb/gadget/f_fastboot.c +4
-2@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f) static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = { .bLength =USB_DT_ENDPOINT_SIZE ,@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;
drivers/usb/gadget/f_fastboot.c static void cb_download(struct usb_ep *ep, struct · line 436
Quoted 4 lines
drivers/usb/gadget/f_fastboot.c +1
-0@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ; + num_of_dot =0 ;
Make it a 'download_total' and log the total amount of bytes transferred please, that way it can be re-used for other purposes in the future ; for example for printing how much data were already transferred ;-)
Best regards,
Marek Vasut
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
Hi Marek,
Quoted 43 lines · Marek Vasut
On Wednesday, September 17, 2014 at 09:43:56 AM, Bo Shen wrote:
+CC Lukasz, this is his turf.
Quoted 39 lines
When download is ongoing, if the actual size of one transfer is not the same as
BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.So, improve the method to show the progress bar (print dot).
Signed-off-by Bo Shen <[email protected]>---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/usb/gadget/f_fastboot.cindex 7a1acb9..2f13bf0 100644drivers/usb/gadget/f_fastboot.c +4
-2@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f) static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = { .bLength =USB_DT_ENDPOINT_SIZE ,@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct
Quoted 8 lines
drivers/usb/gadget/f_fastboot.c static void cb_download(struct usb_ep *ep, struct usb_request *req) · line 436
Quoted 4 lines
drivers/usb/gadget/f_fastboot.c +1
-0usb_request *req) strsep(&cmd, ":"); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ; + num_of_dot =0 ;Make it a '
download_total' and log the total amount of bytes transferred please, that way it can be re-used for other purposes in the future ; for example for printing how much data were already transferred ;-)
The download_bytes record the total amount of bytes transferred. And the download_bytes will print after finishing transfer.
Quoted 3 lines
Best regards,
Marek Vasut
Best Regards,
Bo Shen
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
Quoted 62 lines · Bo Shen
Hi Marek,
Quoted 59 lines · Marek Vasut
On Wednesday, September 17, 2014 at 09:43:56 AM, Bo Shen wrote:
+CC Lukasz, this is his turf.
Quoted 55 lines
When download is ongoing, if the actual size of one transfer is not the same as
BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.So, improve the method to show the progress bar (print dot).
Signed-off-by Bo Shen <[email protected]>---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/usb/gadget/f_fastboot.cindex 7a1acb9..2f13bf0 100644drivers/usb/gadget/f_fastboot.c +1
-0@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f) static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = {.bLength =
USB_DT_ENDPOINT_SIZE,drivers/usb/gadget/f_fastboot.c +2
-2@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ;
Quoted 8 lines
Quoted 5 lines
drivers/usb/gadget/f_fastboot.c static void cb_download(struct usb_ep *ep, struct usb_request *req) · line 436
Quoted 1 line
drivers/usb/gadget/f_fastboot.c +1
-0+ num_of_dot =0 ;Make it a '
download_total' and log the total amount of bytes transferred please, that way it can be re-used for other purposes in the future ; for example for printing how much data were already transferred ;-)The
download_bytesrecord the total amount of bytes transferred. And thedownload_byteswill print after finishing transfer.
So why can this not be used to indicate the total progress ? Because the transfeer speed is variating too much ?
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
Hi Marek,
Quoted 69 lines · Marek Vasut
Quoted 68 lines · Bo Shen
Hi Marek,
Quoted 64 lines · Marek Vasut
On Wednesday, September 17, 2014 at 09:43:56 AM, Bo Shen wrote:
+CC Lukasz, this is his turf.
Quoted 50 lines
When download is ongoing, if the actual size of one transfer is not the same as
BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.So, improve the method to show the progress bar (print dot).
Signed-off-by Bo Shen <[email protected]>---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/usb/gadget/f_fastboot.cindex 7a1acb9..2f13bf0 100644drivers/usb/gadget/f_fastboot.c +1
-0@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f) static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = {.bLength =
USB_DT_ENDPOINT_SIZE,drivers/usb/gadget/f_fastboot.c +2
-2@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;drivers/usb/gadget/f_fastboot.c static void cb_download(struct usb_ep *ep, struct · line 438
Quoted 6 lines
drivers/usb/gadget/f_fastboot.c +1
-0@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ; + num_of_dot =0 ;Make it a '
download_total' and log the total amount of bytes transferred please, that way it can be re-used for other purposes in the future ; for example for printing how much data were already transferred ;-)
Quoted 5 lines
Quoted 2 lines
The
download_bytesrecord the total amount of bytes transferred. And thedownload_byteswill print after finishing transfer.So why can this not be used to indicate the total progress ? Because the transfeer speed is variating too much ?
As I described in the commit message. If the transfer length is not exactly the same as the request length, then the old method
"download_bytes % BYTES_PER_DOT"
won't be 0 anymore, so for the following transfer, it won't print dot anymore.
Best Regards,
Bo Shen
PATCH 1/1 usb: gadget: fastboot: improve download progress bar
Quoted 76 lines · Bo Shen
Hi Marek,
Quoted 73 lines · Marek Vasut
Quoted 71 lines · Bo Shen
Hi Marek,
Quoted 59 lines · Marek Vasut
On Wednesday, September 17, 2014 at 09:43:56 AM, Bo Shen wrote:
+CC Lukasz, this is his turf.
Quoted 55 lines
When download is ongoing, if the actual size of one transfer is not the same as
BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.So, improve the method to show the progress bar (print dot).
Signed-off-by Bo Shen <[email protected]>---
drivers/usb/gadget/f_fastboot.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/usb/gadget/f_fastboot.cindex 7a1acb9..2f13bf0 100644drivers/usb/gadget/f_fastboot.c +1
-0@@ -51,6 +51,7 @@ static inline struct f_fastboot *func_to_fastboot(struct usb_function *f) static struct f_fastboot *fastboot_func;static unsigned int download_size;static unsigned int download_bytes; +static unsigned int num_of_dot;static struct usb_endpoint_descriptor fs_ep_in = {.bLength =
USB_DT_ENDPOINT_SIZE,drivers/usb/gadget/f_fastboot.c +2
-2@@ -414,9 +415,10 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req) req->length = ep->maxpacket; } -if (download_bytes && !(download_bytes %BYTES_PER_DOT )) { +if (download_bytes && ((download_bytes /BYTES_PER_DOT ) > num_of_dot)) { + num_of_dot = download_bytes /BYTES_PER_DOT ;putc ('.' ); -if (!(download_bytes % (74 *BYTES_PER_DOT ))) +if (!(num_of_dot %74 ))putc ('\n' ); } req->actual =0 ;@@ -431,6 +433,7 @@ static void cb_download(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); download_size =simple_strtoul (cmd,NULL ,16 ); download_bytes =0 ;Quoted 6 lines
drivers/usb/gadget/f_fastboot.c static void cb_download(struct usb_ep *ep, struct usb_request *req) · line 436
Quoted 1 line
drivers/usb/gadget/f_fastboot.c +1
-0+ num_of_dot =0 ;Make it a '
download_total' and log the total amount of bytes transferred please, that way it can be re-used for other purposes in the future ; for example for printing how much data were already transferred ;-)The
download_bytesrecord the total amount of bytes transferred. And thedownload_byteswill print after finishing transfer.
Quoted 8 lines
Quoted 2 lines
So why can this not be used to indicate the total progress ? Because the transfeer speed is variating too much ?
As I described in the commit message. If the transfer length is not exactly the same as the request length, then the old method
"download_bytes%BYTES_PER_DOT"
won't be 0 anymore, so for the following transfer, it won't print dot anymore.
And can you not reset the "download_bytes" for each transfer ?
Maybe we're not even aligned on what "transfer" means, so we might want to sync on this word first. What does "transfer" mean in this case?