imx-drm coding style fixes
Subsystems (3)
PATCH 1/1 imx-drm coding style fixes
Hello,
I've fixed coding style issues in drivers/staging/imx-drm directory. This is a part of Eudyptula Challenge.
Rene Kolarik
Documentation/devicetree/bindings/arm/fsl.txt +4 -0
@@ -71,6 +71,10 @@ i.MX53 generic board Required root node properties: - compatible = "fsl,imx53"; +i.MX53 Television Encoder +Required root node properties: + - compatible = "fsl,imx53-tve"; + i.MX6q generic board Required root node properties: - compatible = "fsl,imx6q";
drivers/staging/imx-drm/imx-drm-core.c +2 -1
@@ -630,7 +630,8 @@ static int imx_drm_platform_probe(struct platform_device *pdev)continue ; } -component_match_add (&pdev->dev, &match, compare_of, remote); +component_match_add (&pdev->dev, &match, compare_of, + remote);of_node_put (remote); }of_node_put (port);
drivers/staging/imx-drm/imx-hdmi.c +1 -2
@@ -323,8 +323,7 @@ static unsigned int hdmi_compute_cts(unsigned int freq, unsigned long pixel_clk, }if (ratio ==100 )return cts; -else -return (cts * ratio) /100 ; +return (cts * ratio) /100 ; } static void hdmi_set_clk_regenerator(struct imx_hdmi *hdmi,
drivers/staging/imx-drm/imx-tve.c +5 -5
@@ -430,10 +430,9 @@ static long clk_tve_di_round_rate(struct clk_hw *hw, unsigned long rate, div = *prate / rate;if (div >=4 )return *prate /4 ; -else if (div >=2 ) +if (div >=2 )return *prate /2 ; -else -return *prate; +return *prate; } static int clk_tve_di_set_rate(struct clk_hw *hw, unsigned long rate,
@@ -538,7 +537,7 @@ static struct regmap_config tve_regmap_config = { .max_register = 0xdc, }; -static const char *imx_tve_modes[] = { +static const char *const imx_tve_modes[] = { [TVE_MODE_TVOUT ] ="tvout" , [TVE_MODE_VGA ] ="vga" , };
@@ -666,7 +665,8 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) ret =regmap_read (tve->regmap,TVE_COM_CONF_REG , &val);if (ret <0 ) { -dev_err (dev,"failed to read configuration register: %d\n" , ret); +dev_err (dev,"failed to read configuration register: %d\n" , + ret);return ret; }if (val !=0x00100000 ) {
drivers/staging/imx-drm/parallel-display.c +2 -1
@@ -228,7 +228,8 @@ static int imx_pd_bind(struct device *dev, struct device *master, void *data)else if (!strcmp (fmt,"bgr666" )) imxpd->interface_pix_fmt =V4L2_PIX_FMT_BGR666 ;else if (!strcmp (fmt,"lvds666" )) - imxpd->interface_pix_fmt =v4l2_fourcc ('L' ,'V' ,'D' ,'6' ); + imxpd->interface_pix_fmt =v4l2_fourcc ( +'L' ,'V' ,'D' ,'6' ); } panel_node =of_parse_phandle (np,"fsl,panel" ,0 );
Quoted 3 lines · Rene Kolarik
Hello,
I've fixed coding style issues in
drivers/staging/imx-drmdirectory. This is a part of Eudyptula Challenge.
Please submit your patches "inline" (look at /Documentation/SubmittingPatches section 7). Also, think about if it's worth seperating this patch into two or more since you are doing more than what you're saying in the description. Furthermore, your subject line is kind of wrong. Perhaps it should look something like this:
[PATCH] drivers: staging: imx-drm style cleanup (SubmittingPatches section 15)
Finally, you didn't mention what coding style issues you've fixed and these kind of patches are called clean-up patches.
Quoted 10 lines
Rene Kolarik
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Signature · 2 lines
thanks, Giedrius