Skip to contentSkip to conversation

BR2_DEPRECATED: update option label and help

PATCH New Gustavo Zacarias 3 participants 3 messages Sep 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 BR2_DEPRECATED: update option label and help

We should use positive logic (show things that are otherwise hidden...) for the help since it's what it does.
It also applies to more options than just packages alone, for example the AVR32 architecture so add an "options" label to it.

---
 Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Config.in +3 -2
index 14ff55b..b494fab 100644
@@ -301,9 +301,10 @@ config BR2_CCACHE_INITIAL_SETUP
 endif
 
 config BR2_DEPRECATED
-	bool "Show packages that are deprecated or obsolete"
+	bool "Show options and packages that are deprecated or obsolete"
 	help
-	  This option hides outdated/obsolete versions of packages.
+	  This option shows outdated/obsolete versions of packages and
+	  options that are hidden otherwise.
 
 if BR2_DEPRECATED
 
Signature · 1 line
1.8.5.5
#1 lore raw

PATCH 1/1 BR2_DEPRECATED: update option label and help

Gustavo, All,

On 2014-09-19 10:41 -0300, Gustavo Zacarias spake thusly:

Quoted 6 lines

We should use positive logic (show things that are otherwise hidden...) for the help since it's what it does.
It also applies to more options than just packages alone, for example the AVR32 architecture so add an "options" label to it.

Except for a small comment, below...

Quoted 9 lines
---
 Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Config.in +0 -0
index 14ff55b..b494fab 100644

Config.in config BR2_CCACHE_INITIAL_SETUP · line 307

Quoted 9 lines
Config.in +3 -2
@@ -301,9 +301,10 @@ config BR2_CCACHE_INITIAL_SETUP
 endif
 
 config BR2_DEPRECATED
-	bool "Show packages that are deprecated or obsolete"
+	bool "Show options and packages that are deprecated or obsolete"
 	help
-	  This option hides outdated/obsolete versions of packages.
+	  This option shows outdated/obsolete versions of packages and
+	  options that are hidden otherwise.

In English, adverbs are placed before the past participle, like you did your commit log: ... otherwise hidden.

Regards,
Yann E. MORIN.

Quoted 10 lines
Config.in +0 -0
 if BR2_DEPRECATED
 
Signature · 6 lines
1.8.5.5

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 BR2_DEPRECATED: update option label and help

In reply to Gustavo Zacarias
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

We should use positive logic (show things that are otherwise hidden...) for the help since it's what it does.
It also applies to more options than just packages alone, for example the AVR32 architecture so add an "options" label to it.

---
 Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Config.in +0 -0
index 14ff55b..b494fab 100644

Config.in config BR2_CCACHE_INITIAL_SETUP · line 307

Quoted 9 lines
Config.in +3 -2
@@ -301,9 +301,10 @@ config BR2_CCACHE_INITIAL_SETUP
 endif
 
 config BR2_DEPRECATED
-	bool "Show packages that are deprecated or obsolete"
+	bool "Show options and packages that are deprecated or obsolete"
 	help
-	  This option hides outdated/obsolete versions of packages.
+	  This option shows outdated/obsolete versions of packages and
+	  options that are hidden otherwise.

Committed with Yann's feedback, thanks.

Signature · 1 line
Bye, Peter Korsgaard