Skip to contentSkip to conversation

package/openvmtools: do not force -I/usr/include in CPPFLAGS

PATCH New Yann E. MORIN 3 participants 5 messages Sep 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/openvmtools: do not force -I/usr/include in CPPFLAGS

Fixes:

    http://autobuild.buildroot.net/results/447/4473d8a99ffec1fde491d172520e86ae1e69fae7/
---
 .../openvmtools-04-dont-force-cppflags.patch       | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/openvmtools/openvmtools-04-dont-force-cppflags.patch
package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +22 -0
new file mode 100644
index 0000000..8f904b1
@@ -0,0 +1,22 @@
+m4: do not force -I/usr/include in CPPFLAGS
+
+This is so horribly broken for cross-compilation. :-(
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+
+diff -durN openvmtools-9.4.6-1770165.orig/m4/vmtools.m4 openvmtools-9.4.6-1770165/m4/vmtools.m4
+--- openvmtools-9.4.6-1770165.orig/m4/vmtools.m4	2014-07-02 00:21:14.000000000 +0200
++++ openvmtools-9.4.6-1770165/m4/vmtools.m4	2014-09-21 12:39:15.901659888 +0200
+@@ -281,10 +281,10 @@
+       if test "$os" = freebsd; then
+          CUSTOM_$1_CPPFLAGS="-I/usr/local/include"
+       else
+-         CUSTOM_$1_CPPFLAGS="-I/usr/include"
++         CUSTOM_$1_CPPFLAGS=" "
+       fi
+       if test -n "$2"; then
+-         CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
++         : CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
+       fi
+    fi
+ ])
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/openvmtools: do not force -I/usr/include in CPPFLAGS

Hi Yann,

I was just looking for the same problem at
http://autobuild.buildroot.net/results/2e0/2e0c15fded8b1043e916c34a795da0a06c8534fb/build-end.log
. Thanks for the fix - the patch number should become 05 I think if applied committed after http://patchwork.ozlabs.org/patch/389396/ .

BR,
Karoly

Quoted 52 lines · Yann E. MORIN

Fixes:

http://autobuild.buildroot.net/results/447/4473d8a99ffec1fde491d172520e86ae1e69fae7/

---
 .../openvmtools-04-dont-force-cppflags.patch       | 22
++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644

package/openvmtools/openvmtools-04-dont-force-cppflags.patch

package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +7 -0
new file mode 100644
index 0000000..8f904b1
@@ -0,0 +1,22 @@
+m4: do not force -I/usr/include in CPPFLAGS
+
+This is so horribly broken for cross-compilation. :-(
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+
+diff -durN openvmtools-9.4.6-1770165.orig/m4/vmtools.m4

openvmtools-9.4.6-1770165/m4/vmtools.m4
+--- openvmtools-9.4.6-1770165.orig/m4/vmtools.m4 2014-07-02
00:21:14.000000000 +0200
++++ openvmtools-9.4.6-1770165/m4/vmtools.m4 2014-09-21
12:39:15.901659888 +0200
+@@ -281,10 +281,10 @@

package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +12 -1
+       if test "$os" = freebsd; then
+          CUSTOM_$1_CPPFLAGS="-I/usr/local/include"
+       else
+-         CUSTOM_$1_CPPFLAGS="-I/usr/include"
++         CUSTOM_$1_CPPFLAGS=" "
+       fi
+       if test -n "$2"; then
+-         CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
++         : CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
+       fi
+    fi
+ ])
--

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 5 lines
?dv,
KK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140921/6bbd3f9a/attachment.html>
#2 lore raw

PATCH 1/1 package/openvmtools: do not force -I/usr/include in CPPFLAGS

K?roly, All,

On 2014-09-21 14:40 +0200, K?roly Kasza spake thusly:

Quoted 2 lines

I was just looking for the same problem at
http://autobuild.buildroot.net/results/2e0/2e0c15fded8b1043e916c34a795da0a06c8534fb/build-end.log

Yup, same problem. I just looked at the frontpage of the autobuilders, so missed that one.

Quoted 2 lines

. Thanks for the fix - the patch number should become 05 I think if applied committed after http://patchwork.ozlabs.org/patch/389396/ .

Yes.

Whoever commits this fix may rename whichever he applies last. ;-)

Regards,
Yann E. MORIN.

Quoted 65 lines

BR,
Karoly

Quoted 52 lines · Yann E. MORIN

Fixes:

http://autobuild.buildroot.net/results/447/4473d8a99ffec1fde491d172520e86ae1e69fae7/

---
 .../openvmtools-04-dont-force-cppflags.patch       | 22
++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644

package/openvmtools/openvmtools-04-dont-force-cppflags.patch

package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +7 -0
new file mode 100644
index 0000000..8f904b1
@@ -0,0 +1,22 @@
+m4: do not force -I/usr/include in CPPFLAGS
+
+This is so horribly broken for cross-compilation. :-(
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+
+diff -durN openvmtools-9.4.6-1770165.orig/m4/vmtools.m4

openvmtools-9.4.6-1770165/m4/vmtools.m4
+--- openvmtools-9.4.6-1770165.orig/m4/vmtools.m4 2014-07-02
00:21:14.000000000 +0200
++++ openvmtools-9.4.6-1770165/m4/vmtools.m4 2014-09-21
12:39:15.901659888 +0200
+@@ -281,10 +281,10 @@

package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +12 -1
+       if test "$os" = freebsd; then
+          CUSTOM_$1_CPPFLAGS="-I/usr/local/include"
+       else
+-         CUSTOM_$1_CPPFLAGS="-I/usr/include"
++         CUSTOM_$1_CPPFLAGS=" "
+       fi
+       if test -n "$2"; then
+-         CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
++         : CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
+       fi
+    fi
+ ])
--

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 2 lines
?dv,
KK
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/openvmtools: do not force -I/usr/include in CPPFLAGS

In reply to Yann E. MORIN

All,

On 2014-09-21 13:01 +0200, Yann E. MORIN spake thusly:

Quoted 20 lines

Fixes:

    http://autobuild.buildroot.net/results/447/4473d8a99ffec1fde491d172520e86ae1e69fae7/
---
 .../openvmtools-04-dont-force-cppflags.patch       | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/openvmtools/openvmtools-04-dont-force-cppflags.patch
package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +5 -0
new file mode 100644
index 0000000..8f904b1
@@ -0,0 +1,22 @@
+m4: do not force -I/usr/include in CPPFLAGS
+
+This is so horribly broken for cross-compilation. :-(
+
+Signed-off-by: "Yann E. MORIN" <[email protected]>

package/openvmtools/openvmtools-04-dont-force-cppflags.patch line 15

Quoted 10 lines
package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +10 -0
+
+diff -durN openvmtools-9.4.6-1770165.orig/m4/vmtools.m4 openvmtools-9.4.6-1770165/m4/vmtools.m4
+--- openvmtools-9.4.6-1770165.orig/m4/vmtools.m4	2014-07-02 00:21:14.000000000 +0200
++++ openvmtools-9.4.6-1770165/m4/vmtools.m4	2014-09-21 12:39:15.901659888 +0200
+@@ -281,10 +281,10 @@
+       if test "$os" = freebsd; then
+          CUSTOM_$1_CPPFLAGS="-I/usr/local/include"
+       else
+-         CUSTOM_$1_CPPFLAGS="-I/usr/include"
++         CUSTOM_$1_CPPFLAGS=" "

I suddenly realise it is not obvious why I left a space in there.

That's on purpose, otherwise ./configure gets awfully confused, and does not even try to find PAM headers and simply bails out before even doing anything to detect PAM.

I can re-spin with a better commit log (and/or a comment in the patch) if needed. Or it can be added by the committer. ;-)

Regards,
Yann E. MORIN.

Quoted 10 lines
package/openvmtools/openvmtools-04-dont-force-cppflags.patch new file +7 -0
+       fi
+       if test -n "$2"; then
+-         CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
++         : CUSTOM_$1_CPPFLAGS="${CUSTOM_$1_CPPFLAGS}/$2"
+       fi
+    fi
+ ])
Signature · 1 line
1.9.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/openvmtools: do not force -I/usr/include in CPPFLAGS

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 8 lines · Yann E. MORIN

Fixes:

    http://autobuild.buildroot.net/results/447/4473d8a99ffec1fde491d172520e86ae1e69fae7/
---
 .../openvmtools-04-dont-force-cppflags.patch       | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/openvmtools/openvmtools-04-dont-force-cppflags.patch

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com