Skip to contentSkip to conversation

ipmiutil: new package

PATCH Superseded David Bachelart 2 participants 5 messages Sep 18, 2014 – Oct 6, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmiutil: new package

---
 package/Config.in            |    1 +
 package/ipmiutil/Config.in   |   15 +++++++++++++++
 package/ipmiutil/ipmiutil.mk |   15 +++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/ipmiutil/Config.in
 create mode 100644 package/ipmiutil/ipmiutil.mk
package/Config.in +1 -0
index 73ba86a..3eafabb 100644
@@ -322,6 +322,7 @@ endif
 	source "package/intel-microcode/Config.in"
 	source "package/iostat/Config.in"
 	source "package/ipmitool/Config.in"
+	source "package/ipmiutil/Config.in"
 	source "package/irda-utils/Config.in"
 	source "package/iucode-tool/Config.in"
 	source "package/kbd/Config.in"
package/ipmiutil/Config.in new file +15 -0
new file mode 100644
index 0000000..29d6e26
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IPMIUTIL
+	bool "ipmiutil"
+	depends on BR2_TOOLCHAIN_HAS_SSP
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_ZLIB
+	help
+	  The ipmiutil package provides easy-to-use utilities to view the SEL,
+	  perform an IPMI chassis reset, set up the IPMI LAN and Platform Event Filter
+	  entries to allow SNMP alerts, Serial-Over-LAN console, event daemon, and
+	  other IPMI tasks.
+
+	  http://ipmiutil.sourceforge.net/
+
+comment "ipmiutil needs a toolchain w/ ssp"
+	depends on !BR2_TOOLCHAIN_HAS_SSP
package/ipmiutil/ipmiutil.mk new file +15 -0
new file mode 100644
index 0000000..9bf7325
@@ -0,0 +1,15 @@
+################################################################################
+#
+# ipmiutil
+#
+################################################################################
+
+IPMIUTIL_VERSION = 2.9.4
+IPMIUTIL_SITE = http://sourceforge.net/projects/ipmiutil/files/
+
+IPMIUTIL_DEPENDENCIES = openssl zlib
+
+IPMIUTIL_LICENSE = BSD-2c
+IPMIUTIL_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ipmiutil: new package

Dear David Bachelart,

package/ipmiutil/Config.in line 3

Quoted 9 lines · David Bachelart
package/ipmiutil/Config.in new file +3 -0
new file mode 100644
index 0000000..29d6e26
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IPMIUTIL
+	bool "ipmiutil"
+	depends on BR2_TOOLCHAIN_HAS_SSP

Did you test if it works with an internal toolchain (i.e a toolchain built by Buildroot) that has SSP enabled? Apparently, the package forcefully links against -lssp. But I'm not sure if a libssp library is built when SSP is enabled in the internal toolchain, because we use the SSP support from the C library and not from the compiler. A verification would be good, or even better, an improvement to ipmiutil to make SSP support optional.

package/ipmiutil/Config.in line 5

Quoted 2 lines
package/ipmiutil/Config.in new file +2 -0
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_ZLIB

This dependency on zlib seems unnecessary: I didn't see anything in ipmiutil that references zlib directly. Did I miss it?

Also, the code contains call to fork(), so your package should depend on BR2_USE_MMU. And the code uses threads, so it should depend on thread support.

Try to make sure that your package builds fine with the following toolchain configurations:

- http://autobuild.buildroot.org/toolchains/configs/br-arm-basic.config
- http://autobuild.buildroot.org/toolchains/configs/br-arm-full.config
- http://autobuild.buildroot.org/toolchains/configs/bfin-linux-uclibc.config
- http://autobuild.buildroot.org/toolchains/configs/bfin-uclinux.config

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ipmiutil: new package

In reply to David Bachelart

Dear David Bachelart,

Any news about this patch? I made some comments on September, 21st, but unless I missed you haven't resent a new version. Do you intend to do so in the near future?

Thanks a lot for your contribution,

Thomas

Quoted 64 lines · David Bachelart
---
 package/Config.in            |    1 +
 package/ipmiutil/Config.in   |   15 +++++++++++++++
 package/ipmiutil/ipmiutil.mk |   15 +++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/ipmiutil/Config.in
 create mode 100644 package/ipmiutil/ipmiutil.mk
package/Config.in +1 -0
index 73ba86a..3eafabb 100644
@@ -322,6 +322,7 @@ endif
 	source "package/intel-microcode/Config.in"
 	source "package/iostat/Config.in"
 	source "package/ipmitool/Config.in"
+	source "package/ipmiutil/Config.in"
 	source "package/irda-utils/Config.in"
 	source "package/iucode-tool/Config.in"
 	source "package/kbd/Config.in"
package/ipmiutil/Config.in new file +15 -0
new file mode 100644
index 0000000..29d6e26
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IPMIUTIL
+	bool "ipmiutil"
+	depends on BR2_TOOLCHAIN_HAS_SSP
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_ZLIB
+	help
+	  The ipmiutil package provides easy-to-use utilities to view the SEL,
+	  perform an IPMI chassis reset, set up the IPMI LAN and Platform Event Filter
+	  entries to allow SNMP alerts, Serial-Over-LAN console, event daemon, and
+	  other IPMI tasks.
+
+	  http://ipmiutil.sourceforge.net/
+
+comment "ipmiutil needs a toolchain w/ ssp"
+	depends on !BR2_TOOLCHAIN_HAS_SSP
package/ipmiutil/ipmiutil.mk new file +15 -0
new file mode 100644
index 0000000..9bf7325
@@ -0,0 +1,15 @@
+################################################################################
+#
+# ipmiutil
+#
+################################################################################
+
+IPMIUTIL_VERSION = 2.9.4
+IPMIUTIL_SITE = http://sourceforge.net/projects/ipmiutil/files/
+
+IPMIUTIL_DEPENDENCIES = openssl zlib
+
+IPMIUTIL_LICENSE = BSD-2c
+IPMIUTIL_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 ipmiutil: new package

Hi Thomas,

Yes, I do... I'm in a rush, I hope I'll submit a new patch in a few days/weeks.

Regards,
David

2014-10-05 23:47 GMT+02:00 Thomas Petazzoni <
[email protected]>:

Quoted 79 lines

Dear David Bachelart,

Any news about this patch? I made some comments on September, 21st, but unless I missed you haven't resent a new version. Do you intend to do so in the near future?

Thanks a lot for your contribution,

Thomas

Quoted 28 lines · David Bachelart
---
 package/Config.in            |    1 +
 package/ipmiutil/Config.in   |   15 +++++++++++++++
 package/ipmiutil/ipmiutil.mk |   15 +++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/ipmiutil/Config.in
 create mode 100644 package/ipmiutil/ipmiutil.mk
package/Config.in +1 -0
index 73ba86a..3eafabb 100644
@@ -322,6 +322,7 @@ endif
      source "package/intel-microcode/Config.in"
      source "package/iostat/Config.in"
      source "package/ipmitool/Config.in"
+     source "package/ipmiutil/Config.in"
      source "package/irda-utils/Config.in"
      source "package/iucode-tool/Config.in"
      source "package/kbd/Config.in"
package/ipmiutil/Config.in new file +0 -0
new file mode 100644
index 0000000..29d6e26

package/ipmiutil/Config.in line 7

Quoted 7 lines
package/ipmiutil/Config.in new file +7 -0
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IPMIUTIL
+     bool "ipmiutil"
+     depends on BR2_TOOLCHAIN_HAS_SSP
+     select BR2_PACKAGE_OPENSSL
+     select BR2_PACKAGE_ZLIB
+     help
+       The ipmiutil package provides easy-to-use utilities to view the

SEL,

package/ipmiutil/Config.in line 8

Quoted 1 line
package/ipmiutil/Config.in new file +1 -0
+       perform an IPMI chassis reset, set up the IPMI LAN and Platform

Event Filter

package/ipmiutil/Config.in line 9

Quoted 1 line
package/ipmiutil/Config.in new file +1 -0
+       entries to allow SNMP alerts, Serial-Over-LAN console, event

daemon, and

package/ipmiutil/ipmiutil.mk

Quoted 13 lines
package/ipmiutil/Config.in new file +6 -0
+       other IPMI tasks.
+
+       http://ipmiutil.sourceforge.net/
+
+comment "ipmiutil needs a toolchain w/ ssp"
+     depends on !BR2_TOOLCHAIN_HAS_SSP
package/ipmiutil/ipmiutil.mk new file +0 -0
new file mode 100644
index 0000000..9bf7325
@@ -0,0 +1,15 @@

+################################################################################

package/ipmiutil/ipmiutil.mk line 4

Quoted 4 lines
package/ipmiutil/ipmiutil.mk new file +3 -0
+#
+# ipmiutil
+#

+################################################################################

Quoted 9 lines
package/ipmiutil/ipmiutil.mk new file +9 -0
+
+IPMIUTIL_VERSION = 2.9.4
+IPMIUTIL_SITE = http://sourceforge.net/projects/ipmiutil/files/
+
+IPMIUTIL_DEPENDENCIES = openssl zlib
+
+IPMIUTIL_LICENSE = BSD-2c
+IPMIUTIL_LICENSE_FILES = COPYING
+
Quoted 9 lines

package/ipmiutil/ipmiutil.mk line 15

Quoted 1 line
package/ipmiutil/ipmiutil.mk new file +1 -0
+$(eval $(autotools-package))

--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141006/8d66a37e/attachment.html>

#4 lore raw

PATCH 1/1 ipmiutil: new package

Dear David Bachelart,

Quoted 2 lines · David Bachelart

Yes, I do... I'm in a rush, I hope I'll submit a new patch in a few days/weeks.

Sure, I'll mark your patch as "Changes requested" in patch then. So, please remember to resend a new version, as we will not send another reminder since the patch will no longer be in our TODO-list of patches to review.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com