net: optimise inet_proto_csum_replace4()
Subsystems (2)
PATCH 1/1 net: optimise inet_proto_csum_replace4()
csum_partial() is a generic function which is not optimised for small fixed length calculations, and its use requires to store "from" and "to" values in memory while we already have them available in registers. This also has impact, especially on RISC processors. In the same spirit as the change done by Eric Dumazet on csum_replace2(), this patch rewrites inet_proto_csum_replace4() taking into account RFC1624.
I spotted during a NATted tcp transfert that csum_partial() is one of top 5 consuming functions (around 8%), and the second user of csum_partial() is inet_proto_csum_replace4().
---
--
net/core/utils.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
net/core/utils.c +5 -7
@@ -306,16 +306,14 @@ EXPORT_SYMBOL(in6_pton);void inet_proto_csum_replace4 (__sum16 *sum,struct sk_buff *skb,__be32 from,__be32 to,int pseudohdr) { -__be32 diff[] = { ~from, to };if (skb->ip_summed !=CHECKSUM_PARTIAL ) { - *sum =csum_fold (csum_partial (diff,sizeof (diff), - ~csum_unfold (*sum))); + *sum =csum_fold (csum_add (csum_sub (~csum_unfold (*sum), from), + to));if (skb->ip_summed ==CHECKSUM_COMPLETE && pseudohdr) - skb->csum = ~csum_partial (diff,sizeof (diff), - ~skb->csum); + skb->csum = ~csum_add (csum_sub (~(skb->csum), from), to); }else if (pseudohdr) - *sum = ~csum_fold (csum_partial (diff,sizeof (diff), -csum_unfold (*sum))); + *sum = ~csum_fold (csum_add (csum_sub (csum_unfold (*sum), from), + to)); }EXPORT_SYMBOL (inet_proto_csum_replace4);
Signature · 1 line
2.1.0
Quoted 7 lines · Christophe Leroy
csum_partial()is a generic function which is not optimised for small fixed length calculations, and its use requires to store "from" and "to" values in memory while we already have them available in registers. This also has impact, especially on RISC processors. In the same spirit as the change done by Eric Dumazet oncsum_replace2(), this patch rewritesinet_proto_csum_replace4()taking into account RFC1624.
Quoted 6 lines
I spotted during a NATted tcp transfert that
csum_partial()is one of top 5 consuming functions (around 8%), and the second user ofcsum_partial()isinet_proto_csum_replace4().Signed-off-by Christophe Leroy <[email protected]>
Thanks !
David Miller
maintainerFrom: Christophe Leroy <[email protected]>
Date: Tue, 23 Sep 2014 10:54:37 +0200 (CEST)
Quoted 7 lines
csum_partial()is a generic function which is not optimised for small fixed length calculations, and its use requires to store "from" and "to" values in memory while we already have them available in registers. This also has impact, especially on RISC processors. In the same spirit as the change done by Eric Dumazet oncsum_replace2(), this patch rewritesinet_proto_csum_replace4()taking into account RFC1624.
Quoted 5 lines
I spotted during a NATted tcp transfert that
csum_partial()is one of top 5 consuming functions (around 8%), and the second user ofcsum_partial()isinet_proto_csum_replace4().Signed-off-by Christophe Leroy <[email protected]>
Also applied, thanks Christophe.