Skip to contentSkip to conversation

usb: gadget: fastboot: improve download progress bar

PATCH New Bo Shen 3 participants 3 messages Sep 19, 2014 – Sep 24, 2014 USB

lore
Share & tools
lore

Bo Shen

author
#0 lore raw

PATCH v2 1/1 usb: gadget: fastboot: improve download progress bar

When download is ongoing, if the actual size of one transfer is not the same as BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.

So, improve the method to show the progress bar (print dot).

---
Changes in v2:
- get rid of the global variable.
- avoid the dot print after showing the total download length.

 drivers/usb/gadget/f_fastboot.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/usb/gadget/f_fastboot.c +9 -5
index 7a1acb9..dda9d1c 100644
@@ -380,6 +380,7 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req)
 	unsigned int transfer_size = download_size - download_bytes;
 	const unsigned char *buffer = req->buf;
 	unsigned int buffer_size = req->actual;
+	unsigned int pre_dot_num, now_dot_num;
 
 	if (req->status != 0) {
 		printf("Bad status: %d\n", req->status);
@@ -392,7 +393,15 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req)
 	memcpy((void *)CONFIG_USB_FASTBOOT_BUF_ADDR + download_bytes,
 	       buffer, transfer_size);
 
+	pre_dot_num = download_bytes / BYTES_PER_DOT;
 	download_bytes += transfer_size;
+	now_dot_num = download_bytes / BYTES_PER_DOT;
+
+	if (pre_dot_num != now_dot_num) {
+		putc('.');
+		if (!(now_dot_num % 74))
+			putc('\n');
+	}
 
 	/* Check if transfer is done */
 	if (download_bytes >= download_size) {
@@ -414,11 +423,6 @@ static void rx_handler_dl_image(struct usb_ep *ep, struct usb_request *req)
 			req->length = ep->maxpacket;
 	}
 
-	if (download_bytes && !(download_bytes % BYTES_PER_DOT)) {
-		putc('.');
-		if (!(download_bytes % (74 * BYTES_PER_DOT)))
-			putc('\n');
-	}
 	req->actual = 0;
 	usb_ep_queue(ep, req, 0);
 }
Signature · 1 line
2.1.0.24.g4109c28
#1 lore raw

PATCH v2 1/1 usb: gadget: fastboot: improve download progress bar

Quoted 8 lines · Bo Shen

When download is ongoing, if the actual size of one transfer is not the same as BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.

So, improve the method to show the progress bar (print dot).

I didn't test it, but it looks OK:

Best regards,
Marek Vasut

#2 lore raw

PATCH v2 1/1 usb: gadget: fastboot: improve download progress bar

In reply to Bo Shen

Hi Bo,

Quoted 6 lines

When download is ongoing, if the actual size of one transfer is not the same as BTYES_PER_DOT, which will cause the dot won't print anymore. Then it will let the user thinking it is stuck, actually it is transfering without dot printed.

So, improve the method to show the progress bar (print dot).

Applied to u-boot-dfu tree

Thanks for support!

Quoted 50 lines

---
Changes in v2:
- get rid of the global variable.
- avoid the dot print after showing the total download length.

 drivers/usb/gadget/f_fastboot.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
(quoted diff) +0 -0

b/drivers/usb/gadget/f_fastboot.c index 7a1acb9..dda9d1c 100644

drivers/usb/gadget/f_fastboot.c +0 -0
@@ -380,6 +380,7 @@ static void rx_handler_dl_image(struct usb_ep
 *ep, struct usb_request *req) unsigned int transfer_size =

download_size - download_bytes; const unsigned char *buffer = req->buf; unsigned int buffer_size = req->actual;

drivers/usb/gadget/f_fastboot.c +9 -5
+	unsigned int pre_dot_num, now_dot_num;
 
 	if (req->status != 0) {
 		printf("Bad status: %d\n", req->status);
@@ -392,7 +393,15 @@ static void rx_handler_dl_image(struct usb_ep
 *ep, struct usb_request *req) memcpy((void
 *)CONFIG_USB_FASTBOOT_BUF_ADDR + download_bytes, buffer,
 transfer_size); 
+	pre_dot_num = download_bytes / BYTES_PER_DOT;
 	download_bytes += transfer_size;
+	now_dot_num = download_bytes / BYTES_PER_DOT;
+
+	if (pre_dot_num != now_dot_num) {
+		putc('.');
+		if (!(now_dot_num % 74))
+			putc('\n');
+	}
 
 	/* Check if transfer is done */
 	if (download_bytes >= download_size) {
@@ -414,11 +423,6 @@ static void rx_handler_dl_image(struct usb_ep
 *ep, struct usb_request *req) req->length = ep->maxpacket;
 	}
 
-	if (download_bytes && !(download_bytes % BYTES_PER_DOT)) {
-		putc('.');
-		if (!(download_bytes % (74 * BYTES_PER_DOT)))
-			putc('\n');
-	}
 	req->actual = 0;
 	usb_ep_queue(ep, req, 0);
 }
Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group