kernel: acctc.c: Fixed else if not generally userful after a break or return warning.
PATCH 1/1 kernel: acctc.c: Fixed else if not generally userful after a break or return warning.
Fixed a coding style issue.
Signed-off-by Elshad Mustafayev <[email protected]>
--- kernel/acct.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/acct.c +1 -2
@@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value)if (exp >MAXEXP2 ) {/* Overflow. Return largest representable number instead. */ return (1ul << (MANTSIZE2 +EXPSIZE2 -1 )) -1 ; - }else { -return (value & (MAXFRACT2 >>1 )) | (exp << (MANTSIZE2 -1 )); } + return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1)); }#endif
Signature · 1 line
1.9.1
Quoted 12 lines · Elshad Mustafayev
Fixed a coding style issue.
Signed-off-by Elshad Mustafayev <[email protected]>--- kernel/acct.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)kernel/acct.c +0
-0
kernel/acct.c static comp2_t encode_comp2_t(u64 value) · line 380
Quoted 7 lines
kernel/acct.c +1
-2@@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value)if (exp >MAXEXP2 ) {/* Overflow. Return largest representable number instead. */ return (1ul << (MANTSIZE2 +EXPSIZE2 -1 )) -1 ; - }else { -return (value & (MAXFRACT2 >>1 )) | (exp << (MANTSIZE2 -1 )); } +return (value & (MAXFRACT2 >>1 )) | (exp << (MANTSIZE2 -1 ));
Just what makes the replacement easier to follow?
if (foo) return bar; else return baz; is no less idiomatic than if (foo) return bar; return baz;
Al, really annoyed by how the words "coding style issue" are getting used as a magic incantation...