Skip to contentSkip to conversation

NFS: Fabricate fscache server index key correctly

PATCH New David Howells 1 participant 1 message Sep 25, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NFS: Fabricate fscache server index key correctly

When fabricating a server index key for fscache, we should clear the index key buffer before starting to fill it in, not in the middle.

---

 fs/nfs/fscache-index.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/nfs/fscache-index.c +1 -2
index 7cf2c4699b08..777b055063f6 100644
@@ -74,11 +74,10 @@ static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
 	struct nfs_server_key *key = buffer;
 	uint16_t len = sizeof(struct nfs_server_key);
 
+	memset(key, 0, len);
 	key->nfsversion = clp->rpc_ops->version;
 	key->family = clp->cl_addr.ss_family;
 
-	memset(key, 0, len);
-
 	switch (clp->cl_addr.ss_family) {
 	case AF_INET:
 		key->port = sin->sin_port;