Skip to contentSkip to conversation

whitespace cleanups

PATCH In review Pavel Machek 3 participants 7 messages Jul 19, 2014 – Sep 25, 2014

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 whitespace cleanups

Whitespace cleanups.

Signed-off-by Pavel Machek <[email protected]>
disk/part.c +4 -4
index baceb19..ecc5e7e 100644
@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 
 #endif /* any CONFIG_..._PARTITION */
 
-void print_part (block_dev_desc_t * dev_desc)
+void print_part(block_dev_desc_t * dev_desc)
 {
 
 		switch (dev_desc->part_type) {

@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
 
 #endif /* HAVE_BLOCK_DEVICE */
 
-int get_partition_info(block_dev_desc_t *dev_desc, int part
-					, disk_partition_t *info)
+int get_partition_info(block_dev_desc_t *dev_desc, int part,
+		       disk_partition_t *info)
 {
 #ifdef HAVE_BLOCK_DEVICE
 

@@ -511,7 +511,7 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
 	disk_partition_t tmpinfo;
 
 	/*
-	 * Special-case a psuedo block device "hostfs", to allow access to the
+	 * Special-case a pseudo block device "hostfs", to allow access to the
 	 * host's own filesystem.
 	 */
 	if (0 == strcmp(ifname, "hostfs")) {
include/altera.h +1 -1
index 0327a1b..ae5f7ee 100644
@@ -26,7 +26,7 @@ typedef enum {			/* typedef Altera_Family */
 	min_altera_type,	/* insert all new types after this */
 	Altera_ACEX1K,		/* ACEX1K Family */
 	Altera_CYC2,		/* CYCLONII Family */
-	Altera_StratixII,	/* StratixII Familiy */
+	Altera_StratixII,	/* StratixII Family */
 /* Add new models here */
 	max_altera_type		/* insert all new types before this */
 } Altera_Family;		/* end, typedef Altera_Family */
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

PATCH 1/1 whitespace cleanups

Hello Pavel,

Quoted 18 lines · Pavel Machek

Whitespace cleanups.

Signed-off-by Pavel Machek <[email protected]>
disk/part.c +1 -1
index baceb19..ecc5e7e 100644
@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 
  #endif /* any CONFIG_..._PARTITION */
 
-void print_part (block_dev_desc_t * dev_desc)
+void print_part(block_dev_desc_t * dev_desc)
  {
 
  		switch (dev_desc->part_type) {

disk/part.c void print_part (block_dev_desc_t * dev_desc) · line 381

Quoted 1 line
disk/part.c +0 -0
@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)

checkpatch says: ;)

ERROR: "foo * bar" should be "foo *bar"
#26: FILE: disk/part.c:336:
+void print_part(block_dev_desc_t * dev_desc)

Regards,
Jeroen

author
#2 lore raw

PATCH 1/1 whitespace cleanups

Quoted 21 lines · Jeroen Hofstee

Hello Pavel,

disk/part.c void print_part (block_dev_desc_t * dev_desc)

Quoted 15 lines · Pavel Machek

Whitespace cleanups.

Signed-off-by Pavel Machek <[email protected]>
disk/part.c +1 -1
index baceb19..ecc5e7e 100644
@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 #endif /* any CONFIG_..._PARTITION */
-void print_part (block_dev_desc_t * dev_desc)
+void print_part(block_dev_desc_t * dev_desc)
 {
 		switch (dev_desc->part_type) {

@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)

checkpatch says: ;)

Quoted 3 lines

ERROR: "foo * bar" should be "foo *bar"
#26: FILE: disk/part.c:336:
+void print_part(block_dev_desc_t * dev_desc)

Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm not adding the error.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

PATCH 1/1 whitespace cleanups

Hello Pavel,

Quoted 21 lines · Pavel Machek
Quoted 20 lines · Jeroen Hofstee

Hello Pavel,

disk/part.c void print_part (block_dev_desc_t * dev_desc)

Quoted 15 lines · Pavel Machek

Whitespace cleanups.

Signed-off-by Pavel Machek <[email protected]>
disk/part.c +1 -1
index baceb19..ecc5e7e 100644
@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
  #endif /* any CONFIG_..._PARTITION */
-void print_part (block_dev_desc_t * dev_desc)
+void print_part(block_dev_desc_t * dev_desc)
  {
  		switch (dev_desc->part_type) {

@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)

checkpatch says: ;)

Quoted 6 lines
Quoted 3 lines

ERROR: "foo * bar" should be "foo *bar"
#26: FILE: disk/part.c:336:
+void print_part(block_dev_desc_t * dev_desc)

Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm not adding the error.

This is only about a line you touch. And patch submissions should be checked by checkpatch or at least mention why you don't comply.

Regards,
Jeroen

author
#4 lore raw

PATCH 1/1 cleanup disk/part.c whitespace

Cleanup disk/part.c

Signed-off-by Pavel Machek <[email protected]>
disk/part.c +5 -4
index ecc5e7e..cfd77b0 100644
@@ -133,7 +133,7 @@ typedef lbaint_t lba512_t;
  * Overflowless variant of (block_count * mul_by / div_by)
  * when div_by > mul_by
  */
-static lba512_t lba512_muldiv (lba512_t block_count, lba512_t mul_by, lba512_t div_by)
+static lba512_t lba512_muldiv(lba512_t block_count, lba512_t mul_by, lba512_t div_by)
 {
 	lba512_t bc_quot, bc_rem;
 

@@ -215,7 +215,8 @@ void dev_print (block_dev_desc_t *dev_desc)
 
 		lba512 = (lba * (dev_desc->blksz/512));
 		/* round to 1 digit */
-		mb = lba512_muldiv(lba512, 10, 2048);	/* 2048 = (1024 * 1024) / 512 MB */
+		/* 2048 = (1024 * 1024) / 512 MB */
+		mb = lba512_muldiv(lba512, 10, 2048);
 
 		mb_quot	= mb / 10;
 		mb_rem	= mb - (10 * mb_quot);

@@ -248,7 +249,7 @@ void dev_print (block_dev_desc_t *dev_desc)
 
 #ifdef HAVE_BLOCK_DEVICE
 
-void init_part (block_dev_desc_t * dev_desc)
+void init_part(block_dev_desc_t *dev_desc)
 {
 #ifdef CONFIG_ISO_PARTITION
 	if (test_part_iso(dev_desc) == 0) {

@@ -295,7 +296,7 @@ void init_part (block_dev_desc_t * dev_desc)
 	defined(CONFIG_AMIGA_PARTITION) || \
 	defined(CONFIG_EFI_PARTITION)
 
-static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
+static void print_part_header(const char *type, block_dev_desc_t *dev_desc)
 {
 	puts ("\nPartition Map for ");
 	switch (dev_desc->if_type) {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

[U-Boot] cleanup disk/part.c whitespace

Quoted 3 lines · Pavel Machek

Cleanup disk/part.c

Signed-off-by Pavel Machek <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140925/0e5db9fa/attachment.pgp>
#6 lore raw
In reply to Pavel Machek
Quoted 3 lines · Pavel Machek

Whitespace cleanups.

Signed-off-by Pavel Machek <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140722/5154ad87/attachment.pgp>