Skip to contentSkip to conversation

checkpatch: remove unnecessary + after {8,8}

PATCH In review Marek Vasut 2 participants 2 messages Sep 23, 2014 – Sep 25, 2014 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: remove unnecessary + after {8,8}

From: Joe Perches <[email protected]>

Pick the following commit from Linux kernel:
commit 66cb4ee0e52ca721f609fd5eec16187189ae5fda

Author: Joe Perches <[email protected]>
Date:   Wed Sep 10 09:40:47 2014 +1000

checkpatch: remove unnecessary + after {8,8}

There's a useless "+" use that needs to be removed as perl 5.20 emits a "Useless use of greediness modifier '+'" message each time it's hit.

---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/checkpatch.pl +1 -1
index 3fed5e4..74db2e2 100755
@@ -2148,7 +2148,7 @@ sub process {
 				"please, no space before tabs\n" . $herevet) &&
 			    $fix) {
 				while ($fixed[$linenr - 1] =~
-					   s/(^\+.*) {8,8}+\t/$1\t\t/) {}
+					   s/(^\+.*) {8,8}\t/$1\t\t/) {}
 				while ($fixed[$linenr - 1] =~
 					   s/(^\+.*) +\t/$1\t/) {}
 			}
Signature · 1 line
2.1.0
#1 lore raw
Quoted 7 lines · Marek Vasut

From: Joe Perches <[email protected]>

Pick the following commit from Linux kernel:
commit 66cb4ee0e52ca721f609fd5eec16187189ae5fda

Author: Joe Perches <[email protected]>
Date:   Wed Sep 10 09:40:47 2014 +1000
Quoted 7 lines

checkpatch: remove unnecessary + after {8,8}

There's a useless "+" use that needs to be removed as perl 5.20 emits a "Useless use of greediness modifier '+'" message each time it's hit.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140925/f80dd7f3/attachment.pgp>