Skip to contentSkip to conversation

spi: bcm53xx: Fix module dependency

PATCH Applied Axel Lin 3 participants 4 messages Sep 26, 2014 SPI

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 spi: bcm53xx: Fix module dependency

config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA. This fixes below build error:
ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

---
 drivers/spi/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/Kconfig +2 -0
index dc10453..84e7c9e 100644
@@ -116,6 +116,8 @@ config SPI_AU1550
 config SPI_BCM53XX
 	tristate "Broadcom BCM53xx SPI controller"
 	depends on ARCH_BCM_5301X
+	depends on BCMA_POSSIBLE
+	select BCMA
 	help
           Enable support for the SPI controller on Broadcom BCM53xx ARM SoCs.
 
Signature · 8 lines
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#1 lore raw

PATCH 2/2 spi: bcm53xx: Add missing module information

Mainly to fix missing MODULE_LICENSE.
Also add MODULE_DESCRIPTION and MODULE_AUTHOR.

---
 drivers/spi/spi-bcm53xx.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/spi/spi-bcm53xx.c +4 -0
index e6600f7..17b34cb 100644
@@ -293,3 +293,7 @@ static void __exit bcm53xxspi_module_exit(void)
 
 module_init(bcm53xxspi_module_init);
 module_exit(bcm53xxspi_module_exit);
+
+MODULE_DESCRIPTION("Broadcom BCM53xx SPI Controller driver");
+MODULE_AUTHOR("Rafał Miłecki <[email protected]>");
+MODULE_LICENSE("GPL");
Signature · 8 lines
1.9.1



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Axel Lin
Quoted 4 lines · Axel Lin

config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA. This fixes below build error:
ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

Thanks for your patches, look fine!
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#3 lore raw
In reply to Axel Lin
Quoted 4 lines · Axel Lin

config SPI_BCM53XX needs to depend on BCMA_POSSIBLE and select BCMA. This fixes below build error:
ERROR: "bcma_driver_unregister" [drivers/spi/spi-bcm53xx.ko] undefined!
ERROR: "__bcma_driver_register" [drivers/spi/spi-bcm53xx.ko] undefined!

Applied both, thanks.