Skip to contentSkip to conversation

linux-next: build failure after merge of the akpm-current tree

PATCH New Stephen Rothwell 2 participants 2 messages Sep 26, 2014 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi Andrew,

After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

In file included from arch/powerpc/kernel/asm-offsets.c:16:0:
include/linux/signal.h: In function 'sigisemptyset':
include/linux/signal.h:79:3: error: implicit declaration of function 'BUILD_BUG' [-Werror=implicit-function-declaration]
BUILD_BUG();
^

Caused by commit 7e52cdba7e69 ("signal: use BUILD_BUG() instead of _NSIG_WORDS_is_unsupported_size()").

See Rule 1 in Documentation/SubmitChecklist.

Thanks to Guenter for the heads up.

I have added the following patch for today (hopefully it does not cause more problems).

From: Stephen Rothwell <[email protected]>
Date: Fri, 26 Sep 2014 20:08:12 +1000
Subject: [PATCH] signal.h: using BUILD_BUG requires including bug.h

---
 include/linux/signal.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/signal.h +1 -0
index 14acfd59ed1b..ab1e0392b5ac 100644
@@ -2,6 +2,7 @@
 #define _LINUX_SIGNAL_H
 
 #include <linux/list.h>
+#include <linux/bug.h>
 #include <uapi/linux/signal.h>
 
 struct task_struct;
Signature · 5 lines
2.1.1

-- 
Cheers,
Stephen Rothwell                    [email protected]
#1 lore raw

PATCH 1/1 signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.fix

From: Stephen Rothwell <[email protected]>

Fixes signal-use-build_bug-instead-of-_nsig_words_is_unsupported_size.patch which caused the build failure on powerpc.

Add missing "include <linux/bug.h>" which defines BUILD_BUG() used by that patch.

---
 include/linux/signal.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/signal.h +1 -0
index 14acfd5..ab1e039 100644
@@ -2,6 +2,7 @@
 #define _LINUX_SIGNAL_H
 
 #include <linux/list.h>
+#include <linux/bug.h>
 #include <uapi/linux/signal.h>
 
 struct task_struct;
Signature · 1 line
1.5.5.1