package: libarchive: allow building as host package
PATCH 1/1 package: libarchive: allow building as host package
It works correctly without any changes, so just enable it.
--- package/libarchive/libarchive.mk | 1 + 1 file changed, 1 insertion(+)
package/libarchive/libarchive.mk +1 -0
@@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib endif $(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
2.1.0
PATCH 1/1 package: libarchive: allow building as host package
Guido, All,
What is the rationale for building it as a host-package?
libarchive provides a library, but we have no in-tree host-package that uses libarchive.
On 2014-09-26 20:23 -0300, Guido Mart?nez spake thusly:
Quoted 1 line
It works correctly without any changes, so just enable it.
This should not be part of the commit log. The commit log should just explain why you enable host-libarchive, especially because we have no in-tree user.
Regards,
Yann E. MORIN.
Quoted 21 lines
Signed-off-by Guido Mart?nez <[email protected]>--- package/libarchive/libarchive.mk | 1 + 1 file changed, 1 insertion(+)package/libarchive/libarchive.mk +1
-0@@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib endif $(eval $(autotools-package)) +$(eval $(host-autotools-package))Signature · 6 lines
2.1.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package: libarchive: allow building as host package
Hi Yann,
Quoted 6 lines · Yann E. MORIN
Guido, All,
What is the rationale for building it as a host-package?
libarchive provides a library, but we have no in-tree host-package that uses libarchive.
I have a custom tool that uses it, and I wasn't aware that host packages were only enabled as needed. It makes a lot sense now that I think about that, so please ignore this patch.
Sorry!
Quoted 40 lines
On 2014-09-26 20:23 -0300, Guido Mart?nez spake thusly:
Quoted 1 line
It works correctly without any changes, so just enable it.
This should not be part of the commit log. The commit log should just explain why you enable host-libarchive, especially because we have no in-tree user.
Regards,
Yann E. MORIN.Quoted 21 lines
Signed-off-by Guido Mart?nez <[email protected]>--- package/libarchive/libarchive.mk | 1 + 1 file changed, 1 insertion(+)package/libarchive/libarchive.mk +1
-0@@ -69,3 +69,4 @@ LIBARCHIVE_CONF_OPT += --without-zlib endif $(eval $(autotools-package)) +$(eval $(host-autotools-package))Signature · 6 lines
2.1.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildrootSignature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
Signature · 2 lines
Guido Mart?nez, VanguardiaSur www.vanguardiasur.com.ar
PATCH 1/1 package: libarchive: allow building as host package
Guido, All,
On 2014-09-27 09:28 -0300, Guido Mart?nez spake thusly:
Quoted 10 lines · Yann E. MORIN
Quoted 6 lines
Guido, All,
What is the rationale for building it as a host-package?
libarchive provides a library, but we have no in-tree host-package that uses libarchive.
I have a custom tool that uses it, and I wasn't aware that host packages were only enabled as needed. It makes a lot sense now that I think about that, so please ignore this patch.
For the records, repeating here what I said on IRC:
I never said we do not want it, just that you have to justify it. We tend to be conservative about adding host-packages, and only add programs, and libraries those programs need. Adding a host library that has no in-tree user should thus be realy justified.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package: libarchive: allow building as host package
In reply to Yann E. MORINHi Yann, all,
Quoted 6 lines · Yann E. MORIN
Guido, All,
What is the rationale for building it as a host-package?
libarchive provides a library, but we have no in-tree host-package that uses libarchive.
That's right and wrong at the same time! ;-)
There is at least 1 host package that can depend (among other things) on libarchive: cmake.
But it seems that for this we currently rely on the host-system libarchive or the one coming within the cmake sources.
My 2 cents. :-)
Regards,
Signature · 1 line
Samuel
PATCH 1/1 package: libarchive: allow building as host package
In reply to Guido MartínezDear Guido Mart?nez,
Quoted 6 lines · Guido Mart?nez
It works correctly without any changes, so just enable it.
Signed-off-by Guido Mart?nez <[email protected]>--- package/libarchive/libarchive.mk | 1 + 1 file changed, 1 insertion(+)
As was explained during the review, since there is no in-tree user for this host package, we rejected the patch. If another package needs it some day, then of course we'll accept such a patch.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com