wireless: Remove unnessary write over of register 11 in rt2800lib.c
Subsystems (3)
PATCH 1/1 wireless: Remove unnessary write over of register 11 in rt2800lib.c
This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr).
--- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/wireless/rt2x00/rt2800lib.c +0 -2
@@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,if (rf->channel <=14 ) {rt2800_rfcsr_write (rt2x00dev,10 ,0x90 ); -/* FIXME: RF11 owerwrite ? */ -rt2800_rfcsr_write (rt2x00dev,11 ,0x4A );rt2800_rfcsr_write (rt2x00dev,12 ,0x52 );rt2800_rfcsr_write (rt2x00dev,13 ,0x42 );rt2800_rfcsr_write (rt2x00dev,22 ,0x40 );
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function,
rt2800_config_channelas we are already writing a correct value to the register withrt2800_rfcsr_write(rt2x00dev,11.rfcsr).
What make you sure that overwrite is unnecessary ?
Quoted 11 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-)drivers/net/wireless/rt2x00/rt2800lib.c +0
-0
drivers/net/wireless/rt2x00/rt2800lib.c static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, · line 2791
Quoted 5 lines
drivers/net/wireless/rt2x00/rt2800lib.c +0
-2@@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,if (rf->channel <=14 ) {rt2800_rfcsr_write (rt2x00dev,10 ,0x90 ); -/* FIXME: RF11 owerwrite ? */ -rt2800_rfcsr_write (rt2x00dev,11 ,0x4A );
We need a prove that remove is correct, i.e. some reference to vendor code or spec that current writing register twice with different values is wrong.
NACK for the patch.
Stanislaw
Or someone with the hardware has to test and check that...
Quoted 28 lines · Stanislaw Gruszka
Quoted 3 lines · Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function,
rt2800_config_channelas we are already writing a correct value to the register withrt2800_rfcsr_write(rt2x00dev,11.rfcsr).What make you sure that overwrite is unnecessary ?
Quoted 12 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-)drivers/net/wireless/rt2x00/rt2800lib.c +0
-0drivers/net/wireless/rt2x00/rt2800lib.c static void rt2800_config_channel_rf55xx(struct · line 2792
Quoted 6 lines
drivers/net/wireless/rt2x00/rt2800lib.c +0
-2@@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, if (rf->channel <= 14) {rt2800_rfcsr_write (rt2x00dev,10 ,0x90 ); -/* FIXME: RF11 owerwrite ? */ -rt2800_rfcsr_write (rt2x00dev,11 ,0x4A );We need a prove that remove is correct, i.e. some reference to vendor code or spec that current writing register twice with different values is wrong.
Quoted 8 lines
NACK for the patch.
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 1 line · Denis Kirjanov
Or someone with the hardware has to test and check that...
... on all possible combinations of channel, bandwidth, signal strength, modulation type, ...
Stanislaw
A message that is not in the archive (sent off-list or not yet received): CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 39 lines · Denis Kirjanov
Or someone with the hardware has to test and check that...
Quoted 36 lines · Stanislaw Gruszka
Quoted 3 lines · Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function,
rt2800_config_channelas we are already writing a correct value to the register withrt2800_rfcsr_write(rt2x00dev,11.rfcsr).What make you sure that overwrite is unnecessary ?
Quoted 12 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-)drivers/net/wireless/rt2x00/rt2800lib.c +0
-0drivers/net/wireless/rt2x00/rt2800lib.c static void rt2800_config_channel_rf55xx(struct · line 2792
Quoted 6 lines
drivers/net/wireless/rt2x00/rt2800lib.c +0
-2@@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, if (rf->channel <= 14) {rt2800_rfcsr_write (rt2x00dev,10 ,0x90 ); -/* FIXME: RF11 owerwrite ? */ -rt2800_rfcsr_write (rt2x00dev,11 ,0x4A );We need a prove that remove is correct, i.e. some reference to vendor code or spec that current writing register twice with different values is wrong.
NACK for the patch.
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
I will see if I can either find the vendor code or spec in order to do this correctly. Thanks for the reply through.
Nick
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 42 lines · nick
Quoted 39 lines · Denis Kirjanov
Or someone with the hardware has to test and check that...
Quoted 36 lines · Stanislaw Gruszka
Quoted 3 lines · Nicholas Krause
This removes the unnecessary overwrite of register 11 in the function,
rt2800_config_channelas we are already writing a correct value to the register withrt2800_rfcsr_write(rt2x00dev,11.rfcsr).What make you sure that overwrite is unnecessary ?
Quoted 12 lines
Signed-off-by Nicholas Krause <[email protected]>--- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-)drivers/net/wireless/rt2x00/rt2800lib.c +0
-0drivers/net/wireless/rt2x00/rt2800lib.c static void rt2800_config_channel_rf55xx(struct · line 2792
Quoted 6 lines
drivers/net/wireless/rt2x00/rt2800lib.c +0
-2@@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, if (rf->channel <= 14) {rt2800_rfcsr_write (rt2x00dev,10 ,0x90 ); -/* FIXME: RF11 owerwrite ? */ -rt2800_rfcsr_write (rt2x00dev,11 ,0x4A );We need a prove that remove is correct, i.e. some reference to vendor code or spec that current writing register twice with different values is wrong.
NACK for the patch.
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines
I will see if I can either find the vendor code or spec in order to do this correctly. Thanks for the reply through.
Nick
In addition someone banned me from the list yet again. I am getting rather annoyed with this and can someone please remove it.
Cheers Nick