Skip to contentSkip to conversation

dma: imx-sdma: fix another incorrect __init annotation

PATCH Applied Arnd Bergmann 2 participants 2 messages Sep 26, 2014 – Sep 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma: imx-sdma: fix another incorrect __init annotation

In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on sdma_probe()"), Mark found an extraneous __init label and fixed it.

However, he missed another one, because now we get this other warning:

WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware() The function sdma_probe() references
the function __init sdma_get_firmware().

Same reasoning as the last time, the function may get called at runtime, so it can't be __init.

drivers/dma/imx-sdma.c +1 -1
index 52ce1d21154c..88afc48c2ca7 100644
@@ -1334,7 +1334,7 @@ err_firmware:
 	release_firmware(fw);
 }
 
-static int __init sdma_get_firmware(struct sdma_engine *sdma,
+static int sdma_get_firmware(struct sdma_engine *sdma,
 		const char *fw_name)
 {
 	int ret;
Applied
#1 lore raw
Quoted 12 lines · Arnd Bergmann

In e34b731faa7d1 ("dma: imx-sdma: Remove spurious __init annotation on sdma_probe()"), Mark found an extraneous __init label and fixed it.

However, he missed another one, because now we get this other warning:

WARNING: drivers/dma/imx-sdma.o(.text+0x3bb4): Section mismatch in reference from the function sdma_probe() to the function .init.text:sdma_get_firmware() The function sdma_probe() references
the function __init sdma_get_firmware().

Same reasoning as the last time, the function may get called at runtime, so it can't be __init.

Applied, thanks

Signature · 1 line
~Vinod
Quoted 20 lines
drivers/dma/imx-sdma.c +1 -2
index 52ce1d21154c..88afc48c2ca7 100644
@@ -1334,7 +1334,7 @@ err_firmware:
 	release_firmware(fw);
 }
 
-static int __init sdma_get_firmware(struct sdma_engine *sdma,
+static int sdma_get_firmware(struct sdma_engine *sdma,
 		const char *fw_name)
 {
 	int ret;
 
--

To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html