Skip to contentSkip to conversation

arm: Remove read of issue in sa1111.c in sa1111_resume

PATCH In review Nicholas Krause 3 participants 5 messages Sep 28, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: Remove read of issue in sa1111.c in sa1111_resume

This removes the FIXME message and issue with reading in this driver before resuming in the function, sa1111_resume.

---
 arch/arm/common/sa1111.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/common/sa1111.c +0 -2
index e57d7e5..0c4b9a9 100644
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
 
 	/*
 	 * Ensure that the SA1111 is still here.
-	 * FIXME: shouldn't do this here.
 	 */
-	id = sa1111_readl(sachip->base + SA1111_SKID);
 	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
 		__sa1111_remove(sachip);
 		platform_set_drvdata(dev, NULL);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Nicholas Krause

This removes the FIXME message and issue with reading in this driver before resuming in the function, sa1111_resume.

You need to explain why this makes any sense.
Hint: it doesn't.

Quoted 20 lines
---
 arch/arm/common/sa1111.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/common/sa1111.c +0 -2
index e57d7e5..0c4b9a9 100644
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
 
 	/*
 	 * Ensure that the SA1111 is still here.
-	 * FIXME: shouldn't do this here.
 	 */
-	id = sa1111_readl(sachip->base + SA1111_SKID);
 	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
 		__sa1111_remove(sachip);
 		platform_set_drvdata(dev, NULL);
Signature · 1 line
~Randy
author
#2 lore raw
Quoted 18 lines · Randy Dunlap
Quoted 2 lines · Nicholas Krause

This removes the FIXME message and issue with reading in this driver before resuming in the function, sa1111_resume.

You need to explain why this makes any sense.
Hint: it doesn't.

Quoted 11 lines
---
 arch/arm/common/sa1111.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/common/sa1111.c +0 -0
index e57d7e5..0c4b9a9 100644
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
 
Quoted 11 lines

arch/arm/common/sa1111.c static int sa1111_resume(struct platform_device *dev) · line 956

Quoted 9 lines
arch/arm/common/sa1111.c +0 -2
 	/*
 	 * Ensure that the SA1111 is still here.
-	 * FIXME: shouldn't do this here.
 	 */
-	id = sa1111_readl(sachip->base + SA1111_SKID);
 	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
 		__sa1111_remove(sachip);
 		platform_set_drvdata(dev, NULL);

Thanks for the reply Randy. I was wondering if was what the FIX ME meant if it meant something else please let me known.
Sorry,
Nick

#3 lore raw
In reply to Nicholas Krause
Quoted 13 lines · Nicholas Krause

This removes the FIXME message and issue with reading in this driver before resuming in the function, sa1111_resume.

---
 arch/arm/common/sa1111.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/common/sa1111.c +0 -0
index e57d7e5..0c4b9a9 100644

arch/arm/common/sa1111.c static int sa1111_resume(struct platform_device *dev) · line 955

Quoted 6 lines
arch/arm/common/sa1111.c +0 -2
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
 
 	/*
 	 * Ensure that the SA1111 is still here.
-	 * FIXME: shouldn't do this here.
 	 */
-	id = sa1111_readl(sachip->base + SA1111_SKID);

do you understand the effect of removing this??? what is the value of id in the next part of the code?

thanks
sudip

Quoted 11 lines
arch/arm/common/sa1111.c +0 -0
 	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
 		__sa1111_remove(sachip);
 		platform_set_drvdata(dev, NULL);
Signature · 7 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
author
#4 lore raw

PATCH 1/1 arm: Remove read of issue in sa1111.c in sa1111_resume

Quoted 24 lines · Sudip Mukherjee
Quoted 13 lines · Nicholas Krause

This removes the FIXME message and issue with reading in this driver before resuming in the function, sa1111_resume.

---
 arch/arm/common/sa1111.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/common/sa1111.c +0 -0
index e57d7e5..0c4b9a9 100644

arch/arm/common/sa1111.c static int sa1111_resume(struct platform_device *dev) · line 955

Quoted 6 lines
arch/arm/common/sa1111.c +0 -2
@@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
 
 	/*
 	 * Ensure that the SA1111 is still here.
-	 * FIXME: shouldn't do this here.
 	 */
-	id = sa1111_readl(sachip->base + SA1111_SKID);

do you understand the effect of removing this??? what is the value of id in the next part of the code?

Quoted 13 lines

thanks
sudip

Quoted 11 lines
arch/arm/common/sa1111.c +0 -0
 	if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
 		__sa1111_remove(sachip);
 		platform_set_drvdata(dev, NULL);
Signature · 7 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

We will set the driver data to NULL and therefore may cause a bug due to NULL data. Nick