Skip to contentSkip to conversation

XFS development tree branch, xfs-trans-recover-cleanup, created. v3.16-11801-gb818cca

XFS updates [email protected] 1 participant 1 message Sep 29, 2014

lore
Share & tools
lore

[email protected]

author Reviewed-by Christoph Hellwig Reviewed-by Christoph Hellwig Reviewed-by Christoph Hellwig Reviewed-by Christoph Hellwig Reviewed-by Christoph Hellwig
#0 lore raw

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree".

The branch, xfs-trans-recover-cleanup has been created

        at  b818cca1976d1a01754033ac08724e05d07cce8f (commit)

- Log ----------------------------------------------------------------- commit b818cca1976d1a01754033ac08724e05d07cce8f

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 29 09:45:54 2014 +1000

xfs: refactor recovery transaction start handling

Rework the transaction lookup and allocation code in xlog_recovery_process_ophdr() to fold two related call-once helper functions into a single helper. Then fold in all the XLOG_START_TRANS logic to that helper to clean up the remaining logic in xlog_recovery_process_ophdr().

commit 76560669868d3b4d650d91d9bf467a8d81171766

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 29 09:45:42 2014 +1000

xfs: reorganise transaction recovery item code

The code for managing transactions anf the items for recovery is spread across 3 different locations in the file. Move them all together so that it is easy to read the code without needing to jump long distances in the file.

commit 88b863db97a18a04c90ebd57d84e1b7863114dcb

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 29 09:45:32 2014 +1000

xfs: fix double free in xlog_recover_commit_trans

When an error occurs during buffer submission in xlog_recover_commit_trans(), we free the trans structure twice. Fix it by only freeing the structure in the caller regardless of the success or failure of the function.

commit e9131e50f9d0a632e3011d73f283ba69be0cc682

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 29 09:45:18 2014 +1000

xfs: recovery of XLOG_UNMOUNT_TRANS leaks memory

The XLOG_UNMOUNT_TRANS case skips the transaction, despite the fact an unmount record is always in a standalone transaction. Hence whenever we come across one of these we need to free the transaction structure associated with it as there is no commit record that follows it.

commit eeb1168810d8a140f6834f8c4975f7bb3277d790

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 29 09:45:03 2014 +1000

xfs: refactor xlog_recover_process_data()

Clean up xlog_recover_process_data() structure in preparation for fixing the allocation and freeing context of the transaction being recovered.

-----------------------------------------------------------------------

hooks/post-receive

Signature · 6 lines
XFS development tree

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs