Hexagon: Remove useless select of NO_IOPORT_MAP
PATCH 1/1 Hexagon: Remove useless select of NO_IOPORT_MAP
Hexagon's primary Kconfig entry has a select for NO_IOPORT_MAP. But because hexagon never defines a Kconfig symbol NO_IOPORT_MAP this select is a nop. It can be removed.
Perhaps hexagon should add its own Kconfig entry for NO_IOPORT_MAP and have it default to 'y'. But since no one apparently had any problems with HAS_IOPORT_MAP defaulting to 'y' on hexagon, as it currently does, that is unlikely.
---
Tested by playing with arch/hexagon/configs/comet_defconfig. After "make oldconfig" the .config contains CONFIG_HAS_IOPORT_MAP=y both before and after this patch, as is expected.
Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_HEXAGON=y
I have no idea why. Did I botch my test?
arch/hexagon/Kconfig | 1 - 1 file changed, 1 deletion(-)
arch/hexagon/Kconfig +0 -1
@@ -19,7 +19,6 @@ config HEXAGON select GENERIC_IRQ_SHOW select HAVE_ARCH_KGDB select HAVE_ARCH_TRACEHOOK - select NO_IOPORT_MAP select GENERIC_IOMAP select GENERIC_SMP_IDLE_THREAD select STACKTRACE_SUPPORT
Signature · 1 line
1.9.3
Quoted 5 lines · Paul Bolle
Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_HEXAGON=yI have no idea why. Did I botch my test?
Apparently I did. Retested using next-20140925. There's no difference in the .config file before and after the patch. That's a good thing! This select really is useless.
Paul Bolle
Quoted 39 lines · Paul Bolle
Hexagon's primary
Kconfigentry has a select forNO_IOPORT_MAP. But because hexagon never defines aKconfigsymbolNO_IOPORT_MAPthis select is a nop. It can be removed.Perhaps hexagon should add its own
Kconfigentry forNO_IOPORT_MAPand have it default to 'y'. But since no one apparently had any problems withHAS_IOPORT_MAPdefaulting to 'y' on hexagon, as it currently does, that is unlikely.Signed-off-by Paul Bolle <[email protected]>---
Tested by playing witharch/hexagon/configs/comet_defconfig. After "make oldconfig" the .config containsCONFIG_HAS_IOPORT_MAP=yboth before and after this patch, as is expected.Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_HEXAGON=yI have no idea why. Did I botch my test?
arch/hexagon/Kconfig | 1 - 1 file changed, 1 deletion(-)arch/hexagon/Kconfig +0
-1@@ -19,7 +19,6 @@ config HEXAGON select GENERIC_IRQ_SHOW select HAVE_ARCH_KGDB select HAVE_ARCH_TRACEHOOK - select NO_IOPORT_MAP select GENERIC_IOMAP select GENERIC_SMP_IDLE_THREAD select STACKTRACE_SUPPORTSignature · 1 line
1.9.3
There seemed to be a convoluted history behind the ioport options, but yes this is no longer needed/doesn't actually do anything. Thanks!
Signature · 3 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation