Skip to contentSkip to conversation

drivers/net/phy/icplus.c delete reason

U-Boot Dvorkin Dmitry 3 participants 3 messages Sep 30, 2014

lore
Share & tools
lore
#0 lore raw

Hello Masahiro Yamada!

4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver for a frequently used and cheap IP101A/G phy. Is there are better alternative PHY driver in U-Boot for this device? If not, could you patch it back?

#1 lore raw

Dear Dmitry,

Quoted 5 lines · In message <[email protected]> you wrote:

4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver for a frequently used and cheap IP101A/G phy. Is there are better alternative PHY driver in U-Boot for this device? If not, could you patch it back?

The commit message is pretty explicit about the reason:

commit 368b4d2b49bbbf379d9334747fbbd2aaaafe4356

Author: Masahiro Yamada <[email protected]>
Date:   Mon Aug 4 08:11:37 2014 +0900

drivers: net: remove dead drivers

The following configs are not defined at all:

- CONFIG_INCA_IP_SWITCH
- CONFIG_PBL2800_ETHER
- CONFIG_PHY_ICPLUS

There is/was not a single board configuration in mainline U-Boot which defined CONFIG_PHY_ICPLUS, i. e. the driver was just dead, unused code.

So the PHY may be "frequently used and cheap", but the driver for it has never been used in mainline, so we finally got rid of the dead weight.

I can see no reason to adding it back - this can be easily done if someone wants to actually use this driver, i. e. for example if you submit a boad configuration which references it.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's when they say 2 + 2 = 5 that I begin to argue."    - Eric Pepke
#2 lore raw
In reply to Dvorkin Dmitry

Hi Dvorkin,

Quoted 3 lines · On Tue, 30 Sep 2014 11:14:41 +0400 Dvorkin Dmitry <[email protected]> wrote:

Hello Masahiro Yamada!

4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver for a frequently used and cheap IP101A/G phy. Is there are better alternative PHY driver in U-Boot for this device? If not, could you patch it back?

I assume you are mentioning commit 368b4d2b49bb (drivers: net: remove dead drivers).

I have no idea if the latest U-Boot code has an alternative PHY driver.

I am not willing to send the patch because I have no interest in re-adding drivers I am not using.

If necessary for you, please feel free to send a patch to get it back. (Please make sure there exists at least one board enabling the driver. This is not my way, but the community's way.)

Best Regards
Masahiro Yamada