Skip to contentSkip to conversation

aesbs-core.S_shipped?

DISCUSSION Christoph Hellwig 2 participants 4 messages Sep 30, 2014 – Oct 6, 2014

lore
Share & tools
lore
#0 lore raw

Hi Ard,

can you explain me why arch/arm/crypto/aesbs-core.S_shipped is a _shipped file? I can't find any reason why it should be, it's a normal .S file in every way as far as I can tell.

#1 lore raw
Quoted 5 lines · Christoph Hellwig

Hi Ard,

can you explain me why arch/arm/crypto/aesbs-core.S_shipped is a _shipped file? I can't find any reason why it should be, it's a normal .S file in every way as far as I can tell.

It is generated by aesbs-core.pl, and Russell preferred including it as a _shipped file rather than generating it from the perl script on each build. (Note that the Perl script is kept in sync with OpenSSL, i.e., the goal is to be able to generate the kernel .S and the OpenSSL userland .S from the same script)

Signature · 1 line
Ard.
#2 lore raw
Quoted 9 lines · Ard Biesheuvel
Quoted 3 lines

can you explain me why arch/arm/crypto/aesbs-core.S_shipped is a _shipped file? I can't find any reason why it should be, it's a normal .S file in every way as far as I can tell.

It is generated by aesbs-core.pl, and Russell preferred including it as a _shipped file rather than generating it from the perl script on each build. (Note that the Perl script is kept in sync with OpenSSL, i.e., the goal is to be able to generate the kernel .S and the OpenSSL userland .S from the same script)

Thanks for the explanation. Can you update the script so that it inserts a comment explaining how the file was generated into it?

Also to satisfy the GPL you need to include a copy of aesbs-core.pl in the kernel tree. I only did a quick find -name aesbs-core.pl that didn't find any results, so if it's named slightly differently feel free to discard this second comment.

#3 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Ard Biesheuvel
Quoted 3 lines

can you explain me why arch/arm/crypto/aesbs-core.S_shipped is a _shipped file? I can't find any reason why it should be, it's a normal .S file in every way as far as I can tell.

It is generated by aesbs-core.pl, and Russell preferred including it as a _shipped file rather than generating it from the perl script on each build. (Note that the Perl script is kept in sync with OpenSSL, i.e., the goal is to be able to generate the kernel .S and the OpenSSL userland .S from the same script)

Quoted 7 lines

Thanks for the explanation. Can you update the script so that it inserts a comment explaining how the file was generated into it?

Also to satisfy the GPL you need to include a copy of aesbs-core.pl in the kernel tree. I only did a quick find -name aesbs-core.pl that didn't find any results, so if it's named slightly differently feel free to discard this second comment.

Apologies. It is called bsaes-armv7.pl, which is the name it goes by in the OpenSSL tree. (In the OpenSSL build, the .S is generated during build time)

Signature · 1 line
Ard.