Skip to contentSkip to conversation

staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

PATCH In review Karthik Nayak 3 participants 3 messages Sep 30, 2014 – Oct 8, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

1. WARNING: else is not generally useful after a break or return

2. WARNING: quoted string split across lines

3. WARNING: break quoted strings at a space character

---
 drivers/staging/bcm/InterfaceIdleMode.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/staging/bcm/InterfaceIdleMode.c +5 -6
index c84ee49..9a77a98 100644
@@ -188,10 +188,9 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
 			5000);
 		if (status)
 			return status;
-		else
-			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
-				IDLE_MODE, DBG_LVL_ALL,
-				"NOB Sent down :%d", lenwritten);
+		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
+			IDLE_MODE, DBG_LVL_ALL,
+			"NOB Sent down :%d", lenwritten);
 
 		/* mdelay(25); */
 
@@ -211,8 +210,8 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
 		else
 			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
 				IDLE_MODE, DBG_LVL_ALL,
-				"Number of completed iteration to"
-				"read chip-id :%lu", itr);
+				"Number of completed iteration to read chip-id :%lu",
+					itr);
 
 		status = wrmalt(Adapter, SW_ABORT_IDLEMODE_LOC,
 				&Pattern, sizeof(status));
Signature · 1 line
2.1.0
#1 lore raw
Quoted 8 lines · Karthik Nayak

1. WARNING: else is not generally useful after a break or return

2. WARNING: quoted string split across lines

3. WARNING: break quoted strings at a space character

---

Hi again,

You probably wanted to send this patch to the maintainer of this driver, instead of me. I suggest you re-run scripts/getmaintainer.pl on the patch.

Cheers,

Mark

maintainer
#2 lore raw
In reply to Karthik Nayak
Quoted 10 lines · Karthik Nayak

1. WARNING: else is not generally useful after a break or return

2. WARNING: quoted string split across lines

3. WARNING: break quoted strings at a space character

---
 drivers/staging/bcm/InterfaceIdleMode.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Doesn't apply to my tree :(