Skip to contentSkip to conversation

valgrind: allow building on more ARM systems

PATCH New Mike Williams 3 participants 5 messages Oct 1, 2014

lore
Share & tools
lore

Mike Williams

author
#0 lore raw

PATCH 1/1 valgrind: allow building on more ARM systems

Signed-off-by Mike Williams <[email protected]>
---
 package/valgrind/Config.in   | 7 ++++---
 package/valgrind/valgrind.mk | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
package/valgrind/Config.in +4 -3
index fd5649b..253555b 100644
@@ -1,8 +1,9 @@
 config BR2_PACKAGE_VALGRIND
 	bool "valgrind"
-	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
-		   BR2_mipsel || BR2_mips64 || BR2_mips64el
+	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a5 || \
+		   BR2_cortex_a7 || BR2_cortex_a8 || BR2_cortex_a9 || \
+		   BR2_cortex_a12 || BR2_cortex_a15 || BR2_powerpc || \
+		   BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
 	help
 	  Tool for debugging and profiling Linux programs.
package/valgrind/valgrind.mk +1 -1
index 24d0290..8bea031 100644
@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
 # not. Therefore, we adjust the host tuple to specify we're on
 # ARMv7. The valgrind package is guaranteed, through Config.in, to
 # only be selected on Cortex A8 and Cortex A9 platforms.
-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
 VALGRIND_CONF_OPT += \
 	--host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))
 endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 valgrind: allow building on more ARM systems

Dear Mike Williams,

Quoted 5 lines · Mike Williams
Signed-off-by Mike Williams <[email protected]>
---
 package/valgrind/Config.in   | 7 ++++---
 package/valgrind/valgrind.mk | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)
Reviewed-by Thomas Petazzoni <[email protected]>
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 valgrind: allow building on more ARM systems

In reply to Mike Williams

Mike Williams <[email protected]> schreef:

Quoted 35 lines
Signed-off-by Mike Williams <[email protected]>

---
package/valgrind/Config.in | 7 ++++---
package/valgrind/valgrind.mk | 2 +-

2 files changed, 5 insertions(+), 4 deletions(-)
package/valgrind/Config.in +0 -0
index fd5649b..253555b 100644
@@ -1,8 +1,9 @@

config BR2_PACKAGE_VALGRIND
bool "valgrind"

package/valgrind/Config.in +4 -3
-	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
-		   BR2_mipsel || BR2_mips64 || BR2_mips64el
+	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a5 || \
+		   BR2_cortex_a7 || BR2_cortex_a8 || BR2_cortex_a9 || \
+		   BR2_cortex_a12 || BR2_cortex_a15 || BR2_powerpc || \
+		   BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el

help
Tool for debugging and profiling Linux programs.

package/valgrind/valgrind.mk +1 -1
index 24d0290..8bea031 100644
@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
 # not. Therefore, we adjust the host tuple to specify we're on
 # ARMv7. The valgrind package is guaranteed, through Config.in, to
 # only be selected on Cortex A8 and Cortex A9 platforms.
-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
 VALGRIND_CONF_OPT += \
 	--host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))
Quoted 1 line

endif

In fact, mips64+n32 abi is not supported, so I think
this should be reflected too. I guess the same applies to the the le variant...

#3 lore raw

PATCH 1/1 valgrind: allow building on more ARM systems

Dear Thomas De Schampheleire,

Quoted 9 lines · Thomas De Schampheleire
Quoted 9 lines
package/valgrind/valgrind.mk +0 -1
index 24d0290..8bea031 100644
@@ -17,7 +17,7 @@ VALGRIND_AUTORECONF = YES
 # not. Therefore, we adjust the host tuple to specify we're on
 # ARMv7. The valgrind package is guaranteed, through Config.in, to
 # only be selected on Cortex A8 and Cortex A9 platforms.
-ifeq ($(BR2_cortex_a8)$(BR2_cortex_a9),y)
Quoted 8 lines
Quoted 4 lines
package/valgrind/valgrind.mk +1 -0
+ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),y)
 VALGRIND_CONF_OPT += \
 	--host=$(patsubst arm-%,armv7-%,$(GNU_TARGET_NAME))

endif

In fact, mips64+n32 abi is not supported, so I think
this should be reflected too. I guess the same applies to the the le variant...

Right, but it's not an issue introduced by this new patch.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#4 lore raw

PATCH 1/1 valgrind: allow building on more ARM systems

In reply to Mike Williams

Dear Mike Williams,

Quoted 5 lines · Mike Williams
Signed-off-by Mike Williams <[email protected]>
---
 package/valgrind/Config.in   | 7 ++++---
 package/valgrind/valgrind.mk | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com