Skip to contentSkip to conversation

Make it possible to use breakpad in an SDK

PATCH In review Anders Darander 2 participants 5 messages Sep 29, 2014 – Oct 3, 2014

lore
Share & tools
lore
#0 lore raw

cover Make it possible to use breakpad in an SDK

When building an SDK (using <image> -c populate_sdk), for an image where an application depends on breakpad, we need to add the static library, libbreakpad_client.a, to the SDK. Thus, we need to make sure that it gets installed and packaged to breakpad-staticdev.

The following changes since commit 0d01e1b72333f49c29d1a27ad844c4cd9f90341c:

smartmontools: add systemd service file (2014-09-26 05:42:54 +0200)

are available in the git repository at:

git://github.com/darander/meta-openembedded c3982a9e7a7182cfb3f0147477202f0c7b15858a
https://github.com/darander/meta-openembedded/tree/breakpad-sdk

Anders Darander (1):
breakpad: install static library

 meta-oe/recipes-devtools/breakpad/breakpad_svn.bb | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 breakpad: install static library

In order to build against breakpad when using an SDK, we need to also package libbreakpad_client.a.

The SDK will then need to add breakpad-staticdev to TOOLCHAIN_TARGET_TASK.

---
 meta-oe/recipes-devtools/breakpad/breakpad_svn.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-devtools/breakpad/breakpad_svn.bb +3 -0
index 2c5941d..571e1d3 100644
@@ -56,6 +56,9 @@ do_install_append() {
 
         install -d ${D}${includedir}/breakpad/third_party/lss
         install -m 0644 ${S}/src/third_party/lss/linux_syscall_support.h ${D}${includedir}/breakpad/third_party/lss/linux_syscall_support.h
+
+        install -d ${D}${libdir}
+        install -m 0644 ${S}/src/client/linux/libbreakpad_client.a ${D}${libdir}/libbreakpad_client.a
 }
 
 PACKAGES =+ "${PN}-minidump-upload ${PN}-sym-upload"
Signature · 1 line
2.1.1
#2 lore raw

Re: [meta-oe] [PATCH 1/1] breakpad: install static library

Quoted 4 lines · Anders Darander

In order to build against breakpad when using an SDK, we need to also package libbreakpad_client.a.

The SDK will then need to add breakpad-staticdev to TOOLCHAIN_TARGET_TASK.

Fails in world builds:

|  ( cd '/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/image/usr/lib' && arm-oe-linux-gnueabi-ranlib libbreakpad.a )
|  ( cd '/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/image/usr/lib' && arm-oe-linux-gnueabi-ranlib libbreakpad_client.a )
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/build'
| install: cannot stat `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/trunk/src/client/linux/libbreakpad_client.a': No such file or directory
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_install (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/temp/log.do_install.11600)

NOTE: recipe breakpad-svn-r0: task do_install: Failed

I guess it should be installed from ${B}

Please re-test and re-send.

Quoted 28 lines
---
 meta-oe/recipes-devtools/breakpad/breakpad_svn.bb | 3 +++
 1 file changed, 3 insertions(+)
meta-oe/recipes-devtools/breakpad/breakpad_svn.bb +3 -0
index 2c5941d..571e1d3 100644
@@ -56,6 +56,9 @@ do_install_append() {
 
         install -d ${D}${includedir}/breakpad/third_party/lss
         install -m 0644 ${S}/src/third_party/lss/linux_syscall_support.h ${D}${includedir}/breakpad/third_party/lss/linux_syscall_support.h
+
+        install -d ${D}${libdir}
+        install -m 0644 ${S}/src/client/linux/libbreakpad_client.a ${D}${libdir}/libbreakpad_client.a
 }
 
 PACKAGES =+ "${PN}-minidump-upload ${PN}-sym-upload"
Signature · 7 lines
2.1.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

Re: [meta-oe] [PATCH 1/1] breakpad: install static library

Quoted 13 lines · Martin Jansa
Quoted 4 lines · Anders Darander

In order to build against breakpad when using an SDK, we need to also package libbreakpad_client.a.

The SDK will then need to add breakpad-staticdev to TOOLCHAIN_TARGET_TASK.

Fails in world builds:

|  ( cd '/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/image/usr/lib' && arm-oe-linux-gnueabi-ranlib libbreakpad.a )
|  ( cd '/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/image/usr/lib' && arm-oe-linux-gnueabi-ranlib libbreakpad_client.a )
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/build'
| install: cannot stat `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/trunk/src/client/linux/libbreakpad_client.a': No such file or directory
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_install (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/breakpad/svn-r0/temp/log.do_install.11600)
Quoted 3 lines

NOTE: recipe breakpad-svn-r0: task do_install: Failed

I guess it should be installed from ${B}

Thanks, I'll re-test and send a v2 once I've made a clean build.

I guess I mixed up all my own branches, as most of the work has been done on a daisy-based branch. :(

Cheers,
Anders

#4 lore raw

Re: [meta-oe] [PATCH 1/1] breakpad: install static library

Hi,

Quoted 1 line · Anders Darander

Thanks, I'll re-test and send a v2 once I've made a clean build.

I've marked this patched as "Not applicable" in pathchwork. This time I should've done my homework a lot better. The patch originates from a customers project, however, they were running an older meta-oe release. With the current recipe in meta-oe, this patch is not needed.

Quoted 2 lines

I guess I mixed up all my own branches, as most of the work has been done on a daisy-based branch. :(

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB