Skip to contentSkip to conversation

USB: serial: cp210x: Add Silicon Labs 358x VID and PID.

PATCH In review Nathaniel Ting 2 participants 2 messages Oct 3, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: serial: cp210x: Add Silicon Labs 358x VID and PID.

From: Nathaniel Ting <[email protected]>

Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now connect to host PCs over a USB serial link.

---
 drivers/usb/serial/cp210x.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/serial/cp210x.c +1 -0
index e4bb622..ce81fa8 100644
@@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
 	{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
 	{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
+        { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */
 	{ USB_DEVICE(0x1BE3, 0x07A6) }, /* WAGO 750-923 USB Service Cable */
 	{ USB_DEVICE(0x1E29, 0x0102) }, /* Festo CPX-USB */
 	{ USB_DEVICE(0x1E29, 0x0501) }, /* Festo CMSP */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 16 lines · Nathaniel Ting

From: Nathaniel Ting <[email protected]>

Enable Silicon Labs Ember VID chips to enumerate with the cp210x usb serial driver. EM358x devices operating with the Ember Z-Net 5.1.2 stack may now connect to host PCs over a USB serial link.

---
 drivers/usb/serial/cp210x.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/serial/cp210x.c +0 -0
index e4bb622..ce81fa8 100644

drivers/usb/serial/cp210x.c static const struct usb_device_id id_table[] = { · line 157

Quoted 4 lines
drivers/usb/serial/cp210x.c +1 -0
@@ -154,6 +154,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
 	{ USB_DEVICE(0x1ADB, 0x0001) }, /* Schweitzer Engineering C662 Cable */
 	{ USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair USB Dongle */
+        { USB_DEVICE(0x1BA4, 0x0002) }, /* Silicon Labs 358x factory default */

Close, but if you ran your patch through checkpatch.pl you would see that you used spaces instead of tabs for indentation.

At least the tabs on the other lines came through correctly, which is good.

Care to fix this up and try again?

thanks,

greg k-h