Skip to contentSkip to conversation

protobuf: bump version to 2.6.0

PATCH Superseded Matt Weber 3 participants 6 messages Oct 2, 2014 – Oct 4, 2014

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

* Adds powerpc architecture support
* Changes to the new github upstream site
* Updates the license filename

Signed-off-by Matt Weber <[email protected]>

---

Changes v1 -> v2
- Updated to not change license file. Had looked a tip not tag for 2.6.0 so it actually didn't changed in the latest release.(Suggested by Peter K.)

 package/protobuf/Config.in   |    7 +++----
 package/protobuf/protobuf.mk |    4 ++--
 2 files changed, 5 insertions(+), 6 deletions(-)
package/protobuf/Config.in +3 -4
index 6015b13..e45ed14 100644
@@ -3,17 +3,16 @@ config BR2_PACKAGE_PROTOBUF
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# See src/google/protobuf/stubs/platform_macros.h for supported archs.
-	# PowerPC doesn't actually work.
-	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 || BR2_powerpc
 	# host-protobuf only builds on certain architectures
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.
 
-	  http://code.google.com/p/protobuf/
+	  https://github.com/google/protobuf/
 
 comment "protobuf needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 || BR2_powerpc
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
package/protobuf/protobuf.mk +2 -2
index f5e11df..c8f5d63 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-PROTOBUF_VERSION = 2.5.0
-PROTOBUF_SITE = http://protobuf.googlecode.com/files
+PROTOBUF_VERSION = 2.6.0
+PROTOBUF_SITE = https://github.com/google/protobuf/releases/download/v$(PROTOBUF_VERSION)/
 PROTOBUF_LICENSE = BSD-3c
 PROTOBUF_LICENSE_FILES = COPYING.txt
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Matt" == Matt Weber <[email protected]> writes:

* Adds powerpc architecture support
* Changes to the new github upstream site
* Updates the license filename

Quoted 7 lines
Signed-off-by Matt Weber <[email protected]>

---

Changes v1 -> v2
- Updated to not change license file. Had looked a tip not tag for 2.6.0 so it actually didn't changed in the latest release.(Suggested by Peter K.)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

In reply to Matt Weber

Dear Matt Weber,

Quoted 11 lines · Matt Weber

* Adds powerpc architecture support
* Changes to the new github upstream site
* Updates the license filename

Signed-off-by Matt Weber <[email protected]>

---

Changes v1 -> v2
- Updated to not change license file. Had looked a tip not tag for 2.6.0 so it actually didn't changed in the latest release.(Suggested by Peter K.)

This bump seems to have broken some packages that depend on protobuf:

* host-protobuf-c-v1.0.0-rc1
http://autobuild.buildroot.org/results/647/64707ecd9acfbf519d5f22dd6bd5b39c3b544073/build-end.log

* python-protobuf-2.6.0
http://autobuild.buildroot.org/results/b3b/b3b36c72b233a624ebae9eaac592b7c6fbd394be/build-end.log

Could you have a look?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

Thomas,

Quoted 11 lines · Thomas Petazzoni

Dear Matt Weber,

Quoted 7 lines · Matt Weber

* Adds powerpc architecture support
* Changes to the new github upstream site
* Updates the license filename

Signed-off-by Matt Weber <[email protected]>

---

Quoted 9 lines
Quoted 4 lines

Changes v1 -> v2
- Updated to not change license file. Had looked a tip not tag for 2.6.0 so it actually didn't changed in the latest release.(Suggested by Peter K.)

This bump seems to have broken some packages that depend on protobuf:

* host-protobuf-c-v1.0.0-rc1

http://autobuild.buildroot.org/results/647/64707ecd9acfbf519d5f22dd6bd5b39c3b544073/build-end.log

Quoted 3 lines

* python-protobuf-2.6.0

http://autobuild.buildroot.org/results/b3b/b3b36c72b233a624ebae9eaac592b7c6fbd394be/build-end.log

Quoted 2 lines

Could you have a look?

Sure

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141004/4516aed5/attachment.html>

author
#4 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

In reply to Thomas Petazzoni

Thomas,

Quoted 15 lines · Thomas Petazzoni

Dear Matt Weber,

Quoted 11 lines · Matt Weber

* Adds powerpc architecture support
* Changes to the new github upstream site
* Updates the license filename

Signed-off-by Matt Weber <[email protected]>

---

Changes v1 -> v2
- Updated to not change license file. Had looked a tip not tag for 2.6.0 so it actually didn't changed in the latest release.(Suggested by Peter K.)

Quoted 4 lines

This bump seems to have broken some packages that depend on protobuf:

* host-protobuf-c-v1.0.0-rc1
http://autobuild.buildroot.org/results/647/64707ecd9acfbf519d5f22dd6bd5b39c3b544073/build-end.log

Known issue https://github.com/protobuf-c/protobuf-c/issues/163.
I'll bump protobuf-c to v1.0.2 and retest.

Quoted 3 lines

* python-protobuf-2.6.0
http://autobuild.buildroot.org/results/b3b/b3b36c72b233a624ebae9eaac592b7c6fbd394be/build-end.log

This one is a failure on dependencies that the setup.py is trying to download. What's the general feeling with setuptools doing downloads on it's own? I assume we need to add those python packages to buildroot and correct the missing dependencies?
Initially it looks like the package dependency list would be:
google_apputils
pytz
python_gflags
I'm not to familiar with how setuptools checks for dependencies existing before defaulting to retrieving a pypi archive. Does it check the sysroot path we point it at to make the decision?

Thanks,

Signature · 8 lines
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.
#5 lore raw

PATCH v2 1/1 protobuf: bump version to 2.6.0

Dear Matthew Weber,

Quoted 5 lines · Matthew Weber
Quoted 2 lines

* host-protobuf-c-v1.0.0-rc1
http://autobuild.buildroot.org/results/647/64707ecd9acfbf519d5f22dd6bd5b39c3b544073/build-end.log

Known issue https://github.com/protobuf-c/protobuf-c/issues/163.
I'll bump protobuf-c to v1.0.2 and retest.

Sounds good.

Quoted 7 lines
Quoted 2 lines

* python-protobuf-2.6.0
http://autobuild.buildroot.org/results/b3b/b3b36c72b233a624ebae9eaac592b7c6fbd394be/build-end.log

This one is a failure on dependencies that the setup.py is trying to download. What's the general feeling with setuptools doing downloads on it's own? I assume we need to add those python packages to buildroot and correct the missing dependencies?

Absolutely.

Quoted 7 lines

Initially it looks like the package dependency list would be:
google_apputils
pytz
python_gflags
I'm not to familiar with how setuptools checks for dependencies existing before defaulting to retrieving a pypi archive. Does it check the sysroot path we point it at to make the decision?

I don't really know. I guess it checks in PYTHONPATH.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com