Skip to contentSkip to conversation

package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

PATCH New Samuel Martin 3 participants 5 messages Oct 4, 2014

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

PATCH 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-cmake.mk +1 -1
index 85d8828..2bea003 100644
@@ -41,7 +41,7 @@ $(2)_CONF_OPTS			?=
 $(2)_MAKE			?= $$(MAKE)
 $(2)_MAKE_ENV			?=
 $(2)_MAKE_OPTS			?=
-$(2)_INSTALL_HOST_OPTS		?= install
+$(2)_INSTALL_OPTS		?= install
 $(2)_INSTALL_STAGING_OPTS	?= DESTDIR=$$(STAGING_DIR) install
 $(2)_INSTALL_TARGET_OPTS		?= DESTDIR=$$(TARGET_DIR) install
Signature · 1 line
2.1.2
#1 lore raw

PATCH 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

Dear Samuel Martin,

Quoted 6 lines · Samuel Martin

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

Quoted 8 lines

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What about the manual?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

Thomas, All,

On 2014-10-04 19:21 +0200, Thomas Petazzoni spake thusly:

Quoted 11 lines

Dear Samuel Martin,

Quoted 8 lines · Samuel Martin

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Quoted 8 lines
Quoted 6 lines
Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What about the manual?

That's what I thought at first, too. But there is no reason to document it, as it is already covered in generic package infra:

* HOST_LIBFOO_INSTALL_CMDS lists the actions to be performed to install the package, when the package is a host package. [...]

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#3 lore raw

PATCH 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

In reply to Thomas Petazzoni

Thomas,

Quoted 11 lines · Thomas Petazzoni

Dear Samuel Martin,

Quoted 8 lines · Samuel Martin

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Quoted 8 lines
Quoted 6 lines
Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

What about the manual?

There is no mention of _INSTALL_OPTS or _INSTALL_HOST_OPTS in the manual. Shall I add one? (not even in the generic infra doc).

It seems host-package documentation is +/- missing in the manual. :-/

BTW, do not apply this patch, I forgot some occurence of the renaming.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thanks,

Signature · 1 line
Samuel
#4 lore raw

PATCH 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

In reply to Samuel Martin

Samuel, All,

On 2014-10-04 19:19 +0200, Samuel Martin spake thusly:

Quoted 11 lines

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/pkg-cmake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-cmake.mk +1 -1
index 85d8828..2bea003 100644
@@ -41,7 +41,7 @@ $(2)_CONF_OPTS			?=
 $(2)_MAKE			?= $$(MAKE)
 $(2)_MAKE_ENV			?=
 $(2)_MAKE_OPTS			?=
-$(2)_INSTALL_HOST_OPTS		?= install
+$(2)_INSTALL_OPTS		?= install
 $(2)_INSTALL_STAGING_OPTS	?= DESTDIR=$$(STAGING_DIR) install
 $(2)_INSTALL_TARGET_OPTS		?= DESTDIR=$$(TARGET_DIR) install
Signature · 6 lines
2.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'