Skip to contentSkip to conversation

package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

PATCH New Samuel Martin 3 participants 3 messages Oct 4, 2014

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

PATCH v2 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/pkg-cmake.mk +2 -2
index 85d8828..92574e2 100644
@@ -41,7 +41,7 @@ $(2)_CONF_OPTS			?=
 $(2)_MAKE			?= $$(MAKE)
 $(2)_MAKE_ENV			?=
 $(2)_MAKE_OPTS			?=
-$(2)_INSTALL_HOST_OPTS		?= install
+$(2)_INSTALL_OPTS		?= install
 $(2)_INSTALL_STAGING_OPTS	?= DESTDIR=$$(STAGING_DIR) install
 $(2)_INSTALL_TARGET_OPTS		?= DESTDIR=$$(TARGET_DIR) install
 

@@ -126,7 +126,7 @@ endif
 #
 ifndef $(2)_INSTALL_CMDS
 define $(2)_INSTALL_CMDS
-	$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_HOST_OPTS) -C $$($$(PKG)_BUILDDIR)
+	$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_OPTS) -C $$($$(PKG)_BUILDDIR)
 endef
 endif
Signature · 1 line
2.1.2
#1 lore raw

PATCH v2 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

Samuel Martin <[email protected]> schreef:

Quoted 1 line

This pacth renames, consistently with the other package infrastructures,

patch

Best regards,
Thomas

Applied
#2 lore raw

PATCH v2 1/1 package/pkg-cmake.mk: rename _INSTALL_HOST_OPTS -> _INSTALL_OPTS

In reply to Samuel Martin

Dear Samuel Martin,

Quoted 6 lines · Samuel Martin

This pacth renames, consistently with the other package infrastructures, the _INSTALL_OPTS variable for host CMake-based package.

As mentioned in [1], no host-cmake-package uses this variable so far; so it is a safe rename.

Quoted 8 lines

[1] http://lists.busybox.net/pipermail/buildroot/2014-October/107712.html

Reported-by "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Samuel Martin <[email protected]>
---
 package/pkg-cmake.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks, applied, after fixing the typo noticed by Thomas DS.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com