Skip to contentSkip to conversation

package-infra: comment why all checks are done in pkg-generic

PATCH New Yann E. MORIN 3 participants 3 messages Oct 5, 2014

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package-infra: comment why all checks are done in pkg-generic

Reported-by Thomas Petazzoni <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---
Note: this goes hand-in-hand with, but does not depend on, the previous patch from Thomas DS: http://patchwork.ozlabs.org/patch/396613/
But it replaces: http://patchwork.ozlabs.org/patch/396614/

---
 package/pkg-generic.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/pkg-generic.mk +4 -0
index 3e1eefa..598c0c0 100644
@@ -703,6 +703,10 @@ $$(foreach pkg,$$($(2)_PROVIDES),\
 endif
 
 # Ensure unified variable name conventions between all packages
+# Some of the variables are used by more than one infrastructure; so, rather
+# than duplicate the checks in each infrastructure, we check all variables
+# here in pkg-generic, even though pkg-generic should have no knowledge of
+# infra-specific variables.
 $(eval $(call check-deprecated-variable,$(2)_MAKE_OPT,$(2)_MAKE_OPTS))
 $(eval $(call check-deprecated-variable,$(2)_INSTALL_OPT,$(2)_INSTALL_OPTS))
 $(eval $(call check-deprecated-variable,$(2)_INSTALL_TARGET_OPT,$(2)_INSTALL_TARGET_OPTS))
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 package-infra: comment why all checks are done in pkg-generic

In reply to Yann E. MORIN

Dear Yann E. MORIN,

package/pkg-generic.mk $$(foreach pkg,$$($(2)_PROVIDES),\ · line 707

Quoted 3 lines · Yann E. MORIN

# Ensure unified variable name conventions between all packages

package/pkg-generic.mk +2 -0
+# Some of the variables are used by more than one infrastructure; so, rather
+# than duplicate the checks in each infrastructure, we check all variables

duplicate -> duplicating.

Applied with this fixed.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com