libbsd: Add missing arch
PATCH v2 1/1 libbsd: Add missing arch
Match the list of architecture to the comments above.
---
v1 -> v2:
- Remove m68k as it is currently marked broken in BR
--- package/libbsd/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
package/libbsd/Config.in +3 -3
@@ -1,8 +1,8 @@ config BR2_PACKAGE_LIBBSD bool "libbsd" # libbsd requires a.out.h, which is only available for those - # architectures: arm, m68k, x86 (and alpha, but we don't care.) - depends on ( BR2_i386 || BR2_x86_64 ) + # architectures: arm, x86 (and alpha, but we don't care.) + depends on ( BR2_i386 || BR2_x86_64 || BR2_arm) depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_TOOLCHAIN_USES_GLIBC help
@@ -15,5 +15,5 @@ config BR2_PACKAGE_LIBBSD http://libbsd.freedesktop.org/ comment "libbsd needs an (e)glibc toolchain w/ threads" - depends on ( BR2_i386 || BR2_x86_64 ) + depends on ( BR2_i386 || BR2_x86_64 || BR2_arm) depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
Signature · 1 line
2.1.1
PATCH v2 1/1 libbsd: Add missing arch
Dear Maxime Hadjinlian,
Quoted 3 lines · Maxime Hadjinlian
Match the list of architecture to the comments above.
Signed-off-by Maxime Hadjinlian <[email protected]>
The commit title should maybe become "libbsd: enable on the ARM architecture".
Quoted 12 lines
---
v1 -> v2:
- Remove m68k as it is currently marked broken in BR--- package/libbsd/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)package/libbsd/Config.in +0
-0
package/libbsd/Config.in line 5
Quoted 7 lines
package/libbsd/Config.in +2
-2@@ -1,8 +1,8 @@ config BR2_PACKAGE_LIBBSD bool "libbsd" # libbsd requires a.out.h, which is only available for those - # architectures: arm, m68k, x86 (and alpha, but we don't care.) - depends on ( BR2_i386 || BR2_x86_64 ) + # architectures: arm, x86 (and alpha, but we don't care.) + depends on ( BR2_i386 || BR2_x86_64 || BR2_arm)
I would keep the m68k in the comment for now, maybe something like:
"arm, x86 (and alpha, not supported in Buildroot, and m68k, currently not enabled, so cannot be tested)".
Also, alphabetic ordering of architectures please.
package/libbsd/Config.in config BR2_PACKAGE_LIBBSD · line 19
Quoted 10 lines
package/libbsd/Config.in +1
-1depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_TOOLCHAIN_USES_GLIBC help@@ -15,5 +15,5 @@ config BR2_PACKAGE_LIBBSD http://libbsd.freedesktop.org/ comment "libbsd needs an (e)glibc toolchain w/ threads" - depends on ( BR2_i386 || BR2_x86_64 ) + depends on ( BR2_i386 || BR2_x86_64 || BR2_arm) depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_USES_GLIBC
Since you will need to inherit the arch dependency in netcat-openbsd, I'd suggest you use the following construction:
config BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
bool default y if BR2_arm || BR2_i386 || BR2_x86_64
config BR2_PACKAGE_LIBBSD
bool "libbsd" ... depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
comment "libbsd needs ..."
depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
And then you can reuse BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS in netcat-openbsd as well.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com