Skip to contentSkip to conversation

usb: tegra: ULPI regression on tegra20

PATCH New Marcel Ziswiler 2 participants 2 messages Oct 3, 2014 – Oct 6, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: tegra: ULPI regression on tegra20

Trying to enumerate USB devices connected via ULPI to T20 failed as follows:

USB2: ULPI integrity check failed

Git bisecting revealed the following commit being at odds:

commit 2d34151f7501ddaa599897f0d89ad576126b03eb
usb: tegra: refactor PHY type selection

Looking at above commit one quickly identifies a copy paste error which this patch fixes. Happy ULPIing again (;-p).

---
 drivers/usb/host/ehci-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/ehci-tegra.c +2 -2
index 33e5ea9..5f0a98e 100644
@@ -305,11 +305,11 @@ static void init_phy_mux(struct fdt_usb *config, uint pts,
 #if defined(CONFIG_TEGRA20)
 	if (config->periph_id == PERIPH_ID_USBD) {
 		clrsetbits_le32(&usbctlr->port_sc1, PTS1_MASK,
-				PTS_UTMI << PTS1_SHIFT);
+				pts << PTS1_SHIFT);
 		clrbits_le32(&usbctlr->port_sc1, STS1);
 	} else {
 		clrsetbits_le32(&usbctlr->port_sc1, PTS_MASK,
-				PTS_UTMI << PTS_SHIFT);
+				pts << PTS_SHIFT);
 		clrbits_le32(&usbctlr->port_sc1, STS);
 	}
 #else
Signature · 1 line
1.9.3
Applied
#1 lore raw

PATCH 1/1 usb: tegra: ULPI regression on tegra20

Quoted 7 lines · Marcel Ziswiler

Trying to enumerate USB devices connected via ULPI to T20 failed as follows:

USB2: ULPI integrity check failed

Git bisecting revealed the following commit being at odds:

Quoted 7 lines

commit 2d34151f7501ddaa599897f0d89ad576126b03eb
usb: tegra: refactor PHY type selection

Looking at above commit one quickly identifies a copy paste error which this patch fixes. Happy ULPIing again (;-p).

Applied, thanks!

Best regards,
Marek Vasut