Skip to contentSkip to conversation

legal-info: fix bug leading to one package not being considered

PATCH New Thomas Petazzoni 2 participants 3 messages Oct 6, 2014 Kbuild

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 legal-info: fix bug leading to one package not being considered

Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was evaluated to something like this:

toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))

Yes, with the last two parenthesis. This had the effect that the zlib-legal-info rule was never called: the last package of $(TARGETS) $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info information.

Signed-off-by Thomas Petazzoni <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Luca Ceresoli <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 6068e7f..3f56648 100644
@@ -414,7 +414,7 @@ HOST_DEPS = $(sort $(foreach dep,\
 HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
 
 TARGETS_LEGAL_INFO := $(patsubst %,%-legal-info,\
-		$(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
+		$(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))
 
 dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
 	$(HOST_DIR) $(BINARIES_DIR)
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 legal-info: fix bug leading to one package not being considered

Thomas, All,

On 2014-10-06 18:16 +0200, Thomas Petazzoni spake thusly:

Quoted 5 lines

Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was evaluated to something like this:

toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))

Quoted 8 lines

Yes, with the last two parenthesis. This had the effect that the zlib-legal-info rule was never called: the last package of $(TARGETS) $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info information.

Signed-off-by Thomas Petazzoni <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Luca Ceresoli <[email protected]>

Oviously an issue, indeed.

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 6068e7f..3f56648 100644
@@ -414,7 +414,7 @@ HOST_DEPS = $(sort $(foreach dep,\
 HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
 
 TARGETS_LEGAL_INFO := $(patsubst %,%-legal-info,\
-		$(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
+		$(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))
 
 dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
 	$(HOST_DIR) $(BINARIES_DIR)
Signature · 1 line
2.0.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH 1/1 legal-info: fix bug leading to one package not being considered

In reply to Thomas Petazzoni

Hello,

Quoted 10 lines · Thomas Petazzoni

Due to excessive parenthesis, the TARGETS_LEGAL_INFO expression was evaluated to something like this:

toolchain-legal-info toolchain-external-legal-info busybox-legal-info zlib-legal-info))

Yes, with the last two parenthesis. This had the effect that the zlib-legal-info rule was never called: the last package of $(TARGETS) $(TARGET_HOST_DEPS) $(HOST_DEPS) was never added in the legal-info information.

Quoted 6 lines
Signed-off-by Thomas Petazzoni <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Luca Ceresoli <[email protected]>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com