Skip to contentSkip to conversation

dt: bindings: tps65217: add compatible property for subnodes

PATCH In review Johannes Pointner 2 participants 6 messages Sep 25, 2014 – Oct 8, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 dt: bindings: tps65217: add compatible property for subnodes

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +6 -1
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 
@@ -23,9 +26,11 @@ Example:
 
 	tps: tps@24 {
 		compatible = "ti,tps65217";
+		reg = <0x24>;
 		ti,pmic-shutdown-controller;
 
-		regulators {
+		tps_pmic: regulators {
+			compatible = "ti,tps65217-pmic";
 			dcdc1_reg: dcdc1 {
 				regulator-min-microvolt = <900000>;
 				regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +6 -3
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
 Example:
 
 	tps: tps@24 {
 		reg = <0x24>;
 		compatible = "ti,tps65217";
-		backlight {
+		tps_bl: backlight {
+			compatible = "ti,tps65217-bl";
 			isel = <1>;  /* 1 - ISET1, 2 ISET2 */
 			fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
 			default-brightness = <50>;
Signature · 5 lines
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 23 lines · Johannes Pointner

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +3 -0
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 32

Quoted 8 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +2 -1
@@ -23,9 +26,11 @@ Example:
 
 	tps: tps@24 {
 		compatible = "ti,tps65217";
+		reg = <0x24>;
 		ti,pmic-shutdown-controller;
 
-		regulators {
+		tps_pmic: regulators {

How is the tps_pmic label used?

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 33

Quoted 1 line
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -0
+			compatible = "ti,tps65217-pmic";

I'd like to see a '\n' here.

Quoted 17 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +0 -0
 			dcdc1_reg: dcdc1 {
 				regulator-min-microvolt = <900000>;
 				regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +4 -1
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 22

Quoted 10 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +0 -1
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
 Example:
 
 	tps: tps@24 {
 		reg = <0x24>;
 		compatible = "ti,tps65217";

I'd like to see a '\n' here.

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 23

Quoted 2 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -1
-		backlight {
+		tps_bl: backlight {

Same here. Is this label used?

Quoted 4 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -0
+			compatible = "ti,tps65217-bl";
 			isel = <1>;  /* 1 - ISET1, 2 ISET2 */
 			fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
 			default-brightness = <50>;
Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw

2014-10-06 23:22 GMT+02:00 Lee Jones <[email protected]>:

Quoted 31 lines · Johannes Pointner
Quoted 30 lines

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +4 -0
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 
@@ -23,9 +26,11 @@ Example:
 
      tps: tps@24 {
              compatible = "ti,tps65217";
+             reg = <0x24>;
              ti,pmic-shutdown-controller;
 
Quoted 8 lines

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 32

Quoted 2 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -1
-             regulators {
+             tps_pmic: regulators {

How is the tps_pmic label used?

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 33

Quoted 1 line
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -0
+                     compatible = "ti,tps65217-pmic";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 23 lines
Quoted 23 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +0 -0
                      dcdc1_reg: dcdc1 {
                              regulator-min-microvolt = <900000>;
                              regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +4 -2
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
Quoted 7 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 22

Quoted 5 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +0 -0
 Example:
 
      tps: tps@24 {
              reg = <0x24>;
              compatible = "ti,tps65217";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 11 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 23

Quoted 3 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -1
-             backlight {
+             tps_bl: backlight {

Same here. Is this label used?

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 27

Quoted 4 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -0
+                     compatible = "ti,tps65217-bl";
                      isel = <1>;  /* 1 - ISET1, 2 ISET2 */
                      fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
                      default-brightness = <50>;
Quoted 5 lines

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Regarding the labels: The backlight label could be used like the following. I use it like this in my tests with the tilcdc panel driver which has a backlight support.

    panel {
        backlight = <&tps_bl>;

        panel-info {
            ac-bias        = <255>;
            ac-bias-intrpt    = <0>;
            dma-burst-sz    = <16>;
            bpp        = <32>;
            fdd        = <0x80>;
            sync-edge    = <0>;
            sync-ctrl    = <1>;
            .
            .
            .

I'm not sure if there could be actual use for the pmic label, but I thought if I add a label to backlight, I have to add one to the pmic too to keep it similar.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 103 lines · Johannes Pointner

2014-10-06 23:22 GMT+02:00 Lee Jones <[email protected]>:

Quoted 31 lines · Johannes Pointner
Quoted 30 lines

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +4 -0
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 
@@ -23,9 +26,11 @@ Example:
 
      tps: tps@24 {
              compatible = "ti,tps65217";
+             reg = <0x24>;
              ti,pmic-shutdown-controller;
 
Quoted 8 lines

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 32

Quoted 2 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -1
-             regulators {
+             tps_pmic: regulators {

How is the tps_pmic label used?

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 33

Quoted 1 line
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -0
+                     compatible = "ti,tps65217-pmic";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 23 lines
Quoted 23 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +0 -0
                      dcdc1_reg: dcdc1 {
                              regulator-min-microvolt = <900000>;
                              regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +4 -2
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
Quoted 7 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 22

Quoted 5 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +0 -0
 Example:
 
      tps: tps@24 {
              reg = <0x24>;
              compatible = "ti,tps65217";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 11 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 23

Quoted 3 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -1
-             backlight {
+             tps_bl: backlight {

Same here. Is this label used?

Quoted 4 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -0
+                     compatible = "ti,tps65217-bl";
                      isel = <1>;  /* 1 - ISET1, 2 ISET2 */
                      fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
                      default-brightness = <50>;

Regarding the labels: The backlight label could be used like the following. I use it like this in my tests with the tilcdc panel driver which has a backlight support.

    panel {
        backlight = <&tps_bl>;

        panel-info {
            ac-bias        = <255>;
            ac-bias-intrpt    = <0>;
            dma-burst-sz    = <16>;
            bpp        = <32>;
            fdd        = <0x80>;
            sync-edge    = <0>;
            sync-ctrl    = <1>;
            .
            .
            .
Quoted 3 lines

I'm not sure if there could be actual use for the pmic label, but I thought if I add a label to backlight, I have to add one to the pmic too to keep it similar.

No, not at all. If it's not used, you should remove it.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw

2014-10-08 12:47 GMT+02:00 Lee Jones <[email protected]>:

Quoted 105 lines · Johannes Pointner
Quoted 104 lines

2014-10-06 23:22 GMT+02:00 Lee Jones <[email protected]>:

Quoted 31 lines · Johannes Pointner
Quoted 30 lines

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +4 -0
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 
@@ -23,9 +26,11 @@ Example:
 
      tps: tps@24 {
              compatible = "ti,tps65217";
+             reg = <0x24>;
              ti,pmic-shutdown-controller;
 
Quoted 8 lines

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 32

Quoted 2 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -1
-             regulators {
+             tps_pmic: regulators {

How is the tps_pmic label used?

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 33

Quoted 1 line
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -0
+                     compatible = "ti,tps65217-pmic";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 23 lines
Quoted 23 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +0 -0
                      dcdc1_reg: dcdc1 {
                              regulator-min-microvolt = <900000>;
                              regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +4 -2
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
Quoted 7 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 22

Quoted 5 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +0 -0
 Example:
 
      tps: tps@24 {
              reg = <0x24>;
              compatible = "ti,tps65217";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 11 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 23

Quoted 3 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -1
-             backlight {
+             tps_bl: backlight {

Same here. Is this label used?

Quoted 4 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -0
+                     compatible = "ti,tps65217-bl";
                      isel = <1>;  /* 1 - ISET1, 2 ISET2 */
                      fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
                      default-brightness = <50>;

Regarding the labels: The backlight label could be used like the following. I use it like this in my tests with the tilcdc panel driver which has a backlight support.

    panel {
        backlight = <&tps_bl>;

        panel-info {
            ac-bias        = <255>;
            ac-bias-intrpt    = <0>;
            dma-burst-sz    = <16>;
            bpp        = <32>;
            fdd        = <0x80>;
            sync-edge    = <0>;
            sync-ctrl    = <1>;
            .
            .
            .
Quoted 5 lines
Quoted 3 lines

I'm not sure if there could be actual use for the pmic label, but I thought if I add a label to backlight, I have to add one to the pmic too to keep it similar.

No, not at all. If it's not used, you should remove it.

OK, my mistake, sorry.
I'll remove the pmic part of the patch and add the newline to the backlight documentation and resend the patch, if this is OK for you?

Quoted 6 lines

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#5 lore raw
Quoted 110 lines · Johannes Pointner

2014-10-08 12:47 GMT+02:00 Lee Jones <[email protected]>:

Quoted 109 lines · Johannes Pointner
Quoted 107 lines

2014-10-06 23:22 GMT+02:00 Lee Jones <[email protected]>:

Quoted 31 lines · Johannes Pointner
Quoted 30 lines

Add documentation for compatible property of subnodes.

---
 Documentation/devicetree/bindings/regulator/tps65217.txt         | 7 ++++++-
 .../devicetree/bindings/video/backlight/tps65217-backlight.txt   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/regulator/tps65217.txt +4 -0
index 4f05d20..8ae3a3b 100644
@@ -14,6 +14,9 @@ Required properties:
 Optional properties:
 - ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
 
+Required subnode properties:
+- compatible: "ti,tps65217-pmic"
+
   The valid names for regulators are:
   tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
 
@@ -23,9 +26,11 @@ Example:
 
      tps: tps@24 {
              compatible = "ti,tps65217";
+             reg = <0x24>;
              ti,pmic-shutdown-controller;
 
Quoted 8 lines

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 32

Quoted 2 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -1
-             regulators {
+             tps_pmic: regulators {

How is the tps_pmic label used?

Documentation/devicetree/bindings/regulator/tps65217.txt Example: · line 33

Quoted 1 line
Documentation/devicetree/bindings/regulator/tps65217.txt +1 -0
+                     compatible = "ti,tps65217-pmic";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 23 lines
Quoted 23 lines
Documentation/devicetree/bindings/regulator/tps65217.txt +0 -0
                      dcdc1_reg: dcdc1 {
                              regulator-min-microvolt = <900000>;
                              regulator-max-microvolt = <1800000>;
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +4 -2
index 5fb9279..f92f154 100644
@@ -6,19 +6,22 @@ used to drive LEDs for use as backlights.
 Required properties:
 - compatible: "ti,tps65217"
 - reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
 - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
 - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
 - default-brightness: valid values: 0-100
 
-Each regulator is defined using the standard binding for regulators.
 
Quoted 7 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 22

Quoted 5 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +0 -0
 Example:
 
      tps: tps@24 {
              reg = <0x24>;
              compatible = "ti,tps65217";

I'd like to see a '\n' here.

I will add a newline here.

Quoted 11 lines

Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt used to drive LEDs for use as backlights. · line 23

Quoted 3 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -1
-             backlight {
+             tps_bl: backlight {

Same here. Is this label used?

Quoted 4 lines
Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt +1 -0
+                     compatible = "ti,tps65217-bl";
                      isel = <1>;  /* 1 - ISET1, 2 ISET2 */
                      fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
                      default-brightness = <50>;

Regarding the labels: The backlight label could be used like the following. I use it like this in my tests with the tilcdc panel driver which has a backlight support.

    panel {
        backlight = <&tps_bl>;

        panel-info {
            ac-bias        = <255>;
            ac-bias-intrpt    = <0>;
            dma-burst-sz    = <16>;
            bpp        = <32>;
            fdd        = <0x80>;
            sync-edge    = <0>;
            sync-ctrl    = <1>;
            .
            .
            .

I'm not sure if there could be actual use for the pmic label, but I thought if I add a label to backlight, I have to add one to the pmic too to keep it similar.

Quoted 5 lines
Quoted 1 line

No, not at all. If it's not used, you should remove it.

OK, my mistake, sorry.
I'll remove the pmic part of the patch and add the newline to the backlight documentation and resend the patch, if this is OK for you?

Yes, fine.

Signature · 8 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html