Skip to contentSkip to conversation

Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

PATCH Superseded Sergei Shtylyov 3 participants 14 messages Oct 8, 2014 – Oct 24, 2014

Subsystems (2)
Device tree bindings SuperH

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH v3 1/3 Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

Hello.

Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20141007-v3.17' tag. Here we add the HS-USB device tree support on the R8A7791/Koelsch/Henninger reference boards. The patchset requires the USB PHY driver (already merged by Kishon and Greg) and the generic PHY support patches for the HS-USB driver posted by Yoshihiro Shimoda in order to work...

[1/3] ARM: shmobile: r8a7791: add HS-USB device node [2/3] ARM: shmobile: koelsch: enable HS-USB [3/3] ARM: shmobile: henninger: enable HS-USB

WBR, Sergei

author
#1 lore raw

PATCH v3 1/3 ARM: shmobile: r8a7791: add HS-USB device node

From: Yoshihiro Shimoda <[email protected]>

Define the R8A7791 generic part of the HS-USB device node. It is up to the board file to enable the device.

Signed-off-by Yoshihiro Shimoda <[email protected]>
[Sergei: fixed summary, added changelog]
Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 2:
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/r8a7791.dtsi +11 -0
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
===================================================================
@@ -637,6 +637,17 @@
 		status = "disabled";
 	};
 
+	hsusb: usb at e6590000 {
+		compatible = "renesas,usbhs-r8a7791";
+		reg = <0 0xe6590000 0 0x100>;
+		interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp7_clks R8A7791_CLK_HSUSB>;
+		renesas,buswait = <4>;
+		phys = <&usb0 1>;
+		phy-names = "usb";
+		status = "disabled";
+	};
+
 	usbphy: usb-phy at e6590100 {
 		compatible = "renesas,usb-phy-r8a7791";
 		reg = <0 0xe6590100 0 0x100>;
author
#3 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

In reply to Sergei Shtylyov

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/r8a7791-koelsch.dts +7 -0
Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
===================================================================
@@ -464,6 +464,13 @@
 	pinctrl-names = "default";
 };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };
#4 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Quoted 8 lines · Sergei Shtylyov

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Quoted 8 lines
Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;

did you miss pinctrl here ?

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141008/20dc452e/attachment.sig>
author
#5 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Hello.

Quoted 13 lines · Felipe Balbi
Quoted 12 lines

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 5 lines
Quoted 3 lines

---
Changes in version 3:
- added pinctrl-related properties;

did you miss pinctrl here ?

No, AFAICS. Or what do you mean?

WBR, Sergei

#6 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Quoted 17 lines · Sergei Shtylyov

Hello.

Quoted 12 lines · Felipe Balbi
Quoted 12 lines

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

---
Changes in version 3:
- added pinctrl-related properties;

did you miss pinctrl here ?

No, AFAICS. Or what do you mean?

usb0_pins doesn't appear to be defined anywhere.

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141008/9fa2c104/attachment.sig>
author
#7 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Quoted 17 lines · Felipe Balbi
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

did you miss pinctrl here ?

No, AFAICS. Or what do you mean?

usb0_pins doesn't appear to be defined anywhere.

They are defined in the same file, just not in this patch. If you're
looking at some of the USB trees or Linus' tree, the corresponding patch just hasn't hit them yet, it's in renesas.git ATM.

WBR, Sergei

#8 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Quoted 21 lines · Sergei Shtylyov
Quoted 18 lines · Felipe Balbi
Quoted 18 lines
Quoted 18 lines
Quoted 8 lines

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Quoted 8 lines
Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;

did you miss pinctrl here ?

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

No, AFAICS. Or what do you mean?

usb0_pins doesn't appear to be defined anywhere.

They are defined in the same file, just not in this patch. If you're
looking at some of the USB trees or Linus' tree, the corresponding patch just hasn't hit them yet, it's in renesas.git ATM.

oh, alright then. :-)

cheers

Signature · 8 lines
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141008/0243b3db/attachment.sig>
#9 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

In reply to Sergei Shtylyov

Hello.

Quoted 28 lines · Sergei Shtylyov

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
 1 file changed, 7 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
===================================================================

arch/arm/boot/dts/r8a7791-koelsch.dts line 470

Quoted 7 lines
arch/arm/boot/dts/r8a7791-koelsch.dts +4 -0
@@ -464,6 +464,13 @@
 	pinctrl-names = "default";
 };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";

Perhaps I don't understand the pinctrl world yet, but I have a question.

In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And, the "usb0_pins" is related to these USB0 pins. But, as you know, the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip. So, would you tell me why koelsch needs the pinctrl?

Best regards,
Yoshihiro Shimoda

Quoted 7 lines
arch/arm/boot/dts/r8a7791-koelsch.dts +3 -0
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };
author
#10 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Hello.

Quoted 36 lines · Yoshihiro Shimoda
Quoted 26 lines

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

  arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
  1 file changed, 7 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
===================================================================

arch/arm/boot/dts/r8a7791-koelsch.dts line 470

Quoted 7 lines
arch/arm/boot/dts/r8a7791-koelsch.dts +4 -0
@@ -464,6 +464,13 @@
  	pinctrl-names = "default";
  };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";

Perhaps I don't understand the pinctrl world yet, but I have a question.

Quoted 3 lines

In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And, the "usb0_pins" is related to these USB0 pins. But, as you know, the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.

The GPIO pins are not requested via pinctrl.

Quoted 1 line

So, would you tell me why koelsch needs the pinctrl?

Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify
the R8A7791 PFC driver in order to create a group consisting of that signal alone (like on R8A7790), because we don't need to read GP7_23 on these boards, unlike Lager.

Quoted 2 lines

Best regards,
Yoshihiro Shimoda

WBR, Sergei

#11 lore raw

PATCH v3 2/3 ARM: shmobile: koelsch: enable HS-USB

Hello.

Quoted 44 lines · Sergei Shtylyov

Hello.

Quoted 36 lines · Yoshihiro Shimoda
Quoted 26 lines

Enable HS-USB device for the Koelsch board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 3:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

  arch/arm/boot/dts/r8a7791-koelsch.dts |    7 +++++++
  1 file changed, 7 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7791-koelsch.dts
===================================================================

arch/arm/boot/dts/r8a7791-koelsch.dts line 470

Quoted 7 lines
arch/arm/boot/dts/r8a7791-koelsch.dts +4 -0
@@ -464,6 +464,13 @@
      pinctrl-names = "default";
  };
 
+&hsusb {
+    status = "okay";
+    pinctrl-0 = <&usb0_pins>;
+    pinctrl-names = "default";

Perhaps I don't understand the pinctrl world yet, but I have a question.

Quoted 3 lines

In r8a7791, the USB0_PWEN is GP7_23 and the USB0_OVC is GP7_24. And, the "usb0_pins" is related to these USB0 pins. But, as you know, the koelsch has a OTG ID pin and it connects to GP5_31 via MAX3355 chip.

Quoted 5 lines

The GPIO pins are not requested via pinctrl.

Quoted 1 line

So, would you tell me why koelsch needs the pinctrl?

Because at least USB0_OVC/VBUS is used by HS-USB. I decided not to modify the R8A7791 PFC driver in order to create a group consisting of that signal alone (like on R8A7790), because we don't need to read GP7_23 on these boards, unlike Lager.

Thank you very much for the reply.
Finally I understood why it needs the princtrl.
(I didn't know the HS-USB will use the USB0_OVC/VBUS for detecting VBUS...)

Best regards,
Yoshihiro Shimoda

Quoted 5 lines
Quoted 2 lines

Best regards,
Yoshihiro Shimoda

WBR, Sergei

author
#12 lore raw

PATCH v3 3/3 ARM: shmobile: henninger: enable HS-USB

In reply to Sergei Shtylyov

From: Yoshihiro Shimoda <[email protected]>

Enable HS-USB device for the Henninger board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip).

Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored.

Signed-off-by Yoshihiro Shimoda <[email protected]>

[Sergei: added pin function/group and prop, moved device node, fixed summary, added changelog]

Signed-off-by Sergei Shtylyov <[email protected]>

---
Changes in version 2:
- added pinctrl-related properties;
- moved the HS-USB node to precede the USB PHY node;
- uppercased "arm" in the summary;
- added changelog.

 arch/arm/boot/dts/r8a7791-henninger.dts |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/r8a7791-henninger.dts +7 -0
Index: renesas/arch/arm/boot/dts/r8a7791-henninger.dts
===================================================================
@@ -272,6 +272,13 @@
 	pinctrl-names = "default";
 };
 
+&hsusb {
+	status = "okay";
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+	renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>;
+};
+
 &usbphy {
 	status = "okay";
 };
#13 lore raw

PATCH v3 1/3 Add HS-USB device tree support for R8A7791/Koelsch/Henninger board

In reply to Sergei Shtylyov

Hi Simon-san,

Quoted 11 lines · Sergei Shtylyov

Hello.

Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20141007-v3.17' tag. Here we add the HS-USB device tree support on the R8A7791/Koelsch/Henninger reference boards. The patchset requires the USB PHY driver (already merged by Kishon and Greg) and the generic PHY support patches for the HS-USB driver posted by Yoshihiro Shimoda in order to work...

[1/3] ARM: shmobile: r8a7791: add HS-USB device node [2/3] ARM: shmobile: koelsch: enable HS-USB [3/3] ARM: shmobile: henninger: enable HS-USB

I will also rebase this patch set.

Best regards,
Yoshihiro Shimoda

Quoted 2 lines

WBR, Sergei