Skip to contentSkip to conversation

print true board names on socfpga

PATCH New Pavel Machek 3 participants 13 messages Oct 8, 2014 – Oct 9, 2014

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 print true board names on socfpga

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

---

This is against Marek's tree. Ignore the missing file for mainline.

board/altera/socfpga/socfpga_cyclone5.c +1 -1
index 7661ac9..43307f5 100644
@@ -17,7 +17,7 @@ DECLARE_GLOBAL_DATA_PTR;
  */
 int checkboard(void)
 {
-	puts("BOARD: Altera SoCFPGA Cyclone5 Board\n");
+	puts("BOARD: " CONFIG_BOARD_NAME "\n");
 	return 0;
 }
include/configs/mcvevk.h +2 -0
index 09b1eb2..0c5d688 100644
@@ -11,6 +11,8 @@
 #include "../../board/denx/mcvevk/iocsr_config.h"
 #include "../../board/denx/mcvevk/pll_config.h"
 
+#define CONFIG_BOARD_NAME "Denx MCVEVK Board"
+
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
 #ifndef MCVEVK_RECOVERY
include/configs/socfpga_cyclone5.h +2 -0
index bee328c..2a42389 100644
@@ -11,6 +11,8 @@
 #include "../../board/altera/socfpga/iocsr_config.h"
 #include "../../board/altera/socfpga/pll_config.h"
 
+#define CONFIG_BOARD_NAME "Altera SoCFPGA Cyclone5 Board"
+
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
 #include <config_cmd_default.h>
include/configs/wagabuibui.h +2 -0
index 458e1a1..c85bee4 100644
@@ -11,6 +11,8 @@
 #include "../../board/motec/wagabuibui/iocsr_config.h"
 #include "../../board/motec/wagabuibui/pll_config.h"
 
+#define CONFIG_BOARD_NAME "Wagabuibui Board"
+
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
 #include <config_cmd_default.h>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 4 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

Best regards,
Marek Vasut

author
#2 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 8 lines · Marek Vasut
Quoted 4 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 11 lines · Pavel Machek
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken :(

Best regards,
Marek Vasut

author
#4 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 7 lines · Marek Vasut
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken :(

Read the patch.

Currently, u-boot prints confusing board names during boot.

Now, you can explain what is wrong with the CC list, and what kind of tags you would like to see in the subject, or you could simply treat this patch as a bug report. You are the maintainter now, so you can fix it any way you want. I wanted to help, but clearly that is not welcome.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

PATCH 1/1 print true board names on socfpga

Hi Pavel,

Quoted 14 lines · Pavel Machek
Quoted 13 lines · Marek Vasut
Quoted 11 lines · Pavel Machek
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

Quoted 6 lines
Quoted 2 lines

What kind of names are you referring to ? Also, I see the CC list is also broken :(

Read the patch.

Currently, u-boot prints confusing board names during boot.

I'm not sure I understand either what the patch does. It touches board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to one single board. So, in this patch, CONFIG_BOARD_NAME can only contain the Cyclone5 board name. Does any other board use this file with a different CONFIG_BOARD_NAME?

Amicalement,

Signature · 1 line
Albert.
author
#6 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 23 lines · Albert ARIBAUD

Hi Pavel,

Quoted 19 lines · Pavel Machek
Quoted 7 lines · Marek Vasut
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken :(

Read the patch.

Quoted 7 lines
Quoted 1 line

Currently, u-boot prints confusing board names during boot.

I'm not sure I understand either what the patch does. It touches board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to one single board. So, in this patch, CONFIG_BOARD_NAME can only contain the Cyclone5 board name. Does any other board use this file with a different CONFIG_BOARD_NAME?

On marex's branch from 20141007
(e8e77ee38da8760d0fa3ebdae37924db71f1e496):

pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c"

Initial patch even said it is against Marek's tree...
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#7 lore raw

PATCH 1/1 print true board names on socfpga

Hi Pavel,

Quoted 32 lines · Pavel Machek
Quoted 23 lines · Albert ARIBAUD

Hi Pavel,

Quoted 19 lines · Pavel Machek
Quoted 7 lines · Marek Vasut
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken :(

Read the patch.

Quoted 7 lines
Quoted 1 line

Currently, u-boot prints confusing board names during boot.

I'm not sure I understand either what the patch does. It touches board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to one single board. So, in this patch, CONFIG_BOARD_NAME can only contain the Cyclone5 board name. Does any other board use this file with a different CONFIG_BOARD_NAME?

Quoted 5 lines

On marex's branch from 20141007
(e8e77ee38da8760d0fa3ebdae37924db71f1e496):

pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c"

Ok, so the Denx MCV EVK board uses the same file as the Altera SoCFPGA board, and without your patch, the Denx board would show itself as the Altera one.

Since the list of files touched by the patch does not provide any clue as to which other board(s) use the Altera SoCFPGA, can you post a V2 of your patch, with an amended commit message listing the other board(s) involved?

Quoted 1 line

Initial patch even said it is against Marek's tree...

Indeed -- I just did not realize that this board/ file was included in another board/ file.

Regarding tags, "arm:" and "socfpga:" should be fine.

Amicalement,

Signature · 1 line
Albert.
author
#8 lore raw

PATCH 1/1 print true board names on socfpga

Hi!

Quoted 15 lines
Quoted 5 lines

On marex's branch from 20141007
(e8e77ee38da8760d0fa3ebdae37924db71f1e496):

pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c"

Ok, so the Denx MCV EVK board uses the same file as the Altera SoCFPGA board, and without your patch, the Denx board would show itself as the Altera one.

Since the list of files touched by the patch does not provide any clue as to which other board(s) use the Altera SoCFPGA, can you post a V2 of your patch, with an amended commit message listing the other board(s) involved?

Quoted 4 lines
Quoted 1 line

Initial patch even said it is against Marek's tree...

Indeed -- I just did not realize that this board/ file was included in another board/ file.

It is not -- yet. AFAICT that is in Marek's tree (or was at some point) but not in mainline.

Marek can do git apply at this point, or maybe solve it some other way, but I don't think posting V2 would be helpful.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#9 lore raw

PATCH 1/1 print true board names on socfpga

In reply to Pavel Machek
Quoted 34 lines · Pavel Machek
Quoted 25 lines · Albert ARIBAUD

Hi Pavel,

Quoted 22 lines · Pavel Machek
Quoted 11 lines · Marek Vasut
Quoted 10 lines · Pavel Machek
Quoted 8 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

Quoted 7 lines
Quoted 2 lines

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken

:(

Read the patch.

Quoted 7 lines
Quoted 1 line

Currently, u-boot prints confusing board names during boot.

I'm not sure I understand either what the patch does. It touches board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to one single board. So, in this patch, CONFIG_BOARD_NAME can only contain the Cyclone5 board name. Does any other board use this file with a different CONFIG_BOARD_NAME?

Quoted 7 lines

On marex's branch from 20141007
(e8e77ee38da8760d0fa3ebdae37924db71f1e496):

pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c"

Initial patch even said it is against Marek's tree...

U-Boot-socfpga shows this:

$ git show e8e77ee38da8760d0fa3ebdae37924db71f1e496
fatal: bad object e8e77ee38da8760d0fa3ebdae37924db71f1e496

Now I am really thoroughly confused, sorry.

Best regards,
Marek Vasut

author
#10 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 7 lines
Quoted 7 lines

On marex's branch from 20141007
(e8e77ee38da8760d0fa3ebdae37924db71f1e496):

pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c"

Quoted 8 lines
Quoted 1 line

Initial patch even said it is against Marek's tree...

U-Boot-socfpga shows this:

$ git show e8e77ee38da8760d0fa3ebdae37924db71f1e496
fatal: bad object e8e77ee38da8760d0fa3ebdae37924db71f1e496

Now I am really thoroughly confused, sorry.

As I said, it was on your branch from 20141007.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#11 lore raw

PATCH 1/1 print true board names on socfpga

In reply to Pavel Machek
Quoted 17 lines · Pavel Machek
Quoted 16 lines · Marek Vasut
Quoted 11 lines · Pavel Machek
Quoted 7 lines · Marek Vasut
Quoted 3 lines · Pavel Machek

Make boards with Altera Socfpga print real board names.

Signed-off-by Pavel Machek <[email protected]>

Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in.

I wanted you to apply it to your tree. That way, the boards reach mainline with right names...

What kind of names are you referring to ? Also, I see the CC list is also broken

Quoted 7 lines
Quoted 1 line

:(

Read the patch.

Currently, u-boot prints confusing board names during boot.

Now, you can explain what is wrong with the CC list

It did contain non-existent email addresses, I fixed that.

Quoted 2 lines

, and what kind of
tags you would like to see in the subject

arm: and socfpga: please ... Albert, this is correct, right ?

Quoted 1 line

or you could simply treat this patch as a bug report.

How is this a bug if there is currently only one board supported which has the correct name please ?

Quoted 3 lines

You are the maintainter now, so you can
fix it any way you want. I wanted to help, but clearly that is not welcome.

Please let me remind you that a custodian is NOT here to do your share of the work for you and that nasty remarks will get you exactly nowhere. If you plan to help, then please prepare a patch which applies against current mainline and meets all the usual criteria ; this should not be that difficult afterall.

Best regards,
Marek Vasut

author
#12 lore raw

PATCH 1/1 print true board names on socfpga

Quoted 8 lines
Quoted 4 lines

You are the maintainter now, so you can
fix it any way you want. I wanted to help, but clearly that is not welcome.

Please let me remind you that a custodian is NOT here to do your share of the work for you and that nasty remarks will get you exactly nowhere.

There's nothing like "my share of work". I'm not a slave, I can choose what I do with my free time.

Quoted 3 lines

If you plan to help, then please prepare a patch which applies against current mainline and meets all the usual criteria ; this should not be that difficult afterall.

As I explained in my initial email, this is against your internal tree, not mainline. And yes, meeting "all the usual criteria" is hard, when the criteria are not listed anywhere. If you can provide the list, it may be easier.

For the record, I believe that wasting bandwith with patch resend because "it does not have right keywords in subject" would be wrong, especially since I clearly got your attention already. Other "usual criteria" you like to reject my patches with are "uses printf()" and "there are other bugs around the one you fixed". Those are not "usual criteria" in other opensource projects.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html